staging: vme_user: changed geoid data type from int to u32
PATCH v2 1/1 staging: vme_user: changed geoid data type from int to u32
Geoid is a module parameter which is set by root user.
Its valid values are between 0 and VME_MAX_SLOTS. So, changing data type of geoid from int to u32 since it will always be positive.
Signed-off-by Riyan Dhiman <[email protected]>
---
v1 -> v2: changed data type of geoid to u32 and removed negative geoid check
drivers/staging/vme_user/vme_fake.c | 6 +++--- drivers/staging/vme_user/vme_tsi148.c | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-)
drivers/staging/vme_user/vme_fake.c +3 -3
@@ -79,7 +79,7 @@ struct fake_driver { };/* Module parameter */ -static int geoid; +static u32 geoid;static const char driver_name[] ="vme_fake" ;
@@ -1059,7 +1059,7 @@ static int __init fake_init(void)struct vme_slave_resource *slave_image;struct vme_lm_resource *lm; -if (geoid <0 || geoid >=VME_MAX_SLOTS ) { +if (geoid >=VME_MAX_SLOTS ) {pr_err ("VME geographical address must be between 0 and %d (exclusive), but got %d\n" ,VME_MAX_SLOTS , geoid);return -EINVAL ;
@@ -1289,7 +1289,7 @@ static void __exit fake_exit(void) }MODULE_PARM_DESC (geoid,"Set geographical addressing" ); -module_param (geoid, int,0 ); +module_param (geoid, uint,0 );MODULE_DESCRIPTION ("Fake VME bridge driver" );MODULE_LICENSE ("GPL" );
drivers/staging/vme_user/vme_tsi148.c +3 -3
@@ -36,7 +36,7 @@ static void tsi148_remove(struct pci_dev *);/* Module parameter */ static bool err_chk; -static int geoid; +static u32 geoid;static const char driver_name[] ="vme_tsi148" ;
@@ -2252,7 +2252,7 @@ static int tsi148_probe(struct pci_dev *pdev, const struct pci_device_id *id)struct vme_dma_resource *dma_ctrlr;struct vme_lm_resource *lm; -if (geoid <0 || geoid >=VME_MAX_SLOTS ) { +if (geoid >=VME_MAX_SLOTS ) {dev_err (&pdev->dev,"VME geographical address must be between 0 and %d (exclusive), but got %d\n" ,VME_MAX_SLOTS , geoid);return -EINVAL ;
@@ -2631,7 +2631,7 @@ MODULE_PARM_DESC(err_chk, "Check for VME errors on reads and writes");module_param (err_chk, bool,0 );MODULE_PARM_DESC (geoid,"Override geographical addressing" ); -module_param (geoid, int,0 ); +module_param (geoid, uint,0 );MODULE_DESCRIPTION ("VME driver for the Tundra Tempe VME bridge" );MODULE_LICENSE ("GPL" );
Signature · 1 line
2.46.0