Skip to contentSkip to conversation

dt-bindings: lcdif: Document the dmas/dma-names properties

PATCH Applied Fabio Estevam 4 participants 5 messages Sep 3, 2024 – Sep 23, 2024

Subsystems (4)

v1 of 2 Applied Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 dt-bindings: lcdif: Document the dmas/dma-names properties

From: Fabio Estevam <[email protected]>

i.MX28 has an RX DMA channel associated with the LCDIF controller.

Document the 'dmas' and 'dma-names' properties to fix the following dt-schema warnings:

lcdif@80030000: 'dma-names', 'dmas' do not match any of the regexes: 'pinctrl-[0-9]+'

---
 .../bindings/display/fsl,lcdif.yaml           | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)
Documentation/devicetree/bindings/display/fsl,lcdif.yaml +19 -0
index 0681fc49aa1b..dd462abd61f8 100644
@@ -50,6 +50,14 @@ properties:
       - const: disp_axi
     minItems: 1
 
+  dmas:
+    items:
+      - description: DMA specifier for the RX DMA channel.
+
+  dma-names:
+    items:
+      - const: rx
+
   interrupts:
     items:
       - description: LCDIF DMA interrupt
@@ -156,6 +164,17 @@ allOf:
         interrupts:
           maxItems: 1
 
+  - if:
+      not:
+        properties:
+          compatible:
+            contains:
+              enum:
+                - fsl,imx28-lcdif
+    then:
+      properties:
+        dmas: false
+        dma-names: false
 examples:
   - |
     #include <dt-bindings/clock/imx6sx-clock.h>
Signature · 1 line
2.34.1
maintainer
#1 lore raw
Quoted 34 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

i.MX28 has an RX DMA channel associated with the LCDIF controller.

Document the 'dmas' and 'dma-names' properties to fix the following dt-schema warnings:

lcdif@80030000: 'dma-names', 'dmas' do not match any of the regexes: 'pinctrl-[0-9]+'

---
  .../bindings/display/fsl,lcdif.yaml           | 19 +++++++++++++++++++
  1 file changed, 19 insertions(+)
Documentation/devicetree/bindings/display/fsl,lcdif.yaml +8 -0
index 0681fc49aa1b..dd462abd61f8 100644
@@ -50,6 +50,14 @@ properties:
        - const: disp_axi
      minItems: 1
 
+  dmas:
+    items:
+      - description: DMA specifier for the RX DMA channel.
+
+  dma-names:
+    items:
+      - const: rx
+
    interrupts:
      items:
        - description: LCDIF DMA interrupt

Documentation/devicetree/bindings/display/fsl,lcdif.yaml allOf: · line 173

Quoted 10 lines
Documentation/devicetree/bindings/display/fsl,lcdif.yaml +7 -0
@@ -156,6 +164,17 @@ allOf:
          interrupts:
            maxItems: 1
 
+  - if:
+      not:
+        properties:
+          compatible:
+            contains:
+              enum:
+                - fsl,imx28-lcdif

This also applies to MX23 , that one also has the support for command-mode LCDs which are then driven by pumping commands via DMA. I don't think Linux actually supports this mode of operation, but I do recall using it some long time ago on MX23.

#2 lore raw

Hi Marek,

Quoted 4 lines · Marek Vasut

This also applies to MX23 , that one also has the support for command-mode LCDs which are then driven by pumping commands via DMA. I don't think Linux actually supports this mode of operation, but I do recall using it some long time ago on MX23.

I checked the i.MX23 Reference Manual and no LCDIF DMA entry is listed in either Table 10-1. APBH DMA Channel Assignments or Table 11-1. APBX DMA Channel Assignments.

Reviewed-by on v1 1/1
#3 lore raw
In reply to Fabio Estevam
Quoted 38 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

i.MX28 has an RX DMA channel associated with the LCDIF controller.

Document the 'dmas' and 'dma-names' properties to fix the following dt-schema warnings:

lcdif@80030000: 'dma-names', 'dmas' do not match any of the regexes: 'pinctrl-[0-9]+'

---
 .../bindings/display/fsl,lcdif.yaml           | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)
Documentation/devicetree/bindings/display/fsl,lcdif.yaml +9 -0
index 0681fc49aa1b..dd462abd61f8 100644
@@ -50,6 +50,14 @@ properties:
       - const: disp_axi
     minItems: 1
 
+  dmas:
+    items:
+      - description: DMA specifier for the RX DMA channel.
+
+  dma-names:
+    items:
+      - const: rx
+
   interrupts:
     items:
       - description: LCDIF DMA interrupt
@@ -156,6 +164,17 @@ allOf:
         interrupts:
           maxItems: 1
 
+  - if:

Documentation/devicetree/bindings/display/fsl,lcdif.yaml allOf: · line 177

Quoted 10 lines
Documentation/devicetree/bindings/display/fsl,lcdif.yaml +10 -0
+      not:
+        properties:
+          compatible:
+            contains:
+              enum:
+                - fsl,imx28-lcdif
+    then:
+      properties:
+        dmas: false
+        dma-names: false

Missing blank line.

Best regards,
Krzysztof

#4 lore raw
In reply to Fabio Estevam
Quoted 8 lines · Fabio Estevam

i.MX28 has an RX DMA channel associated with the LCDIF controller.

Document the 'dmas' and 'dma-names' properties to fix the following dt-schema warnings:

lcdif@80030000: 'dma-names', 'dmas' do not match any of the regexes: 'pinctrl-[0-9]+'

[...]

Applied to drm-misc-next, thanks!

[1/1] dt-bindings: lcdif: Document the dmas/dma-names properties

      commit: ee06d5f52c1d35e319bd240c8438ffe5ed02b24b

Best regards,

Signature · 2 lines
With best wishes
Dmitry