Skip to contentSkip to conversation

linux-next: build failure after merge of the drm-misc tree

DISCUSSION Stephen Rothwell 3 participants 3 messages Sep 4, 2024 Linux-next tree

lore
Share & tools
lore
#0 lore raw

Hi all,

After merging the drm-misc tree, today's linux-next build (x86_64 allmodconfig) failed like this:

drivers/gpu/drm/bridge/ti-tdp158.c: In function 'tdp158_enable':
drivers/gpu/drm/bridge/ti-tdp158.c:31:9: error: implicit declaration of function 'gpiod_set_value_cansleep' [-Wimplicit-function-declaration]

   31 |         gpiod_set_value_cansleep(tdp158->enable, 1);
      |         ^~~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/bridge/ti-tdp158.c: In function 'tdp158_probe':
drivers/gpu/drm/bridge/ti-tdp158.c:80:26: error: implicit declaration of function 'devm_gpiod_get_optional'; did you mean 'devm_regulator_get_optional'? [-Wimplicit-function-declaration]
   80 |         tdp158->enable = devm_gpiod_get_optional(dev, "enable", GPIOD_OUT_LOW);
      |                          ^~~~~~~~~~~~~~~~~~~~~~~
      |                          devm_regulator_get_optional

drivers/gpu/drm/bridge/ti-tdp158.c:80:65: error: 'GPIOD_OUT_LOW' undeclared (first use in this function)
80 | tdp158->enable = devm_gpiod_get_optional(dev, "enable", GPIOD_OUT_LOW);
| ^~~~~~~~~~~~~
drivers/gpu/drm/bridge/ti-tdp158.c:80:65: note: each undeclared identifier is reported only once for each function it appears in

Caused by commit

a15710027afb ("drm/bridge: add support for TI TDP158")

I have used the drm-misc tree from next-20240903 for today.

Signature · 2 lines
Cheers,
Stephen Rothwell
#1 lore raw
Quoted 19 lines · Stephen Rothwell

Hi all,

After merging the drm-misc tree, today's linux-next build (x86_64 allmodconfig) failed like this:

drivers/gpu/drm/bridge/ti-tdp158.c: In function 'tdp158_enable':
drivers/gpu/drm/bridge/ti-tdp158.c:31:9: error: implicit declaration of function 'gpiod_set_value_cansleep' [-Wimplicit-function-declaration]

   31 |         gpiod_set_value_cansleep(tdp158->enable, 1);
      |         ^~~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/bridge/ti-tdp158.c: In function 'tdp158_probe':
drivers/gpu/drm/bridge/ti-tdp158.c:80:26: error: implicit declaration of function 'devm_gpiod_get_optional'; did you mean 'devm_regulator_get_optional'? [-Wimplicit-function-declaration]
   80 |         tdp158->enable = devm_gpiod_get_optional(dev, "enable", GPIOD_OUT_LOW);
      |                          ^~~~~~~~~~~~~~~~~~~~~~~
      |                          devm_regulator_get_optional

drivers/gpu/drm/bridge/ti-tdp158.c:80:65: error: 'GPIOD_OUT_LOW' undeclared (first use in this function)
80 | tdp158->enable = devm_gpiod_get_optional(dev, "enable", GPIOD_OUT_LOW);
| ^~~~~~~~~~~~~
drivers/gpu/drm/bridge/ti-tdp158.c:80:65: note: each undeclared identifier is reported only once for each function it appears in

Quoted 5 lines

Caused by commit

a15710027afb ("drm/bridge: add support for TI TDP158")

I have used the drm-misc tree from next-20240903 for today.

Fixed by commit 532f0d109658 ("drm/bridge/tdp158: fix build failure") in drm-misc-next.

BR,
Jani.

Signature · 1 line
Jani Nikula, Intel
#2 lore raw
Quoted 28 lines · On Wed, Sep 4, 2024, 11:58 Jani Nikula <[email protected]> wrote:
Quoted 7 lines · Stephen Rothwell

Hi all,

After merging the drm-misc tree, today's linux-next build (x86_64 allmodconfig) failed like this:

drivers/gpu/drm/bridge/ti-tdp158.c: In function 'tdp158_enable':
drivers/gpu/drm/bridge/ti-tdp158.c:31:9: error: implicit declaration of

function 'gpiod_set_value_cansleep' [-Wimplicit-function-declaration]

Quoted 4 lines
   31 |         gpiod_set_value_cansleep(tdp158->enable, 1);
      |         ^~~~~~~~~~~~~~~~~~~~~~~~

drivers/gpu/drm/bridge/ti-tdp158.c: In function 'tdp158_probe':
drivers/gpu/drm/bridge/ti-tdp158.c:80:26: error: implicit declaration of

function 'devm_gpiod_get_optional'; did you mean 'devm_regulator_get_optional'? [-Wimplicit-function-declaration]

Quoted 1 line
   80 |         tdp158->enable = devm_gpiod_get_optional(dev, "enable",

GPIOD_OUT_LOW);

Quoted 3 lines
      |                          ^~~~~~~~~~~~~~~~~~~~~~~
      |                          devm_regulator_get_optional

drivers/gpu/drm/bridge/ti-tdp158.c:80:65: error: 'GPIOD_OUT_LOW'

undeclared (first use in this function)

Quoted 1 line
   80 |         tdp158->enable = devm_gpiod_get_optional(dev, "enable",

GPIOD_OUT_LOW);

Quoted 1 line
      |

^~~~~~~~~~~~~

Quoted 1 line

drivers/gpu/drm/bridge/ti-tdp158.c:80:65: note: each undeclared

identifier is reported only once for each function it appears in

Quoted 1 line
Quoted 9 lines
Quoted 5 lines

Caused by commit

a15710027afb ("drm/bridge: add support for TI TDP158")

I have used the drm-misc tree from next-20240903 for today.

Fixed by commit 532f0d109658 ("drm/bridge/tdp158: fix build failure") in drm-misc-next.

Thank you Jani