ARM: dts: microchip: sam9x60: Add missing property atmel,usart-mode

PATCH Superseded Andrei Simion 3 participants 4 messages Sep 5, 2024 – Sep 12, 2024

Subsystems (2)

Device tree bindings Arm/Microchip (AT91) SoC support

lore

Share & tools

lore

Andrei Simion

author

2024-09-05 09:31 UTC #0 lore raw

PATCH 1/1 ARM: dts: microchip: sam9x60: Add missing property atmel,usart-mode

~: make dtbs_check DT_SCHEMA_FILES=atmel,at91-usart.ymal
-> for all boards which inherit sam9x60.dtsi: serial@200: $nodename:0:
'serial@200' does not match '^spi(@.*|-([0-9]|[1-9][0-9]+))?$ serial@200: atmel,use-dma-rx: False schema does not allow True serial@200: atmel,use-dma-tx: False schema does not allow True serial@200: atmel,fifo-size: False schema does not allow [[16]] -> Means : atmel,usart-mode = <AT91_USART_MODE_SERIAL> misses for uart:
0,1,2,3,4,6,7,8,9,10,11,12

Add to uart nodes the property atmel,usart-mode to specify the driver to be used in serial mode to be compliant to atmel,at91-usart.yaml.

Fixes 99c808335877 ("ARM: dts: at91: sam9x60: Add missing flexcom definitions")

Signed-off-by Andrei Simion <[email protected]>

---
 arch/arm/boot/dts/microchip/sam9x60.dtsi | 12 ++++++++++++
 1 file changed, 12 insertions(+)

arch/arm/boot/dts/microchip/sam9x60.dtsi +12 -0

index 04a6d716ecaf..0ba424bba7cc 100644
@@ -174,6 +174,7 @@ flx4: flexcom@f0000000 {
 				uart4: serial@200 {
 					compatible = "microchip,sam9x60-usart", "atmel,at91sam9260-usart";
 					reg = <0x200 0x200>;
+					atmel,usart-mode = <AT91_USART_MODE_SERIAL>;
 					interrupts = <13 IRQ_TYPE_LEVEL_HIGH 7>;
 					dmas = <&dma0
 						(AT91_XDMAC_DT_MEM_IF(0) |

@@ -376,6 +377,7 @@ flx11: flexcom@f0020000 {
 				uart11: serial@200 {
 					compatible = "microchip,sam9x60-usart", "atmel,at91sam9260-usart";
 					reg = <0x200 0x200>;
+					atmel,usart-mode = <AT91_USART_MODE_SERIAL>;
 					interrupts = <32 IRQ_TYPE_LEVEL_HIGH 7>;
 					dmas = <&dma0
 						(AT91_XDMAC_DT_MEM_IF(0) |

@@ -427,6 +429,7 @@ flx12: flexcom@f0024000 {
 				uart12: serial@200 {
 					compatible = "microchip,sam9x60-usart", "atmel,at91sam9260-usart";
 					reg = <0x200 0x200>;
+					atmel,usart-mode = <AT91_USART_MODE_SERIAL>;
 					interrupts = <33 IRQ_TYPE_LEVEL_HIGH 7>;
 					dmas = <&dma0
 						(AT91_XDMAC_DT_MEM_IF(0) |

@@ -586,6 +589,7 @@ flx6: flexcom@f8010000 {
 				uart6: serial@200 {
 					compatible = "microchip,sam9x60-usart", "atmel,at91sam9260-usart";
 					reg = <0x200 0x200>;
+					atmel,usart-mode = <AT91_USART_MODE_SERIAL>;
 					interrupts = <9 IRQ_TYPE_LEVEL_HIGH 7>;
 					dmas = <&dma0
 						(AT91_XDMAC_DT_MEM_IF(0) |

@@ -637,6 +641,7 @@ flx7: flexcom@f8014000 {
 				uart7: serial@200 {
 					compatible = "microchip,sam9x60-usart", "atmel,at91sam9260-usart";
 					reg = <0x200 0x200>;
+					atmel,usart-mode = <AT91_USART_MODE_SERIAL>;
 					interrupts = <10 IRQ_TYPE_LEVEL_HIGH 7>;
 					dmas = <&dma0
 						(AT91_XDMAC_DT_MEM_IF(0) |

@@ -688,6 +693,7 @@ flx8: flexcom@f8018000 {
 				uart8: serial@200 {
 					compatible = "microchip,sam9x60-usart", "atmel,at91sam9260-usart";
 					reg = <0x200 0x200>;
+					atmel,usart-mode = <AT91_USART_MODE_SERIAL>;
 					interrupts = <11 IRQ_TYPE_LEVEL_HIGH 7>;
 					dmas = <&dma0
 						(AT91_XDMAC_DT_MEM_IF(0) |

@@ -739,6 +745,7 @@ flx0: flexcom@f801c000 {
 				uart0: serial@200 {
 					compatible = "microchip,sam9x60-usart", "atmel,at91sam9260-usart";
 					reg = <0x200 0x200>;
+					atmel,usart-mode = <AT91_USART_MODE_SERIAL>;
 					interrupts = <5 IRQ_TYPE_LEVEL_HIGH 7>;
 					dmas = <&dma0
 						(AT91_XDMAC_DT_MEM_IF(0) |

@@ -809,6 +816,7 @@ flx1: flexcom@f8020000 {
 				uart1: serial@200 {
 					compatible = "microchip,sam9x60-usart", "atmel,at91sam9260-usart";
 					reg = <0x200 0x200>;
+					atmel,usart-mode = <AT91_USART_MODE_SERIAL>;
 					interrupts = <6 IRQ_TYPE_LEVEL_HIGH 7>;
 					dmas = <&dma0
 						(AT91_XDMAC_DT_MEM_IF(0) |

@@ -879,6 +887,7 @@ flx2: flexcom@f8024000 {
 				uart2: serial@200 {
 					compatible = "microchip,sam9x60-usart", "atmel,at91sam9260-usart";
 					reg = <0x200 0x200>;
+					atmel,usart-mode = <AT91_USART_MODE_SERIAL>;
 					interrupts = <7 IRQ_TYPE_LEVEL_HIGH 7>;
 					dmas = <&dma0
 						(AT91_XDMAC_DT_MEM_IF(0) |

@@ -949,6 +958,7 @@ flx3: flexcom@f8028000 {
 				uart3: serial@200 {
 					compatible = "microchip,sam9x60-usart", "atmel,at91sam9260-usart";
 					reg = <0x200 0x200>;
+					atmel,usart-mode = <AT91_USART_MODE_SERIAL>;
 					interrupts = <8 IRQ_TYPE_LEVEL_HIGH 7>;
 					dmas = <&dma0
 						(AT91_XDMAC_DT_MEM_IF(0) |

@@ -1074,6 +1084,7 @@ flx9: flexcom@f8040000 {
 				uart9: serial@200 {
 					compatible = "microchip,sam9x60-usart", "atmel,at91sam9260-usart";
 					reg = <0x200 0x200>;
+					atmel,usart-mode = <AT91_USART_MODE_SERIAL>;
 					interrupts = <15 IRQ_TYPE_LEVEL_HIGH 7>;
 					dmas = <&dma0
 						(AT91_XDMAC_DT_MEM_IF(0) |

@@ -1125,6 +1136,7 @@ flx10: flexcom@f8044000 {
 				uart10: serial@200 {
 					compatible = "microchip,sam9x60-usart", "atmel,at91sam9260-usart";
 					reg = <0x200 0x200>;
+					atmel,usart-mode = <AT91_USART_MODE_SERIAL>;
 					interrupts = <16 IRQ_TYPE_LEVEL_HIGH 7>;
 					dmas = <&dma0
 						(AT91_XDMAC_DT_MEM_IF(0) |

base-commit: fdadd93817f124fd0ea6ef251d4a1068b7feceba

Signature · 1 line

2.34.1

Nicolas Ferre

maintainer Acked-by on v1 1/1

2024-09-05 14:36 UTC #1 lore raw

Quoted 9 lines · Andrei Simion

~: make dtbs_check DT_SCHEMA_FILES=atmel,at91-usart.ymal
-> for all boards which inherit sam9x60.dtsi: serial@200: $nodename:0:
'serial@200' does not match '^spi(@.*|-([0-9]|[1-9][0-9]+))?$ serial@200: atmel,use-dma-rx: False schema does not allow True serial@200: atmel,use-dma-tx: False schema does not allow True serial@200: atmel,fifo-size: False schema does not allow [[16]] -> Means : atmel,usart-mode = <AT91_USART_MODE_SERIAL> misses for uart:
0,1,2,3,4,6,7,8,9,10,11,12

Quoted 5 lines

Add to uart nodes the property atmel,usart-mode to specify the driver to be used in serial mode to be compliant to atmel,at91-usart.yaml.
Fixes 99c808335877 ("ARM: dts: at91: sam9x60: Add missing flexcom definitions")
Signed-off-by Andrei Simion <[email protected]>

Thanks Andrei:

Acked-by Nicolas Ferre <[email protected]>

Best regards,
Nicolas

Quoted 106 lines

---
  arch/arm/boot/dts/microchip/sam9x60.dtsi | 12 ++++++++++++
  1 file changed, 12 insertions(+)

arch/arm/boot/dts/microchip/sam9x60.dtsi +12 -0

index 04a6d716ecaf..0ba424bba7cc 100644
@@ -174,6 +174,7 @@ flx4: flexcom@f0000000 {
  				uart4: serial@200 {
  					compatible = "microchip,sam9x60-usart", "atmel,at91sam9260-usart";
  					reg = <0x200 0x200>;
+					atmel,usart-mode = <AT91_USART_MODE_SERIAL>;
  					interrupts = <13 IRQ_TYPE_LEVEL_HIGH 7>;
  					dmas = <&dma0
  						(AT91_XDMAC_DT_MEM_IF(0) |

@@ -376,6 +377,7 @@ flx11: flexcom@f0020000 {
  				uart11: serial@200 {
  					compatible = "microchip,sam9x60-usart", "atmel,at91sam9260-usart";
  					reg = <0x200 0x200>;
+					atmel,usart-mode = <AT91_USART_MODE_SERIAL>;
  					interrupts = <32 IRQ_TYPE_LEVEL_HIGH 7>;
  					dmas = <&dma0
  						(AT91_XDMAC_DT_MEM_IF(0) |

@@ -427,6 +429,7 @@ flx12: flexcom@f0024000 {
  				uart12: serial@200 {
  					compatible = "microchip,sam9x60-usart", "atmel,at91sam9260-usart";
  					reg = <0x200 0x200>;
+					atmel,usart-mode = <AT91_USART_MODE_SERIAL>;
  					interrupts = <33 IRQ_TYPE_LEVEL_HIGH 7>;
  					dmas = <&dma0
  						(AT91_XDMAC_DT_MEM_IF(0) |

@@ -586,6 +589,7 @@ flx6: flexcom@f8010000 {
  				uart6: serial@200 {
  					compatible = "microchip,sam9x60-usart", "atmel,at91sam9260-usart";
  					reg = <0x200 0x200>;
+					atmel,usart-mode = <AT91_USART_MODE_SERIAL>;
  					interrupts = <9 IRQ_TYPE_LEVEL_HIGH 7>;
  					dmas = <&dma0
  						(AT91_XDMAC_DT_MEM_IF(0) |

@@ -637,6 +641,7 @@ flx7: flexcom@f8014000 {
  				uart7: serial@200 {
  					compatible = "microchip,sam9x60-usart", "atmel,at91sam9260-usart";
  					reg = <0x200 0x200>;
+					atmel,usart-mode = <AT91_USART_MODE_SERIAL>;
  					interrupts = <10 IRQ_TYPE_LEVEL_HIGH 7>;
  					dmas = <&dma0
  						(AT91_XDMAC_DT_MEM_IF(0) |

@@ -688,6 +693,7 @@ flx8: flexcom@f8018000 {
  				uart8: serial@200 {
  					compatible = "microchip,sam9x60-usart", "atmel,at91sam9260-usart";
  					reg = <0x200 0x200>;
+					atmel,usart-mode = <AT91_USART_MODE_SERIAL>;
  					interrupts = <11 IRQ_TYPE_LEVEL_HIGH 7>;
  					dmas = <&dma0
  						(AT91_XDMAC_DT_MEM_IF(0) |

@@ -739,6 +745,7 @@ flx0: flexcom@f801c000 {
  				uart0: serial@200 {
  					compatible = "microchip,sam9x60-usart", "atmel,at91sam9260-usart";
  					reg = <0x200 0x200>;
+					atmel,usart-mode = <AT91_USART_MODE_SERIAL>;
  					interrupts = <5 IRQ_TYPE_LEVEL_HIGH 7>;
  					dmas = <&dma0
  						(AT91_XDMAC_DT_MEM_IF(0) |

@@ -809,6 +816,7 @@ flx1: flexcom@f8020000 {
  				uart1: serial@200 {
  					compatible = "microchip,sam9x60-usart", "atmel,at91sam9260-usart";
  					reg = <0x200 0x200>;
+					atmel,usart-mode = <AT91_USART_MODE_SERIAL>;
  					interrupts = <6 IRQ_TYPE_LEVEL_HIGH 7>;
  					dmas = <&dma0
  						(AT91_XDMAC_DT_MEM_IF(0) |

@@ -879,6 +887,7 @@ flx2: flexcom@f8024000 {
  				uart2: serial@200 {
  					compatible = "microchip,sam9x60-usart", "atmel,at91sam9260-usart";
  					reg = <0x200 0x200>;
+					atmel,usart-mode = <AT91_USART_MODE_SERIAL>;
  					interrupts = <7 IRQ_TYPE_LEVEL_HIGH 7>;
  					dmas = <&dma0
  						(AT91_XDMAC_DT_MEM_IF(0) |

@@ -949,6 +958,7 @@ flx3: flexcom@f8028000 {
  				uart3: serial@200 {
  					compatible = "microchip,sam9x60-usart", "atmel,at91sam9260-usart";
  					reg = <0x200 0x200>;
+					atmel,usart-mode = <AT91_USART_MODE_SERIAL>;
  					interrupts = <8 IRQ_TYPE_LEVEL_HIGH 7>;
  					dmas = <&dma0
  						(AT91_XDMAC_DT_MEM_IF(0) |

@@ -1074,6 +1084,7 @@ flx9: flexcom@f8040000 {
  				uart9: serial@200 {
  					compatible = "microchip,sam9x60-usart", "atmel,at91sam9260-usart";
  					reg = <0x200 0x200>;
+					atmel,usart-mode = <AT91_USART_MODE_SERIAL>;
  					interrupts = <15 IRQ_TYPE_LEVEL_HIGH 7>;
  					dmas = <&dma0
  						(AT91_XDMAC_DT_MEM_IF(0) |

@@ -1125,6 +1136,7 @@ flx10: flexcom@f8044000 {
  				uart10: serial@200 {
  					compatible = "microchip,sam9x60-usart", "atmel,at91sam9260-usart";
  					reg = <0x200 0x200>;
+					atmel,usart-mode = <AT91_USART_MODE_SERIAL>;
  					interrupts = <16 IRQ_TYPE_LEVEL_HIGH 7>;
  					dmas = <&dma0
  						(AT91_XDMAC_DT_MEM_IF(0) |

base-commit: fdadd93817f124fd0ea6ef251d4a1068b7feceba

claudiu beznea

maintainer

2024-09-12 07:23 UTC #2 lore raw

In reply to Andrei Simion

Hi, Andrei,

Quoted 8 lines · Andrei Simion

~: make dtbs_check DT_SCHEMA_FILES=atmel,at91-usart.ymal
-> for all boards which inherit sam9x60.dtsi: serial@200: $nodename:0:
'serial@200' does not match '^spi(@.*|-([0-9]|[1-9][0-9]+))?$ serial@200: atmel,use-dma-rx: False schema does not allow True serial@200: atmel,use-dma-tx: False schema does not allow True serial@200: atmel,fifo-size: False schema does not allow [[16]] -> Means : atmel,usart-mode = <AT91_USART_MODE_SERIAL> misses for uart:
0,1,2,3,4,6,7,8,9,10,11,12

Can you please explain in plain English what this means? From [1]

"Once the problem is established, describe what you are actually doing about it in technical detail. It’s important to describe the change in plain English for the reviewer to verify that the code is behaving as you intend it to."

Thank you,
Claudiu Beznea

[1]
https://www.kernel.org/doc/html/v4.17/process/submitting-patches.html#describe-changes

[email protected]

author

2024-09-12 07:36 UTC #3 lore raw

Quoted 14 lines · claudiu beznea

EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
Hi, Andrei,
Quoted 8 lines · Andrei Simion
~: make dtbs_check DT_SCHEMA_FILES=atmel,at91-usart.ymal
-> for all boards which inherit sam9x60.dtsi: serial@200: $nodename:0:
'serial@200' does not match '^spi(@.*|-([0-9]|[1-9][0-9]+))?$ serial@200: atmel,use-dma-rx: False schema does not allow True serial@200: atmel,use-dma-tx: False schema does not allow True serial@200: atmel,fifo-size: False schema does not allow [[16]] -> Means : atmel,usart-mode = <AT91_USART_MODE_SERIAL> misses for uart:
0,1,2,3,4,6,7,8,9,10,11,12

Quoted 2 lines

Can you please explain in plain English what this means? From [1]

Yes, I will do that in V2. Thanks!

Best Regards,
Andrei Simion