x86/cpu: Mark flag_is_changeable_p() with __maybe_unused
PATCH 1/1 x86/cpu: Mark flag_is_changeable_p() with __maybe_unused
When flag_is_changeable_p() is unused, it prevents kernel builds with clang, make W=1 and CONFIG_WERROR=y:
arch/x86/kernel/cpu/common.c:351:19: error: unused function 'flag_is_changeable_p' [-Werror,-Wunused-function]
351 | static inline int flag_is_changeable_p(u32 flag)
| ^~~~~~~~~~~~~~~~~~~~
Fix this by marking it with __maybe_unused.
See also commit 6863f5643dd7 ("kbuild: allow Clang to find unused static inline functions for W=1 build").
--- arch/x86/kernel/cpu/common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/x86/kernel/cpu/common.c +1 -1
@@ -287,7 +287,7 @@ static int __init cachesize_setup(char *str)__setup ("cachesize=" , cachesize_setup);/* Standard macro to see if a specific flag is changeable */ -static inline int flag_is_changeable_p (u32 flag) +static inline __maybe_unused int flag_is_changeable_p (u32 flag) {u32 f1, f2;
Signature · 1 line
2.43.0.rc1.1336.g36b5255a03ac
Quoted 11 lines · Andy Shevchenko
When
flag_is_changeable_p()is unused, it prevents kernel builds with clang,make W=1andCONFIG_WERROR=y:
arch/x86/kernel/cpu/common.c:351:19: error: unused function 'flag_is_changeable_p' [-Werror,-Wunused-function]
351 | static inline intflag_is_changeable_p(u32 flag)| ^~~~~~~~~~~~~~~~~~~~Fix this by marking it with
__maybe_unused.See also commit
6863f5643dd7("kbuild: allow Clang to find unused static inline functions for W=1 build").
...and it should be done for 64-bit case.
Signature · 2 lines
With Best Regards, Andy Shevchenko