Skip to contentSkip to conversation

Patch "mm: Fix filemap_invalidate_inode() to use invalidate_inode_pages2_range()" has been added to the 6.10-stable tree

PATCH [email protected] 1 participant 1 message Sep 5, 2024

Subsystems (4)
lore
Share & tools
lore

[email protected]

author Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

mm: Fix filemap_invalidate_inode() to use invalidate_inode_pages2_range()

to the 6.10-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
mm-fix-filemap_invalidate_inode-to-use-invalidate_inode_pages2_range.patch
and it can be found in the queue-6.10 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

From c26096ee0278c5e765009c5eee427bbafe6dc090 Mon Sep 17 00:00:00 2001
From: David Howells <[email protected]>
Date: Wed, 28 Aug 2024 22:02:45 +0100
Subject: mm: Fix filemap_invalidate_inode() to use invalidate_inode_pages2_range()

From: David Howells <[email protected]>

commit c26096ee0278c5e765009c5eee427bbafe6dc090 upstream.

Fix filemap_invalidate_inode() to use invalidate_inode_pages2_range() rather than truncate_inode_pages_range(). The latter clears the invalidated bit of a partial pages rather than discarding it entirely. This causes copy_file_range() to fail on cifs because the partial pages at either end of the destination range aren't evicted and reread, but rather just partly cleared.

This causes generic/075 and generic/112 xfstests to fail.

Fixes 74e797d79cf1 ("mm: Provide a means of invalidation without using launder_folio")
cc Matthew Wilcox <[email protected]>
cc Miklos Szeredi <[email protected]>
cc Trond Myklebust <[email protected]>
cc Christoph Hellwig <[email protected]>
cc Andrew Morton <[email protected]>
cc Alexander Viro <[email protected]>
cc Christian Brauner <[email protected]>
cc Jeff Layton <[email protected]>
---
 mm/filemap.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
mm/filemap.c +1 -1
@@ -4221,7 +4221,7 @@ int filemap_invalidate_inode(struct inod
 	}
 
 	/* Wait for writeback to complete on all folios and discard. */
-	truncate_inode_pages_range(mapping, start, end);
+	invalidate_inode_pages2_range(mapping, start / PAGE_SIZE, end / PAGE_SIZE);
 
 unlock:
 	filemap_invalidate_unlock(mapping);

Patches currently in stable-queue which might be from [email protected] are

queue-6.10/mm-fix-filemap_invalidate_inode-to-use-invalidate_inode_pages2_range.patch