vhost-user: add NEED_REPLY flag
PATCH 1/1 vhost-user: add NEED_REPLY flag
Front-end message requests which need reply should set NEED_REPLY_MASK in flag, and response from slave need clear NEED_REPLY_MASK flag.
--- hw/virtio/vhost-user.c | 2 +- subprojects/libvhost-user/libvhost-user.c | 1 + 2 files changed, 2 insertions(+), 1 deletion(-)
hw/virtio/vhost-user.c +1 -1
@@ -1082,7 +1082,7 @@ static int vhost_user_get_u64(struct vhost_dev *dev, int request, uint64_t *u64)int ret;VhostUserMsg msg = { .hdr.request = request, - .hdr.flags =VHOST_USER_VERSION , + .hdr.flags =VHOST_USER_VERSION |VHOST_USER_NEED_REPLY_MASK , };if (vhost_user_per_device_request (request) && dev->vq_index !=0 ) {
subprojects/libvhost-user/libvhost-user.c +1 -0
@@ -667,6 +667,7 @@ vu_send_reply(VuDev *dev, int conn_fd, VhostUserMsg *vmsg) {/* Set the version in the flags when sending the reply */ vmsg->flags &= ~VHOST_USER_VERSION_MASK ; + vmsg->flags &= ~VHOST_USER_NEED_REPLY_MASK ; vmsg->flags |=VHOST_USER_VERSION ; vmsg->flags |=VHOST_USER_REPLY_MASK ;
Signature · 1 line
2.34.1
Hi, can someone review this patch?
I find requests which call vhost_user_get_u64 does not set NEED_REPLY flag
Quoted 40 lines · luzhixing12345 <[email protected]> 于2024年8月4日周日 23:50写道:
Front-end message requests which need reply should set
NEED_REPLY_MASKin flag, and response from slave need clearNEED_REPLY_MASKflag.--- hw/virtio/vhost-user.c | 2 +- subprojects/libvhost-user/libvhost-user.c | 1 + 2 files changed, 2 insertions(+), 1 deletion(-)hw/virtio/vhost-user.c +1
-1@@ -1082,7 +1082,7 @@ static int vhost_user_get_u64(struct vhost_dev *dev, int request, uint64_t *u64) int ret;VhostUserMsg msg = { .hdr.request = request, - .hdr.flags =VHOST_USER_VERSION , + .hdr.flags =VHOST_USER_VERSION |VHOST_USER_NEED_REPLY_MASK , };if (vhost_user_per_device_request(request) && dev->vq_index != 0) {subprojects/libvhost-user/libvhost-user.c +1
-1@@ -667,6 +667,7 @@ vu_send_reply(VuDev *dev, int conn_fd, VhostUserMsg *vmsg) {/* Set the version in the flags when sending the reply */ vmsg->flags &= ~VHOST_USER_VERSION_MASK ; + vmsg->flags &= ~VHOST_USER_NEED_REPLY_MASK ; vmsg->flags |=VHOST_USER_VERSION ; vmsg->flags |=VHOST_USER_REPLY_MASK ; --2.34.1
Quoted 2 lines · 陆知行
Hi, can someone review this patch?
I find requests which callvhost_user_get_u64does not setNEED_REPLYflag
Can you provide an example to trigger this issue?
Also, with this change all calls to vhost_user_get_u64() will set that flag, is that following the vhost-user user specification?
Please use scripts/checkpatch.pl before sending patches, this one for example is missing SoB.
Thanks,
Stefano
Quoted 43 lines
Quoted 40 lines · luzhixing12345 <[email protected]> 于2024年8月4日周日 23:50写道:
Front-end message requests which need reply should set
NEED_REPLY_MASKin flag, and response from slave need clearNEED_REPLY_MASKflag.--- hw/virtio/vhost-user.c | 2 +- subprojects/libvhost-user/libvhost-user.c | 1 + 2 files changed, 2 insertions(+), 1 deletion(-)hw/virtio/vhost-user.c +1
-1@@ -1082,7 +1082,7 @@ static int vhost_user_get_u64(struct vhost_dev *dev, int request, uint64_t *u64) int ret;VhostUserMsg msg = { .hdr.request = request, - .hdr.flags =VHOST_USER_VERSION , + .hdr.flags =VHOST_USER_VERSION |VHOST_USER_NEED_REPLY_MASK , };if (vhost_user_per_device_request(request) && dev->vq_index != 0) {subprojects/libvhost-user/libvhost-user.c +1
-1@@ -667,6 +667,7 @@ vu_send_reply(VuDev *dev, int conn_fd, VhostUserMsg *vmsg) {/* Set the version in the flags when sending the reply */ vmsg->flags &= ~VHOST_USER_VERSION_MASK ; + vmsg->flags &= ~VHOST_USER_NEED_REPLY_MASK ; vmsg->flags |=VHOST_USER_VERSION ; vmsg->flags |=VHOST_USER_REPLY_MASK ; --2.34.1
Quoted 8 lines · 陆知行
Quoted 2 lines
Hi, can someone review this patch?
I find requests which callvhost_user_get_u64does not setNEED_REPLYflagCan you provide an example to trigger this issue?
Also, with this change all calls to
vhost_user_get_u64()will set that flag, is that following the vhost-user user specification?
It will not trigger a bug.
For each function that calls vhost_user_get_u64() like vhost_user_get_features/vhost_user_get_status, if you set a breakpoint in gdb at subprojects/libvhost-user/libvhost-user.c/vu_dispatch and you will find that
```
boolvu_dispatch(VuDev *dev)
{
// ...
need_reply = vmsg.flags & VHOST_USER_NEED_REPLY_MASK; // 0
reply_requested = vu_process_message(dev, &vmsg); // 1
// ...
}
vhost-user protocol doc list some requests that need reply like VHOST_USER_GET_FEATURES/VHOST_USER_GET_PROTOCOL_FEATURES, the flag should be set with NEED_REPLY_MASK.
The current code does not raise an error because in libvhost-user(vu_process_message) it will not check this flag and always choose whether or not reply based on the request type.
So this patch fills the flag and make sure need_reply to 1 for the requests that need reply.
Quoted 49 lines
Please use
scripts/checkpatch.plbefore sending patches, this one for example is missing SoB.Thanks,
StefanoQuoted 43 lines
Quoted 40 lines · luzhixing12345 <[email protected]> 于2024年8月4日周日 23:50写道:
Front-end message requests which need reply should set
NEED_REPLY_MASKin flag, and response from slave need clearNEED_REPLY_MASKflag.--- hw/virtio/vhost-user.c | 2 +- subprojects/libvhost-user/libvhost-user.c | 1 + 2 files changed, 2 insertions(+), 1 deletion(-)hw/virtio/vhost-user.c +1
-1@@ -1082,7 +1082,7 @@ static int vhost_user_get_u64(struct vhost_dev *dev, int request, uint64_t *u64) int ret;VhostUserMsg msg = { .hdr.request = request, - .hdr.flags =VHOST_USER_VERSION , + .hdr.flags =VHOST_USER_VERSION |VHOST_USER_NEED_REPLY_MASK , };if (vhost_user_per_device_request(request) && dev->vq_index != 0) {subprojects/libvhost-user/libvhost-user.c +1
-1@@ -667,6 +667,7 @@ vu_send_reply(VuDev *dev, int conn_fd, VhostUserMsg *vmsg) {/* Set the version in the flags when sending the reply */ vmsg->flags &= ~VHOST_USER_VERSION_MASK ; + vmsg->flags &= ~VHOST_USER_NEED_REPLY_MASK ; vmsg->flags |=VHOST_USER_VERSION ; vmsg->flags |=VHOST_USER_REPLY_MASK ; --2.34.1
Quoted 2 lines · On Sun, Aug 04, 2024 at 11:48:59PM +0800, luzhixing12345 wrote:
Front-end message requests which need reply should set
NEED_REPLY_MASKin flag, and response from slave need clearNEED_REPLY_MASKflag.
neither this.
Quoted 32 lines
--- hw/virtio/vhost-user.c | 2 +- subprojects/libvhost-user/libvhost-user.c | 1 + 2 files changed, 2 insertions(+), 1 deletion(-)hw/virtio/vhost-user.c +1
-1@@ -1082,7 +1082,7 @@ static int vhost_user_get_u64(struct vhost_dev *dev, int request, uint64_t *u64)int ret;VhostUserMsg msg = { .hdr.request = request, - .hdr.flags =VHOST_USER_VERSION , + .hdr.flags =VHOST_USER_VERSION |VHOST_USER_NEED_REPLY_MASK , };if (vhost_user_per_device_request (request) && dev->vq_index !=0 ) {subprojects/libvhost-user/libvhost-user.c +1
-0@@ -667,6 +667,7 @@ vu_send_reply(VuDev *dev, int conn_fd, VhostUserMsg *vmsg) {/* Set the version in the flags when sending the reply */ vmsg->flags &= ~VHOST_USER_VERSION_MASK ; + vmsg->flags &= ~VHOST_USER_NEED_REPLY_MASK ; vmsg->flags |=VHOST_USER_VERSION ; vmsg->flags |=VHOST_USER_REPLY_MASK ;Signature · 1 line
2.34.1