ASoC: mediatek: mt8365: include linux/bitfield.h
Subsystems (3)
PATCH 1/1 ASoC: mediatek: mt8365: include linux/bitfield.h
From: Arnd Bergmann <[email protected]>
On x86, the header is not already included implicitly, breaking compile-testing:
In file included from sound/soc/mediatek/mt8365/mt8365-afe-common.h:19,
from sound/soc/mediatek/mt8365/mt8365-afe-pcm.c:18:
sound/soc/mediatek/mt8365/mt8365-afe-pcm.c: In function 'mt8365_afe_cm2_mux_conn':
sound/soc/mediatek/mt8365/mt8365-reg.h:952:41: error: implicit declaration of function 'FIELD_PREP' [-Wimplicit-function-declaration]
952 | #define CM2_AFE_CM2_CONN_CFG1(x) FIELD_PREP(CM2_AFE_CM2_CONN_CFG1_MASK, (x))
| ^~~~~~~~~~Included it ahead of the field definitions.
---
This started happening after I applied "ASoC: mt8365: Allow build coverage".
--- sound/soc/mediatek/mt8365/mt8365-reg.h | 2 ++ 1 file changed, 2 insertions(+)
sound/soc/mediatek/mt8365/mt8365-reg.h +2 -0
@@ -10,6 +10,8 @@#ifndef _MT8365_REG_H_#define _MT8365_REG_H_ +#include <linux/bitfield.h> +#define AUDIO_TOP_CON0 (0x0000)#define AUDIO_TOP_CON1 (0x0004)#define AUDIO_TOP_CON2 (0x0008)
Signature · 1 line
2.39.2
Quoted 12 lines · Arnd Bergmann
From: Arnd Bergmann <[email protected]>
On x86, the header is not already included implicitly, breaking compile-testing:
In file included from
sound/soc/mediatek/mt8365/mt8365-afe-common.h:19,from sound/soc/mediatek/mt8365/mt8365-afe-pcm.c:18: sound/soc/mediatek/mt8365/mt8365-afe-pcm.c: In function 'mt8365_afe_cm2_mux_conn': sound/soc/mediatek/mt8365/mt8365-reg.h:952:41: error: implicit declaration of function 'FIELD_PREP' [-Wimplicit-function-declaration] 952 | #define CM2_AFE_CM2_CONN_CFG1(x) FIELD_PREP(CM2_AFE_CM2_CONN_CFG1_MASK, (x)) | ^~~~~~~~~~
Quoted 4 lines
Included it ahead of the field definitions.
Fixes 38c7c9ddc740 ("ASoC: mediatek: mt8365: Add common header")Signed-off-by Arnd Bergmann <[email protected]>
Quoted 20 lines
---
This started happening after I applied "ASoC: mt8365: Allow build coverage".
--- sound/soc/mediatek/mt8365/mt8365-reg.h | 2 ++ 1 file changed, 2 insertions(+)sound/soc/mediatek/mt8365/mt8365-reg.h +2
-0@@ -10,6 +10,8 @@#ifndef _MT8365_REG_H_#define _MT8365_REG_H_ +#include <linux/bitfield.h> +#define AUDIO_TOP_CON0 (0x0000)#define AUDIO_TOP_CON1 (0x0004)#define AUDIO_TOP_CON2 (0x0008)
Mark Brown
maintainerQuoted 11 lines · Arnd Bergmann
On x86, the header is not already included implicitly, breaking compile-testing:
In file included from
sound/soc/mediatek/mt8365/mt8365-afe-common.h:19,from sound/soc/mediatek/mt8365/mt8365-afe-pcm.c:18: sound/soc/mediatek/mt8365/mt8365-afe-pcm.c: In function 'mt8365_afe_cm2_mux_conn': sound/soc/mediatek/mt8365/mt8365-reg.h:952:41: error: implicit declaration of function 'FIELD_PREP' [-Wimplicit-function-declaration] 952 | #define CM2_AFE_CM2_CONN_CFG1(x) FIELD_PREP(CM2_AFE_CM2_CONN_CFG1_MASK, (x)) | ^~~~~~~~~~[...]
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
Thanks!
[1/1] ASoC: mediatek: mt8365: include linux/bitfield.h
commit: 6b31d6a4ca3b4d8abfb39127130889f9a9a38aa1
All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying to this mail.
Thanks,
Mark