Skip to contentSkip to conversation

dt-bindings: memory-controllers: fsl,ifc: split child node differences

PATCH Applied Frank Li 3 participants 3 messages Sep 9, 2024 – Sep 30, 2024

Subsystems (3)
lore
Share & tools
lore

Frank Li

author maintainer
#0 lore raw

PATCH v4 1/1 dt-bindings: memory-controllers: fsl,ifc: split child node differences

ifc can connect nor, nand and fpag. Split "^.*@..." into "nand@..." and "(flash|fpga|board-control|cpld)@..." to better describe the child's node binding requirements.

Fix below warning:
arch/arm64/boot/dts/freescale/fsl-ls1043a-qds.dtb: /soc/memory-controller@1530000/nand@1,0:
failed to match any schema with compatible: ['fsl,ifc-nand']

---
Change from v3 to v4
- add pattern property for fpga.
- fine tune commit message.
Change from v2 to v3
- add partition child node for nand
- Only partition property is used at ppc
Change from v1 to v2
- add address-cells and size-cells

---
 .../memory-controllers/fsl/fsl,ifc.yaml       | 32 ++++++++++++++++---
 1 file changed, 27 insertions(+), 5 deletions(-)
Documentation/devicetree/bindings/memory-controllers/fsl/fsl,ifc.yaml +27 -5
index d1c3421bee107..f7cf0f91c1c02 100644
@@ -58,17 +58,39 @@ properties:
       access window as configured.
 
 patternProperties:
-  "^.*@[a-f0-9]+(,[a-f0-9]+)+$":
+  "^nand@[a-f0-9]+(,[a-f0-9]+)+$":
     type: object
-    description: |
-      Child device nodes describe the devices connected to IFC such as NOR (e.g.
-      cfi-flash) and NAND (fsl,ifc-nand). There might be board specific devices
-      like FPGAs, CPLDs, etc.
+    properties:
+      compatible:
+        const: fsl,ifc-nand
+
+      reg:
+        maxItems: 1
+
+      "#address-cells":
+        const: 1
+
+      "#size-cells":
+        const: 1
+
+    patternProperties:
+      "^partition@[0-9a-f]+":
+        $ref: /schemas/mtd/partitions/partition.yaml#
+        deprecated: true
 
     required:
       - compatible
       - reg
 
+    additionalProperties: false
+
+  "(flash|fpga|board-control|cpld)@[a-f0-9]+(,[a-f0-9]+)+$":
+    type: object
+    oneOf:
+      - $ref: /schemas/board/fsl,fpga-qixis.yaml#
+      - $ref: /schemas/mtd/mtd-physmap.yaml#
+    unevaluatedProperties: false
+
 required:
   - compatible
   - reg
Signature · 1 line
2.34.1
maintainer Reviewed-by on v4 1/1
#1 lore raw
Quoted 18 lines · Frank Li

ifc can connect nor, nand and fpag. Split "^.*@..." into "nand@..." and "(flash|fpga|board-control|cpld)@..." to better describe the child's node binding requirements.

Fix below warning:
arch/arm64/boot/dts/freescale/fsl-ls1043a-qds.dtb: /soc/memory-controller@1530000/nand@1,0:
failed to match any schema with compatible: ['fsl,ifc-nand']

---
Change from v3 to v4
- add pattern property for fpga.
- fine tune commit message.
Change from v2 to v3
- add partition child node for nand
- Only partition property is used at ppc
Change from v1 to v2
- add address-cells and size-cells

Quoted 4 lines
---
 .../memory-controllers/fsl/fsl,ifc.yaml       | 32 ++++++++++++++++---
 1 file changed, 27 insertions(+), 5 deletions(-)
#2 lore raw
In reply to Frank Li
Quoted 9 lines · Frank Li

ifc can connect nor, nand and fpag. Split "^.*@..." into "nand@..." and "(flash|fpga|board-control|cpld)@..." to better describe the child's node binding requirements.

Fix below warning:
arch/arm64/boot/dts/freescale/fsl-ls1043a-qds.dtb: /soc/memory-controller@1530000/nand@1,0:
failed to match any schema with compatible: ['fsl,ifc-nand']

[...]

Applied, thanks!

[1/1] dt-bindings: memory-controllers: fsl,ifc: split child node differences

      https://git.kernel.org/krzk/linux-mem-ctrl/c/89e6684538f59093d89eda50e30a6f2644b06ab6

Best regards,

Signature · 1 line
Krzysztof Kozlowski <[email protected]>