Skip to contentSkip to conversation

posix/conformance/interfaces/sem_timedwait/2-1: add _GNU_SOURCE define

PATCH In review Ma Xinjian via ltp 2 participants 5 messages Sep 10, 2024 – Sep 19, 2024

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 posix/conformance/interfaces/sem_timedwait/2-1: add _GNU_SOURCE define

To get rid of error "‘MAP_ANONYMOUS’ undeclared (first use in this function)" on some systems (Fedora 37, etc).

---
 .../conformance/interfaces/sem_timedwait/2-1.c                   | 1 +
 1 file changed, 1 insertion(+)
testcases/open_posix_testsuite/conformance/interfaces/sem_timedwait/2-1.c +1 -0
index 2eca8dff6..4ccef7261 100644
@@ -11,6 +11,7 @@
  */
 
 
+#define _GNU_SOURCE
 #include <stdio.h>
 #include <errno.h>
 #include <unistd.h>
Signature · 5 lines
2.42.0


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp
#1 lore raw

Hi!

Quoted 2 lines

To get rid of error "‘MAP_ANONYMOUS’ undeclared (first use in this function)" on some systems (Fedora 37, etc).

That does not sound right, the open posix testsuite must not depend on anything GNU specific.

Also MAP_ANONYMOUS is requiered to be there by POSIX so setting _GNU_SOURCE does not seem to be a good solution.

Quoted 23 lines
---
 .../conformance/interfaces/sem_timedwait/2-1.c                   | 1 +
 1 file changed, 1 insertion(+)
testcases/open_posix_testsuite/conformance/interfaces/sem_timedwait/2-1.c +1 -0
index 2eca8dff6..4ccef7261 100644
@@ -11,6 +11,7 @@
  */
 
 
+#define _GNU_SOURCE
 #include <stdio.h>
 #include <errno.h>
 #include <unistd.h>
Signature · 5 lines
2.42.0


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp
Signature · 5 lines
Cyril Hrubis
[email protected]

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp
#2 lore raw

Hi Cyril

Quoted 7 lines

Hi!

Quoted 1 line

To get rid of error "‘MAP_ANONYMOUS’ undeclared (first use in this

function)"

Quoted 1 line

on some systems (Fedora 37, etc).

That does not sound right, the open posix testsuite must not depend on anything GNU specific.

I see. Thanks.
But I tested both on Fedora and Ubuntu, they reported the same error if using the params " -std=c99 -D_POSIX_C_SOURCE=200809L -D_XOPEN_SOURCE=700" for gcc. How about manually defining MAP_ANONYMOUS like below?

testcases/open_posix_testsuite/conformance/interfaces/sem_timedwait/2-1.c +4 -0
index 2eca8dff6..83d1894ec 100644
@@ -27,6 +27,10 @@
 #define FUNCTION "sem_timedwait"
 #define ERROR_PREFIX "unexpected error: " FUNCTION " " TEST ": "
 
+#ifndef MAP_ANONYMOUS
+#define MAP_ANONYMOUS 0x20
+#endif
+
 int main(void)
 {
        sem_t *mysemp;
Quoted 2 lines

Also MAP_ANONYMOUS is requiered to be there by POSIX so setting _GNU_SOURCE does not seem to be a good solution.

I checked the https://sourceware.org/glibc/manual/2.40/html_mono/libc.html#index-MAP_005fANONYMOUS
MAP_ANONYMOUS is showed in GNU document, does this mean it follows the GNU rules?

Best regards
Ma

Quoted 36 lines
Quoted 4 lines
---
 .../conformance/interfaces/sem_timedwait/2-1.c                   | 1

+

Quoted 25 lines
 1 file changed, 1 insertion(+)

diff --git a/testcases/open_posix_testsuite/conformance/interfaces/sem_timedwait/ 2-1.c b/testcases/open_posix_testsuite/conformance/interfaces/sem_timedwait/ 2-1.c
index 2eca8dff6..4ccef7261 100644
---
a/testcases/open_posix_testsuite/conformance/interfaces/sem_timedwait/ 2-1.c
+++ b/testcases/open_posix_testsuite/conformance/interfaces/sem_timedw +++ ait/2-1.c

(quoted diff) +1 -1
@@ -11,6 +11,7 @@
  */
 
 
+#define _GNU_SOURCE
 #include <stdio.h>
 #include <errno.h>
 #include <unistd.h>
--

2.42.0

Quoted 2 lines

--
Mailing list info: https://lists.linux.it/listinfo/ltp

--
Cyril Hrubis
[email protected]

Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp
#3 lore raw

Hi!

Quoted 7 lines
Quoted 2 lines

That does not sound right, the open posix testsuite must not depend on anything GNU specific.

I see. Thanks.
But I tested both on Fedora and Ubuntu, they reported the same error if using the params " -std=c99 -D_POSIX_C_SOURCE=200809L -D_XOPEN_SOURCE=700" for gcc.

That is certainly unexpected. I managed to reproduce this on Debian 12.

Looks that on certain systems the MMAP_ANONYMOUS seems to be guarded by __USE_MISC. The __USE_MISC is defined in /usr/include/features.h and set if _DEFAULT_SOURCE is set which is set by _GNU_SOURCE.

I did double check the POSIX and I was probably confusing MAP_PRIVATE and MAP_ANONYMOUS, sorry. Looks like MAP_ANONYMOUS is indeed not a part of POSIX.

Quoted 1 line

How about manually defining MAP_ANONYMOUS like below?

Does not seem to be a good solution either, that will work only on Linux. The open posix testsuite is supposed to run on any POSIX compatible OS.

I'm afraid that the only solution we can use is to allocate the shared memory via the posix shm. That means to get the file descriptor for mmap() from shm_open() (followed by shm_unlink()).

Signature · 5 lines
Cyril Hrubis
[email protected]

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp
#4 lore raw

Hi Cyril

Quoted 27 lines

-----Original Message-----
From: Cyril Hrubis <[email protected]>
Sent: 2024年9月17日 22:17
To: Ma, Xinjian/马 新建 <[email protected]>
Cc: [email protected]
Subject: Re: [LTP] [PATCH] posix/conformance/interfaces/sem_timedwait/2-1:
add _GNU_SOURCE define

Hi!

Quoted 7 lines
Quoted 2 lines

That does not sound right, the open posix testsuite must not depend on anything GNU specific.

I see. Thanks.
But I tested both on Fedora and Ubuntu, they reported the same error if using the params " -std=c99 -D_POSIX_C_SOURCE=200809L -D_XOPEN_SOURCE=700" for gcc.

That is certainly unexpected. I managed to reproduce this on Debian 12.

Looks that on certain systems the MMAP_ANONYMOUS seems to be guarded by __USE_MISC. The __USE_MISC is defined in /usr/include/features.h and set if _DEFAULT_SOURCE is set which is set by _GNU_SOURCE.

I did double check the POSIX and I was probably confusing MAP_PRIVATE and MAP_ANONYMOUS, sorry. Looks like MAP_ANONYMOUS is indeed not a part of POSIX.

Quoted 8 lines
Quoted 1 line

How about manually defining MAP_ANONYMOUS like below?

Does not seem to be a good solution either, that will work only on Linux. The open posix testsuite is supposed to run on any POSIX compatible OS.

I'm afraid that the only solution we can use is to allocate the shared memory via the posix shm. That means to get the file descriptor for
mmap() from shm_open() (followed by shm_unlink()).

Thank you for the suggestion. I sent a new patch, PTAL.
https://lore.kernel.org/ltp/[email protected]/T/#u

Best regards,
Ma

Quoted 4 lines

--
Cyril Hrubis
[email protected]

Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp