Patch "riscv: dts: starfive: jh7110-common: Fix lower rate of CPUfreq by setting PLL0 rate to 1.5GHz" has been added to the 6.10-stable tree

DISCUSSION Xingyu Wu 3 participants 12 messages Sep 14, 2024 – Sep 18, 2024 1 message not in the archive Stable branch

lore

Share & tools

lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

Xingyu Wu

author

2024-09-14 08:35 UTC #1 lore raw

Quoted 10 lines · Sasha Levin

This is a note to let you know that I've just added the patch titled
riscv: dts: starfive: jh7110-common: Fix lower rate of CPUfreq by setting PLL0
rate to 1.5GHz
to the 6.10-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-
queue.git;a=summary

Quoted 7 lines

The filename of the patch is:
riscv-dts-starfive-jh7110-common-fix-lower-rate-of-c.patch
and it can be found in the queue-6.10 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Hi Sasha,

This patch only has the part of DTS without the clock driver patch[1]. [1]: https://lore.kernel.org/all/[email protected]/

I don't know your plan about this driver patch, or maybe I missed it.
But the DTS changes really needs the driver patch to work and you should add the driver patch.

Thanks,
Xingyu Wu

Quoted 41 lines

commit 67b60bf9777bd340c7179adb5376dcdd3f0c260c
Author: Xingyu Wu <[email protected]>
Date:   Mon Aug 26 16:04:30 2024 +0800
riscv: dts: starfive: jh7110-common: Fix lower rate of CPUfreq by setting PLL0
rate to 1.5GHz
[ Upstream commit 61f2e8a3a94175dbbaad6a54f381b2a505324610 ]
CPUfreq supports 4 cpu frequency loads on 375/500/750/1500MHz. But now PLL0 rate is 1GHz and the cpu frequency loads become 250/333/500/1000MHz in fact.
The PLL0 rate should be default set to 1.5GHz and set the cpu_core rate to 500MHz in safe.
Fixes e2c510d6d630 ("riscv: dts: starfive: Add cpu scaling for JH7110 SoC")
Signed-off-by Xingyu Wu <[email protected]>
Reviewed-by Hal Feng <[email protected]>
Signed-off-by Conor Dooley <[email protected]>
Signed-off-by Sasha Levin <[email protected]>
arch/riscv/boot/dts/starfive/jh7110-common.dtsi +5 -0
index 68d16717db8c..51d85f447626 100644
@@ -354,6 +354,12 @@ spi_dev0: spi@0 {
 	};
 };
 
+&syscrg {
+	assigned-clocks = <&syscrg JH7110_SYSCLK_CPU_CORE>,
+			  <&pllclk JH7110_PLLCLK_PLL0_OUT>;
+	assigned-clock-rates = <500000000>, <1500000000>; };
+
 &sysgpio {
 	i2c0_pins: i2c0-0 {
 		i2c-pins {

Xingyu Wu

author

2024-09-14 09:57 UTC #3 lore raw

Quoted 30 lines · Greg KH

Quoted 21 lines · Xingyu Wu
Quoted 10 lines · Sasha Levin
This is a note to let you know that I've just added the patch titled
riscv: dts: starfive: jh7110-common: Fix lower rate of CPUfreq
by setting PLL0 rate to 1.5GHz
to the 6.10-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-
queue.git;a=summary
Quoted 7 lines
The filename of the patch is:
riscv-dts-starfive-jh7110-common-fix-lower-rate-of-c.patch
and it can be found in the queue-6.10 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Hi Sasha,
Quoted 7 lines
This patch only has the part of DTS without the clock driver patch[1]. [1]:
https://lore.kernel.org/all/20240826080430.179788-2-xingyu.wu@starfive
tech.com/
I don't know your plan about this driver patch, or maybe I missed it. But the DTS changes really needs the driver patch to work and you should add

Quoted 9 lines

the driver patch.
Then why does the commit say:
Quoted 2 lines
Quoted 2 lines
Fixes e2c510d6d630 ("riscv: dts: starfive: Add cpu scaling for
JH7110 SoC")
Is that line incorrect?

No, this patch can also fix the problem.
In that patchset, the patch 2 depended on patch 1, so I added the Fixes tag in both patches.

Thanks,
Xingyu Wu

Greg KH

2024-09-14 09:37 UTC #4 lore raw

Quoted 35 lines · Xingyu Wu

Quoted 34 lines · Greg KH
Quoted 21 lines · Xingyu Wu
Quoted 10 lines · Sasha Levin
This is a note to let you know that I've just added the patch titled
riscv: dts: starfive: jh7110-common: Fix lower rate of CPUfreq
by setting PLL0 rate to 1.5GHz
to the 6.10-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-
queue.git;a=summary
Quoted 7 lines
The filename of the patch is:
riscv-dts-starfive-jh7110-common-fix-lower-rate-of-c.patch
and it can be found in the queue-6.10 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Hi Sasha,
Quoted 7 lines
This patch only has the part of DTS without the clock driver patch[1]. [1]:
https://lore.kernel.org/all/20240826080430.179788-2-xingyu.wu@starfive
tech.com/
I don't know your plan about this driver patch, or maybe I missed it. But the DTS changes really needs the driver patch to work and you should add
the driver patch.
Then why does the commit say:

Quoted 8 lines

Quoted 5 lines
Quoted 2 lines
Quoted 2 lines
Fixes e2c510d6d630 ("riscv: dts: starfive: Add cpu scaling for
JH7110 SoC")
Is that line incorrect?
No, this patch can also fix the problem.
In that patchset, the patch 2 depended on patch 1, so I added the Fixes tag in both patches.

What is the commit id of the other change you are referring to here?

thanks,

greg k-h

Xingyu Wu

author

2024-09-14 10:20 UTC #5 lore raw

Quoted 44 lines · Greg KH

Quoted 42 lines · Xingyu Wu
Quoted 41 lines · Greg KH
Quoted 28 lines · Xingyu Wu
Quoted 11 lines · Sasha Levin
This is a note to let you know that I've just added the patch titled
riscv: dts: starfive: jh7110-common: Fix lower rate of
CPUfreq by setting PLL0 rate to 1.5GHz
to the 6.10-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-
queue.git;a=summary
Quoted 7 lines
The filename of the patch is:
riscv-dts-starfive-jh7110-common-fix-lower-rate-of-c.patch
and it can be found in the queue-6.10 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Hi Sasha,
This patch only has the part of DTS without the clock driver patch[1]. [1]:
https://lore.kernel.org/all/20240826080430.179788-2-xingyu.wu@star
five
tech.com/
Quoted 3 lines
I don't know your plan about this driver patch, or maybe I missed it. But the DTS changes really needs the driver patch to work and you should add
the driver patch.
Then why does the commit say:
Quoted 3 lines
Quoted 3 lines
Fixes e2c510d6d630 ("riscv: dts: starfive: Add cpu scaling
for
JH7110 SoC")

Quoted 9 lines

Quoted 5 lines
Quoted 2 lines
Is that line incorrect?
No, this patch can also fix the problem.
In that patchset, the patch 2 depended on patch 1, so I added the Fixes tag in
both patches.
What is the commit id of the other change you are referring to here?

This commit id is the bug I'm trying to fix. The Fixes tag need to add it.

Thanks,
Xingyu Wu

Ron Economos

2024-09-14 10:32 UTC #6 lore raw

Quoted 44 lines · Xingyu Wu

Quoted 43 lines · Greg KH
Quoted 42 lines · Xingyu Wu
Quoted 30 lines · Greg KH
Quoted 26 lines · Xingyu Wu
Quoted 10 lines · Sasha Levin
This is a note to let you know that I've just added the patch titled
riscv: dts: starfive: jh7110-common: Fix lower rate of
CPUfreq by setting PLL0 rate to 1.5GHz
to the 6.10-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-
queue.git;a=summary
Quoted 7 lines
The filename of the patch is:
riscv-dts-starfive-jh7110-common-fix-lower-rate-of-c.patch
and it can be found in the queue-6.10 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Hi Sasha,
This patch only has the part of DTS without the clock driver patch[1]. [1]:
https://lore.kernel.org/all/20240826080430.179788-2-xingyu.wu@star
five
tech.com/
Quoted 3 lines
I don't know your plan about this driver patch, or maybe I missed it. But the DTS changes really needs the driver patch to work and you should add
Quoted 9 lines
the driver patch.
Then why does the commit say:
Quoted 3 lines
Quoted 3 lines
Fixes e2c510d6d630 ("riscv: dts: starfive: Add cpu scaling
for
JH7110 SoC")
Is that line incorrect?
No, this patch can also fix the problem.
In that patchset, the patch 2 depended on patch 1, so I added the Fixes tag in

Quoted 9 lines

Quoted 4 lines
both patches.
What is the commit id of the other change you are referring to here?
This commit id is the bug I'm trying to fix. The Fixes tag need to add it.
Thanks,
Xingyu Wu

I think Greg is looking for this:

commit 538d5477b25289ac5d46ca37b9e5b4d685cbe019

clk: starfive: jh7110-sys: Add notifier for PLL0 clock

Greg KH

2024-09-15 13:22 UTC #7 lore raw

Quoted 51 lines · Ron Economos

Quoted 50 lines · Xingyu Wu
Quoted 39 lines · Greg KH
Quoted 38 lines · Xingyu Wu
Quoted 37 lines · Greg KH
Quoted 26 lines · Xingyu Wu
Quoted 10 lines · Sasha Levin
This is a note to let you know that I've just added the patch titled
riscv: dts: starfive: jh7110-common: Fix lower rate of
CPUfreq by setting PLL0 rate to 1.5GHz
to the 6.10-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-
queue.git;a=summary
Quoted 7 lines
The filename of the patch is:
riscv-dts-starfive-jh7110-common-fix-lower-rate-of-c.patch
and it can be found in the queue-6.10 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Hi Sasha,
This patch only has the part of DTS without the clock driver patch[1]. [1]:
https://lore.kernel.org/all/20240826080430.179788-2-xingyu.wu@star
five
tech.com/
Quoted 3 lines
I don't know your plan about this driver patch, or maybe I missed it. But the DTS changes really needs the driver patch to work and you should add
the driver patch.
Then why does the commit say:
Quoted 3 lines
Quoted 3 lines
Fixes e2c510d6d630 ("riscv: dts: starfive: Add cpu scaling
for
JH7110 SoC")
Quoted 8 lines
Quoted 4 lines
Quoted 2 lines
Is that line incorrect?
No, this patch can also fix the problem.
In that patchset, the patch 2 depended on patch 1, so I added the Fixes tag in
both patches.
What is the commit id of the other change you are referring to here?
This commit id is the bug I'm trying to fix. The Fixes tag need to add it.

Quoted 8 lines

Quoted 3 lines
Thanks,
Xingyu Wu
I think Greg is looking for this:
commit 538d5477b25289ac5d46ca37b9e5b4d685cbe019
clk: starfive: jh7110-sys: Add notifier for PLL0 clock

That commit is already in the following releases:

	6.6.51 6.10.10

so what are we supposed to be doing here?

confused,

greg k-h

Ron Economos

2024-09-15 15:01 UTC #8 lore raw

Quoted 59 lines · Greg KH

Quoted 58 lines · Ron Economos
Quoted 44 lines · Xingyu Wu
Quoted 43 lines · Greg KH
Quoted 42 lines · Xingyu Wu
Quoted 30 lines · Greg KH
Quoted 26 lines · Xingyu Wu
Quoted 10 lines · Sasha Levin
This is a note to let you know that I've just added the patch titled
riscv: dts: starfive: jh7110-common: Fix lower rate of
CPUfreq by setting PLL0 rate to 1.5GHz
to the 6.10-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-
queue.git;a=summary
Quoted 7 lines
The filename of the patch is:
riscv-dts-starfive-jh7110-common-fix-lower-rate-of-c.patch
and it can be found in the queue-6.10 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Hi Sasha,
This patch only has the part of DTS without the clock driver patch[1]. [1]:
https://lore.kernel.org/all/20240826080430.179788-2-xingyu.wu@star
five
tech.com/
Quoted 3 lines
I don't know your plan about this driver patch, or maybe I missed it. But the DTS changes really needs the driver patch to work and you should add
Quoted 9 lines
the driver patch.
Then why does the commit say:
Quoted 3 lines
Quoted 3 lines
Fixes e2c510d6d630 ("riscv: dts: starfive: Add cpu scaling
for
JH7110 SoC")
Is that line incorrect?
No, this patch can also fix the problem.
In that patchset, the patch 2 depended on patch 1, so I added the Fixes tag in
Quoted 9 lines
Quoted 4 lines
both patches.
What is the commit id of the other change you are referring to here?
This commit id is the bug I'm trying to fix. The Fixes tag need to add it.
Thanks,
Xingyu Wu
I think Greg is looking for this:
commit 538d5477b25289ac5d46ca37b9e5b4d685cbe019

Quoted 9 lines

Quoted 1 line
clk: starfive: jh7110-sys: Add notifier for PLL0 clock
That commit is already in the following releases:
	6.6.51 6.10.10
so what are we supposed to be doing here?
confused,
greg k-h

Sorry, I didn't check to see if it was already in releases. So the 6.10 queue is fine as is.

However, these two patches go together, so the 6.6 queue should also have 61f2e8a3a94175dbbaad6a54f381b2a505324610 "riscv: dts: starfive: jh7110-common: Fix lower rate of CPUfreq by setting PLL0 rate to 1.5GHz" added to it.

Does that make sense?

Greg KH

2024-09-15 15:10 UTC #9 lore raw

Quoted 69 lines · Ron Economos

Quoted 59 lines · Greg KH
Quoted 58 lines · Ron Economos
Quoted 44 lines · Xingyu Wu
Quoted 43 lines · Greg KH
Quoted 42 lines · Xingyu Wu
Quoted 30 lines · Greg KH
Quoted 26 lines · Xingyu Wu
Quoted 10 lines · Sasha Levin
This is a note to let you know that I've just added the patch titled
riscv: dts: starfive: jh7110-common: Fix lower rate of
CPUfreq by setting PLL0 rate to 1.5GHz
to the 6.10-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-
queue.git;a=summary
Quoted 7 lines
The filename of the patch is:
riscv-dts-starfive-jh7110-common-fix-lower-rate-of-c.patch
and it can be found in the queue-6.10 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Hi Sasha,
This patch only has the part of DTS without the clock driver patch[1]. [1]:
https://lore.kernel.org/all/20240826080430.179788-2-xingyu.wu@star
five
tech.com/
Quoted 3 lines
I don't know your plan about this driver patch, or maybe I missed it. But the DTS changes really needs the driver patch to work and you should add
Quoted 9 lines
the driver patch.
Then why does the commit say:
Quoted 3 lines
Quoted 3 lines
Fixes e2c510d6d630 ("riscv: dts: starfive: Add cpu scaling
for
JH7110 SoC")
Is that line incorrect?
No, this patch can also fix the problem.
In that patchset, the patch 2 depended on patch 1, so I added the Fixes tag in
Quoted 9 lines
Quoted 4 lines
both patches.
What is the commit id of the other change you are referring to here?
This commit id is the bug I'm trying to fix. The Fixes tag need to add it.
Thanks,
Xingyu Wu
I think Greg is looking for this:
commit 538d5477b25289ac5d46ca37b9e5b4d685cbe019
Quoted 9 lines
Quoted 1 line
clk: starfive: jh7110-sys: Add notifier for PLL0 clock
That commit is already in the following releases:
	6.6.51 6.10.10
so what are we supposed to be doing here?
confused,
greg k-h

Quoted 7 lines

Sorry, I didn't check to see if it was already in releases. So the 6.10 queue is fine as is.
However, these two patches go together, so the 6.6 queue should also have 61f2e8a3a94175dbbaad6a54f381b2a505324610 "riscv: dts: starfive:
jh7110-common: Fix lower rate of CPUfreq by setting PLL0 rate to 1.5GHz" added to it.

Given that the file arch/riscv/boot/dts/starfive/jh7110-common.dtsi is not in the 6.6.y kernel tree, are you sure about this? If so, where should it be applied to instead?

thanks,

greg k-h

Ron Economos

2024-09-15 15:18 UTC #10 lore raw

Quoted 77 lines · Greg KH

Quoted 69 lines · Ron Economos
Quoted 59 lines · Greg KH
Quoted 58 lines · Ron Economos
Quoted 44 lines · Xingyu Wu
Quoted 43 lines · Greg KH
Quoted 42 lines · Xingyu Wu
Quoted 30 lines · Greg KH
Quoted 26 lines · Xingyu Wu
Quoted 10 lines · Sasha Levin
This is a note to let you know that I've just added the patch titled
riscv: dts: starfive: jh7110-common: Fix lower rate of
CPUfreq by setting PLL0 rate to 1.5GHz
to the 6.10-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-
queue.git;a=summary
Quoted 7 lines
The filename of the patch is:
riscv-dts-starfive-jh7110-common-fix-lower-rate-of-c.patch
and it can be found in the queue-6.10 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Hi Sasha,
This patch only has the part of DTS without the clock driver patch[1]. [1]:
https://lore.kernel.org/all/20240826080430.179788-2-xingyu.wu@star
five
tech.com/
Quoted 3 lines
I don't know your plan about this driver patch, or maybe I missed it. But the DTS changes really needs the driver patch to work and you should add
Quoted 9 lines
the driver patch.
Then why does the commit say:
Quoted 3 lines
Quoted 3 lines
Fixes e2c510d6d630 ("riscv: dts: starfive: Add cpu scaling
for
JH7110 SoC")
Is that line incorrect?
No, this patch can also fix the problem.
In that patchset, the patch 2 depended on patch 1, so I added the Fixes tag in
Quoted 9 lines
Quoted 4 lines
both patches.
What is the commit id of the other change you are referring to here?
This commit id is the bug I'm trying to fix. The Fixes tag need to add it.
Thanks,
Xingyu Wu
I think Greg is looking for this:
commit 538d5477b25289ac5d46ca37b9e5b4d685cbe019
Quoted 9 lines
Quoted 1 line
clk: starfive: jh7110-sys: Add notifier for PLL0 clock
That commit is already in the following releases:
	6.6.51 6.10.10
so what are we supposed to be doing here?
confused,
greg k-h
Quoted 7 lines
Sorry, I didn't check to see if it was already in releases. So the 6.10 queue is fine as is.
However, these two patches go together, so the 6.6 queue should also have 61f2e8a3a94175dbbaad6a54f381b2a505324610 "riscv: dts: starfive:
jh7110-common: Fix lower rate of CPUfreq by setting PLL0 rate to 1.5GHz" added to it.

Quoted 7 lines

Given that the file arch/riscv/boot/dts/starfive/jh7110-common.dtsi is not in the 6.6.y kernel tree, are you sure about this? If so, where should it be applied to instead?
thanks,
greg k-h

Doh, the patch was rebased, so it won't apply to 6.6. The good news is that not applying it won't break anything, it just renders the other patch to have no effect (the board still runs at 1 GHz instead of 1.5 GHz).

So in the end, there's nothing to do.

Xingyu Wu

author

2024-09-18 03:09 UTC #11 lore raw

In reply to Greg KH

Quoted 88 lines · Greg KH

Quoted 20 lines · Ron Economos
Quoted 19 lines · Greg KH
Quoted 18 lines · Ron Economos
Quoted 17 lines · Xingyu Wu
Quoted 16 lines · Greg KH
Quoted 15 lines · Xingyu Wu
Quoted 14 lines · Greg KH
Quoted 13 lines · Xingyu Wu
Quoted 12 lines · Sasha Levin
This is a note to let you know that I've just added the patch titled
riscv: dts: starfive: jh7110-common: Fix lower
rate of CPUfreq by setting PLL0 rate to 1.5GHz
to the 6.10-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/s
table-
queue.git;a=summary
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
The filename of the patch is:
riscv-dts-starfive-jh7110-common-fix-lower-rate-of-c.p atch and it can be found in the queue-6.10 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know
about it.
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 1 line
Hi Sasha,
This patch only has the part of DTS without the clock driver
patch[1].
Quoted 43 lines
Quoted 34 lines
Quoted 34 lines
Quoted 21 lines
Quoted 21 lines
Quoted 21 lines
Quoted 9 lines
Quoted 9 lines
[1]:
https://lore.kernel.org/all/20240826080430.179788-2-xing
yu.wu@star
five
tech.com/
I don't know your plan about this driver patch, or maybe I missed it. But the DTS changes really needs the driver patch to
work and you should add
Quoted 9 lines
the driver patch.
Then why does the commit say:
Quoted 3 lines
Quoted 3 lines
      Fixes: e2c510d6d630 ("riscv: dts: starfive: Add
cpu scaling for
JH7110 SoC")
Is that line incorrect?
No, this patch can also fix the problem.
In that patchset, the patch 2 depended on patch 1, so I added the Fixes tag in
Quoted 9 lines
Quoted 4 lines
both patches.
What is the commit id of the other change you are referring to here?
This commit id is the bug I'm trying to fix. The Fixes tag need to add it.
Thanks,
Xingyu Wu
I think Greg is looking for this:
commit 538d5477b25289ac5d46ca37b9e5b4d685cbe019
Quoted 9 lines
Quoted 1 line
clk: starfive: jh7110-sys: Add notifier for PLL0 clock
That commit is already in the following releases:
	6.6.51 6.10.10
so what are we supposed to be doing here?
confused,
greg k-h
Quoted 8 lines
Sorry, I didn't check to see if it was already in releases. So the 6.10 queue is fine as is.
However, these two patches go together, so the 6.6 queue should also have
61f2e8a3a94175dbbaad6a54f381b2a505324610 "riscv: dts: starfive:
jh7110-common: Fix lower rate of CPUfreq by setting PLL0 rate to 1.5GHz" added to it.

Quoted 4 lines

Given that the file arch/riscv/boot/dts/starfive/jh7110-common.dtsi is not in the 6.6.y kernel tree, are you sure about this? If so, where should it be applied to instead?

Hi Greg,

How about this patch[1] which I sent earlier about DTS?
[1]: https://lore.kernel.org/all/[email protected]/

This patch is based on older kernel without the file (jh7110-common.dtsi) and has been tested to work.

Best regards,
Xingyu Wu

Greg KH

2024-09-18 06:16 UTC #12 lore raw

Quoted 94 lines · Xingyu Wu

Quoted 88 lines · Greg KH
Quoted 20 lines · Ron Economos
Quoted 19 lines · Greg KH
Quoted 18 lines · Ron Economos
Quoted 17 lines · Xingyu Wu
Quoted 16 lines · Greg KH
Quoted 15 lines · Xingyu Wu
Quoted 14 lines · Greg KH
Quoted 13 lines · Xingyu Wu
Quoted 12 lines · Sasha Levin
This is a note to let you know that I've just added the patch titled
riscv: dts: starfive: jh7110-common: Fix lower
rate of CPUfreq by setting PLL0 rate to 1.5GHz
to the 6.10-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/s
table-
queue.git;a=summary
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
The filename of the patch is:
riscv-dts-starfive-jh7110-common-fix-lower-rate-of-c.p atch and it can be found in the queue-6.10 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know
about it.
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 1 line
Hi Sasha,
This patch only has the part of DTS without the clock driver
patch[1].
Quoted 43 lines
Quoted 34 lines
Quoted 34 lines
Quoted 21 lines
Quoted 21 lines
Quoted 21 lines
Quoted 9 lines
Quoted 9 lines
[1]:
https://lore.kernel.org/all/20240826080430.179788-2-xing
yu.wu@star
five
tech.com/
I don't know your plan about this driver patch, or maybe I missed it. But the DTS changes really needs the driver patch to
work and you should add
Quoted 9 lines
the driver patch.
Then why does the commit say:
Quoted 3 lines
Quoted 3 lines
      Fixes: e2c510d6d630 ("riscv: dts: starfive: Add
cpu scaling for
JH7110 SoC")
Is that line incorrect?
No, this patch can also fix the problem.
In that patchset, the patch 2 depended on patch 1, so I added the Fixes tag in
Quoted 9 lines
Quoted 4 lines
both patches.
What is the commit id of the other change you are referring to here?
This commit id is the bug I'm trying to fix. The Fixes tag need to add it.
Thanks,
Xingyu Wu
I think Greg is looking for this:
commit 538d5477b25289ac5d46ca37b9e5b4d685cbe019
Quoted 9 lines
Quoted 1 line
clk: starfive: jh7110-sys: Add notifier for PLL0 clock
That commit is already in the following releases:
	6.6.51 6.10.10
so what are we supposed to be doing here?
confused,
greg k-h
Quoted 8 lines
Sorry, I didn't check to see if it was already in releases. So the 6.10 queue is fine as is.
However, these two patches go together, so the 6.6 queue should also have
61f2e8a3a94175dbbaad6a54f381b2a505324610 "riscv: dts: starfive:
jh7110-common: Fix lower rate of CPUfreq by setting PLL0 rate to 1.5GHz" added to it.
Quoted 4 lines
Given that the file arch/riscv/boot/dts/starfive/jh7110-common.dtsi is not in the 6.6.y kernel tree, are you sure about this? If so, where should it be applied to instead?

Quoted 6 lines

Hi Greg,
How about this patch[1] which I sent earlier about DTS?
[1]: https://lore.kernel.org/all/[email protected]/
This patch is based on older kernel without the file (jh7110-common.dtsi) and has been tested to work.

If you think it fits the rules of:
https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
then great, resubmit it!

thanks,

greg k-h