Skip to contentSkip to conversation

libperf: Explicitly specify install-html dependencies

PATCH Applied Akihiko Odaki 2 participants 2 messages Sep 15, 2024 – Sep 27, 2024 perf events

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 libperf: Explicitly specify install-html dependencies

install_doc of tools/lib/perf/Makefile invokes install-man, install-html, and install-examples of tools/lib/perf/Documentation/Makefile at once. This invocation succeeds when make runs in serial but can fail when make runs in parallel because while install-man of tools/lib/perf/Documentation/Makefile depends on all, install-html depends on nothing and can run ahead of all.

Explicitly specify the dependencies of install-html to ensure that they are resolved before install-html.

---
 tools/lib/perf/Documentation/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/lib/perf/Documentation/Makefile +1 -1
index 972754082a85..573ca5b27556 100644
@@ -121,7 +121,7 @@ install-man: all
 		$(INSTALL) -d -m 755 $(DESTDIR)$(man7dir); \
 		$(INSTALL) -m 644 $(MAN_7) $(DESTDIR)$(man7dir);
 
-install-html:
+install-html: $(MAN_HTML)
 	$(call QUIET_INSTALL, html) \
 		$(INSTALL) -d -m 755 $(DESTDIR)$(htmldir); \
 		$(INSTALL) -m 644 $(MAN_HTML) $(DESTDIR)$(htmldir); \

---
base-commit: 46a0057a5853cbdb58211c19e89ba7777dc6fd50
change-id: 20240904-perf-f779f912365f

Best regards,

Signature · 1 line
Akihiko Odaki <[email protected]>
maintainer Applied
#1 lore raw
Quoted 8 lines · Akihiko Odaki

install_doc of tools/lib/perf/Makefile invokes install-man, install-html, and install-examples of tools/lib/perf/Documentation/Makefile at once. This invocation succeeds when make runs in serial but can fail when make runs in parallel because while install-man of tools/lib/perf/Documentation/Makefile depends on all, install-html depends on nothing and can run ahead of all.

[...]

Applied to perf-tools-next, thanks!

Best regards,
Namhyung