Skip to contentSkip to conversation

Remove now unsupported power management tests

PATCH In review Cyril Hrubis 2 participants 2 messages Sep 16, 2024 – Oct 15, 2024

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Remove now unsupported power management tests

The sched_mc_power_savings and sched_smt_power_savings sysfs knobs were removed from kernel in:

commit 8e7fbcbc22c12414bcc9dfdd683637f58fb32759

Author: Peter Zijlstra <[email protected]>
Date:   Mon Jan 9 11:28:35 2012 +0100

sched: Remove stale power aware scheduling remnants and dysfunctional knobs

That went into kernel 3.5 and the minimal kernel version LTP currently supports is 3.10.

This has been discussed in:

https://github.com/linux-test-project/ltp/pull/1016

---
 runtest/power_management_tests                |   3 -
 runtest/power_management_tests_exclusive      |   6 -
 testcases/kernel/power_management/.gitignore  |   1 -
 testcases/kernel/power_management/README      |  29 ----
 .../power_management/pm_cpu_consolidation.py  | 143 ------------------
 .../power_management/pm_get_sched_values.c    |  36 -----
 .../kernel/power_management/runpwtests01.sh   |  71 ---------
 .../kernel/power_management/runpwtests02.sh   |  68 ---------
 .../kernel/power_management/runpwtests05.sh   |  76 ----------
 .../runpwtests_exclusive01.sh                 |  97 ------------
 .../runpwtests_exclusive02.sh                 |  68 ---------
 .../runpwtests_exclusive03.sh                 |  95 ------------
 .../runpwtests_exclusive04.sh                 |  58 -------
 .../runpwtests_exclusive05.sh                 |  97 ------------
 14 files changed, 848 deletions(-)
 delete mode 100644 runtest/power_management_tests_exclusive
 delete mode 100644 testcases/kernel/power_management/.gitignore
 delete mode 100755 testcases/kernel/power_management/pm_cpu_consolidation.py
 delete mode 100644 testcases/kernel/power_management/pm_get_sched_values.c
 delete mode 100755 testcases/kernel/power_management/runpwtests01.sh
 delete mode 100755 testcases/kernel/power_management/runpwtests02.sh
 delete mode 100755 testcases/kernel/power_management/runpwtests05.sh
 delete mode 100755 testcases/kernel/power_management/runpwtests_exclusive01.sh
 delete mode 100755 testcases/kernel/power_management/runpwtests_exclusive02.sh
 delete mode 100755 testcases/kernel/power_management/runpwtests_exclusive03.sh
 delete mode 100755 testcases/kernel/power_management/runpwtests_exclusive04.sh
 delete mode 100755 testcases/kernel/power_management/runpwtests_exclusive05.sh
runtest/power_management_tests +0 -3
index 884e615cd..b670da6ec 100644
@@ -1,7 +1,4 @@
 #POWER_MANAGEMENT
-runpwtests01 runpwtests01.sh
-runpwtests02 runpwtests02.sh
 runpwtests03 runpwtests03.sh
 runpwtests04 runpwtests04.sh
-#runpwtests05 runpwtests05.sh
 runpwtests06 runpwtests06.sh
runtest/power_management_tests_exclusive deleted +0 -6
deleted file mode 100644
index 0eb012247..000000000
@@ -1,6 +0,0 @@
-#POWER_MANAGEMENT exclusive
-runpwtests_exclusive01 runpwtests_exclusive01.sh
-runpwtests_exclusive02 runpwtests_exclusive02.sh
-runpwtests_exclusive03 runpwtests_exclusive03.sh
-runpwtests_exclusive04 runpwtests_exclusive04.sh
-runpwtests_exclusive05 runpwtests_exclusive05.sh
testcases/kernel/power_management/.gitignore deleted +0 -1
deleted file mode 100644
index 0c2a3ed4b..000000000
@@ -1 +0,0 @@
-pm_get_sched_values
testcases/kernel/power_management/README +0 -29
index b8d6c316e..1b82782d8 100644
@@ -38,13 +38,6 @@ CONFIG_CPU_IDLE
 CONFIG_CPU_IDLE_GOV_LADDER
 CONFIG_CPU_IDLE_GOV_MENU
 
-for SCHED_MC tests:
-
-CONFIG_SCHED_MC
-
-The power management test automation suite helps run the power management functionality
-(e.g: cpu frequency, cpu idle etc..) tests and report results.
-
 Test Scripts for CPU FREQUENCY:
 change_freq.sh
 change_govr.sh
@@ -53,9 +46,6 @@ check_cpufreq_sysfs_files.sh
 Test Scripts for CPU IDLE:
 will be added soon
 
-Test Scripts for SCHED_MC:
-test_sched_mc.sh
-
 Common functionality:
 pm_include.sh
 check_kv_arch.c
@@ -66,22 +56,3 @@ To run your tests you can execute the runpwtests.sh
 To run the tests individually :
 
 P.S. As of now the supporting architecture(s) are x86,x86_64
-
-Support of system:
------------------
-If you see some thing like following,
-
-Power Management    1  FAIL  :  Required kernel configuration for SCHED_MC NOT set
-or
-Power Management    1  FAIL  :  Required kernel configuration for CPU_FREQ NOT set
-
-Then either configuration is not set or the system won't support.
-
-For CPU consolidation verification ebizzy is included in utils directory of LTP.
-To run cpu consolidation test user has to provide -w <workload> -l <sched_mc_level>.
-Refer to README in LTPROOT/utils/benchmark/ebizzy-0.2 directory for details of ebizzy.
-
-To test CPU consolidation for sched_mc 2 kernbench has to run. Kernbench needs linux kernel source as input in /root directory . For example download from http://www.kernel.org/pub/linux/kernel/v2.6/linux-2.6.29.4.tar.bz2. If Linux kernel source not found kernbench wiil  not execute.
-CPU consolidation testcases will not execute if number of CPU's in package is less then 2. If system is hyper threaded but number of CPU is 1 only sched_smt testcases will be excuted. For better coverage of testcases select a system which is at least quad core and then hyper threaded so that you will observe 8 CPU's in each package.
-
-Timer migration interface test will execute on kernel versions 2.6.31 and above. Timer migration functionality verification testcases will be executed only on suitable architecture like quad core or the number of CPU's in each package should be at least 4 and above
testcases/kernel/power_management/pm_cpu_consolidation.py deleted +0 -143

143 lines not on this page · raw message

testcases/kernel/power_management/pm_get_sched_values.c deleted +0 -36
deleted file mode 100644
index e75c5852e..000000000
@@ -1,36 +0,0 @@
-/************************************************************************
-* Copyright (c) International Business Machines Corp., 2008
-* This program is free software; you can redistribute it and/or modify
-* it under the terms of the GNU General Public License as published by
-* the Free Software Foundation; either version 2 of the License, or
-* (at your option) any later version.
-*
-* This program is distributed in the hope that it will be useful,
-* but WITHOUT ANY WARRANTY; without even the implied warranty of
-* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See
-* the GNU General Public License for more details.
-* You should have received a copy of the GNU General Public License
-* along with this program; if not, write to the Free Software
-* Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
-*
-***************************************************************************/
-#include <stdio.h>
-#include "test.h"
-
-const char *TCID = "pm_get_sched_values";
-
-int main(int argc, char **argv)
-{
-	char *param;
-	if (argc == 0)
-		return 1;
-	else {
-		param = argv[1];
-		if (strcmp(param, "sched_mc") == 0)
-			return 2;
-		if (strcmp(param, "sched_smt") == 0)
-			return 2;
-	}
-
-	return 1;
-}
testcases/kernel/power_management/runpwtests01.sh deleted +0 -71

71 lines not on this page · raw message

testcases/kernel/power_management/runpwtests02.sh deleted +0 -68

68 lines not on this page · raw message

testcases/kernel/power_management/runpwtests05.sh deleted +0 -76

76 lines not on this page · raw message

testcases/kernel/power_management/runpwtests_exclusive01.sh deleted +0 -97

97 lines not on this page · raw message

testcases/kernel/power_management/runpwtests_exclusive02.sh deleted +0 -68

68 lines not on this page · raw message

testcases/kernel/power_management/runpwtests_exclusive03.sh deleted +0 -95

95 lines not on this page · raw message

testcases/kernel/power_management/runpwtests_exclusive04.sh deleted +0 -58

58 lines not on this page · raw message

testcases/kernel/power_management/runpwtests_exclusive05.sh deleted +0 -97

97 lines not on this page · raw message

Signature · 5 lines
2.44.2


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp
Reviewed-by on v1 1/1
#1 lore raw

Hi Cyril,

[ Cc [email protected] ]

Quoted 11 lines

The sched_mc_power_savings and sched_smt_power_savings sysfs knobs were removed from kernel in:

commit 8e7fbcbc22c12414bcc9dfdd683637f58fb32759

Author: Peter Zijlstra <[email protected]>
Date:   Mon Jan 9 11:28:35 2012 +0100

sched: Remove stale power aware scheduling remnants and dysfunctional knobs

That went into kernel 3.5 and the minimal kernel version LTP currently supports is 3.10.

Good catch.

I wanted to be happy that whole power management testsuite is being removed (legacy unmaintained code written in python which is not preferred language for LTP). But it's really just the unsupported subset. Otherwise power_management_tests would need to be removed from scenario_groups/default.

Quoted 5 lines

This has been discussed in:

https://github.com/linux-test-project/ltp/pull/1016

Quoted 10 lines
---
 runtest/power_management_tests                |   3 -
 runtest/power_management_tests_exclusive      |   6 -
 testcases/kernel/power_management/.gitignore  |   1 -
 testcases/kernel/power_management/README      |  29 ----
 .../power_management/pm_cpu_consolidation.py  | 143 ------------------
 .../power_management/pm_get_sched_values.c    |  36 -----
 .../kernel/power_management/runpwtests01.sh   |  71 ---------
 .../kernel/power_management/runpwtests02.sh   |  68 ---------
 .../kernel/power_management/runpwtests05.sh   |  76 ----------

Deleted runpwtests05.sh was the only file which used pm_sched_domain.py and pm_ilb_test.py.

And when these python scripts are deleted, there is still some dead code in testcases/kernel/power_management/lib/pm_sched_mc.py which works with
sched_mc_power_savings: reset_schedmc() and set_sched_mc_power() and with set_sched_smt_power: set_sched_smt_power() and reset_schedsmt().

Could you please delete these. With this:

Kind regards,
Petr

Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp