Updates for Atmel SSC DAI

This patch set includes two updates for the Atmel SSC DAI driver:
- Address the limitation with the S24_LE format.
- Add stream names for DPCM and future use-cases.

Codrin Ciubotariu (2):
ASoC: atmel: atmel_ssc_dai: Add stream names
ASoC: atmel: atmel_ssc_dai: Drop S24_LE support due to single channel
limitation

 sound/soc/atmel/atmel_ssc_dai.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

base-commit: 7083504315d64199a329de322fce989e1e10f4f7

2.34.1

From: Codrin Ciubotariu <[email protected]>

Add required stream names for DPCM and future use-cases.

[[email protected]: Adjust commit title. Reword commit message.]

---
v1 -> v2:
- add Reviewed-by tag

---
 sound/soc/atmel/atmel_ssc_dai.c | 2 ++
 1 file changed, 2 insertions(+)

index 3763454436c1..7047f17fe7a8 100644
@@ -836,6 +836,7 @@ static const struct snd_soc_dai_ops atmel_ssc_dai_ops = {
 
 static struct snd_soc_dai_driver atmel_ssc_dai = {
 		.playback = {
+			.stream_name = "Playback",
 			.channels_min = 1,
 			.channels_max = 2,
 			.rates = SNDRV_PCM_RATE_CONTINUOUS,

@@ -843,6 +844,7 @@ static struct snd_soc_dai_driver atmel_ssc_dai = {
 			.rate_max = 384000,
 			.formats = ATMEL_SSC_FORMATS,},
 		.capture = {
+			.stream_name = "Capture",
 			.channels_min = 1,
 			.channels_max = 2,
 			.rates = SNDRV_PCM_RATE_CONTINUOUS,

2.34.1

From: Codrin Ciubotariu <[email protected]>

Drop S24_LE format because it is not supported if more than 2 channels (of TDM slots) are used. This limitation makes it impractical for use cases requiring more than 2 TDM slots, leading to potential issues in multi-channel configurations.

[[email protected]: Reword the commit title and the commit message. Add code comment to explain the removed code.]

---
v1 -> v2:
- add code comment to explain why S24_LE is dropped.

---
 sound/soc/atmel/atmel_ssc_dai.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

index 7047f17fe7a8..89098f41679c 100644
@@ -821,8 +821,9 @@ static int atmel_ssc_resume(struct snd_soc_component *component)
 	return 0;
 }
 
+/* S24_LE is not supported if more than 2 channels (of TDM slots) are used. */
 #define ATMEL_SSC_FORMATS (SNDRV_PCM_FMTBIT_S8     | SNDRV_PCM_FMTBIT_S16_LE |\
-			  SNDRV_PCM_FMTBIT_S24_LE | SNDRV_PCM_FMTBIT_S32_LE)
+			   SNDRV_PCM_FMTBIT_S32_LE)
 
 static const struct snd_soc_dai_ops atmel_ssc_dai_ops = {
 	.startup	= atmel_ssc_startup,

2.34.1

Applied to

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/2] ASoC: atmel: atmel_ssc_dai: Add stream names

      commit: 879c9151572317e8ddb6ab6c57a7689bf580efc9
[2/2] ASoC: atmel: atmel_ssc_dai: Drop S24_LE support due to single channel limitation
      commit: ac8775d7de5a8ccac225a398cbce9fb9fffdbb9f

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark