gpu: host1x: Set up device DMA parameters
PATCH 1/1 gpu: host1x: Set up device DMA parameters
From: Thierry Reding <[email protected]>
In order to store device DMA parameters, the DMA framework depends on the device's dma_parms field to point at a valid memory location. Add backing storage for this in struct host1x_memory_context and point to it.
--- drivers/gpu/host1x/context.c | 1 + include/linux/host1x.h | 1 + 2 files changed, 2 insertions(+)
drivers/gpu/host1x/context.c +1 -0
@@ -58,6 +58,7 @@ int host1x_memory_context_list_init(struct host1x *host1x) ctx->dev.parent = host1x->dev; ctx->dev.release = host1x_memory_context_release; + ctx->dev.dma_parms = &ctx->dma_parms;dma_set_max_seg_size (&ctx->dev,UINT_MAX ); err =device_add (&ctx->dev);
include/linux/host1x.h +1 -0
@@ -466,6 +466,7 @@ struct host1x_memory_context {refcount_t ref;struct pid *owner; +struct device_dma_parameters dma_parms;struct device dev;u64 dma_mask;u32 stream_id;
Signature · 1 line
2.45.2
Quoted 9 lines · Thierry Reding
From: Thierry Reding <[email protected]>
In order to store device DMA parameters, the DMA framework depends on the device's
dma_parmsfield to point at a valid memory location. Add backing storage for this in structhost1x_memory_contextand point to it.Reported-by Jonathan Hunter <[email protected]>Signed-off-by Thierry Reding <[email protected]>
Looks good:
I guess this another thing caught by the WARN_ON in the dma_set* functions?
Quoted 11 lines · Christoph Hellwig
Quoted 9 lines · Thierry Reding
From: Thierry Reding <[email protected]>
In order to store device DMA parameters, the DMA framework depends on the device's
dma_parmsfield to point at a valid memory location. Add backing storage for this in structhost1x_memory_contextand point to it.Reported-by Jonathan Hunter <[email protected]>Signed-off-by Thierry Reding <[email protected]>
Quoted 6 lines
Looks good:
Reviewed-by Christoph Hellwig <[email protected]>I guess this another thing caught by the
WARN_ONin the dma_set* functions?
Yes indeed! This works for me.
Thanks
Jon
Signature · 1 line
nvpublic
Thierry Reding
AppliedQuoted 7 lines · Thierry Reding
From: Thierry Reding <[email protected]>
In order to store device DMA parameters, the DMA framework depends on the device's
dma_parmsfield to point at a valid memory location. Add backing storage for this in structhost1x_memory_contextand point to it.
Quoted 6 lines
Reported-by Jonathan Hunter <[email protected]>Signed-off-by Thierry Reding <[email protected]>--- drivers/gpu/host1x/context.c | 1 + include/linux/host1x.h | 1 + 2 files changed, 2 insertions(+)
Applied.
Thierry