Skip to contentSkip to conversation

dt-bindings: display: panel-simple: Document support for Microchip AC69T88A

PATCH Applied Manikandan Muralidharan 4 participants 12 messages Sep 19, 2024 – Oct 19, 2024

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/2 dt-bindings: display: panel-simple: Document support for Microchip AC69T88A

Add Microchip AC69T88A 5" LVDS interface (800x480) TFT LCD panel compatible string

---
changes in v2:
- Replace microchip,ac69t88a-lvds-panel with
microchip,ac69t88a

---
 .../devicetree/bindings/display/panel/panel-simple.yaml         | 2 ++
 1 file changed, 2 insertions(+)
Documentation/devicetree/bindings/display/panel/panel-simple.yaml +2 -0
index b89e39790579..18b63f356bb4 100644
@@ -200,6 +200,8 @@ properties:
       - logictechno,lttd800480070-l2rt
         # Logic Technologies LTTD800480070-L6WH-RT 7” 800x480 TFT Resistive Touch Module
       - logictechno,lttd800480070-l6wh-rt
+        # Microchip AC69T88A 5" 800X480 LVDS interface TFT LCD Panel
+      - microchip,ac69t88a
         # Mitsubishi "AA070MC01 7.0" WVGA TFT LCD panel
       - mitsubishi,aa070mc01-ca1
         # Mitsubishi AA084XE01 8.4" XGA TFT LCD panel
Signature · 1 line
2.25.1
#1 lore raw

PATCH v2 2/2 drm/panel: simple: Add Microchip AC69T88A LVDS Display panel

Add support for Microchip AC69T88A 5 inch TFT LCD 800x480 Display module with LVDS interface.The panel uses the Sitronix ST7262 800x480 Display driver

---
changes in v2:
- replace microchip,ac69t88a-lvds-panel with
microchip,ac69t88a

---
 drivers/gpu/drm/panel/panel-simple.c | 28 ++++++++++++++++++++++++++++
 1 file changed, 28 insertions(+)
drivers/gpu/drm/panel/panel-simple.c +28 -0
index 86735430462f..06381c628209 100644
@@ -4565,6 +4565,31 @@ static const struct panel_desc yes_optoelectronics_ytc700tlag_05_201c = {
 	.connector_type = DRM_MODE_CONNECTOR_LVDS,
 };
 
+static const struct drm_display_mode mchp_ac69t88a_mode = {
+	.clock = 25000,
+	.hdisplay = 800,
+	.hsync_start = 800 + 88,
+	.hsync_end = 800 + 88 + 5,
+	.htotal = 800 + 88 + 5 + 40,
+	.vdisplay = 480,
+	.vsync_start = 480 + 23,
+	.vsync_end = 480 + 23 + 5,
+	.vtotal = 480 + 23 + 5 + 1,
+};
+
+static const struct panel_desc mchp_ac69t88a = {
+	.modes = &mchp_ac69t88a_mode,
+	.num_modes = 1,
+	.bpc = 8,
+	.size = {
+		.width = 108,
+		.height = 65,
+	},
+	.bus_flags = DRM_BUS_FLAG_DE_HIGH,
+	.bus_format = MEDIA_BUS_FMT_RGB888_1X7X4_JEIDA,
+	.connector_type = DRM_MODE_CONNECTOR_LVDS,
+};
+
 static const struct drm_display_mode arm_rtsm_mode[] = {
 	{
 		.clock = 65000,
@@ -5048,6 +5073,9 @@ static const struct of_device_id platform_of_match[] = {
 	}, {
 		.compatible = "yes-optoelectronics,ytc700tlag-05-201c",
 		.data = &yes_optoelectronics_ytc700tlag_05_201c,
+	}, {
+		.compatible = "microchip,ac69t88a",
+		.data = &mchp_ac69t88a,
 	}, {
 		/* Must be the last entry */
 		.compatible = "panel-dpi",
Signature · 1 line
2.25.1
#2 lore raw

Re: [PATCH v2 2/2] drm/panel: simple: Add Microchip AC69T88A LVDS Display panel

Quoted 3 lines · Manikandan Muralidharan

Add support for Microchip AC69T88A 5 inch TFT LCD 800x480 Display module with LVDS interface.The panel uses the Sitronix ST7262 800x480 Display driver

AC69T88A seems to be a module name, rather than a panel name. What is the actual panel name present on this module?

Quoted 11 lines

---
changes in v2:
- replace microchip,ac69t88a-lvds-panel with
microchip,ac69t88a

---
 drivers/gpu/drm/panel/panel-simple.c | 28 ++++++++++++++++++++++++++++
 1 file changed, 28 insertions(+)
Signature · 2 lines
With best wishes
Dmitry
#3 lore raw

Re: [PATCH v2 2/2] drm/panel: simple: Add Microchip AC69T88A LVDS Display panel

Quoted 9 lines · Dmitry Baryshkov

EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe

Quoted 3 lines · Manikandan Muralidharan

Add support for Microchip AC69T88A 5 inch TFT LCD 800x480 Display module with LVDS interface.The panel uses the Sitronix ST7262 800x480 Display driver

AC69T88A seems to be a module name, rather than a panel name. What is the actual panel name present on this module?

Both names, "Microchip AC69T88A" and "MPU32-LVDS-DISPLAY-WVGA" are present on the display module

Quoted 16 lines
Quoted 4 lines
Quoted 8 lines

---
changes in v2:
- replace microchip,ac69t88a-lvds-panel with
microchip,ac69t88a

---
  drivers/gpu/drm/panel/panel-simple.c | 28 ++++++++++++++++++++++++++++
  1 file changed, 28 insertions(+)

--
With best wishes
Dmitry

Signature · 2 lines
Thanks and Regards,
Manikandan M.
#4 lore raw

Re: [PATCH v2 2/2] drm/panel: simple: Add Microchip AC69T88A LVDS Display panel

Quoted 4 lines · On Mon, Sep 23, 2024 at 05:50:22AM GMT, [email protected] wrote:
Quoted 3 lines · Dmitry Baryshkov

EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe

On Thu, Sep 19, 2024 at 02:45:48PM GMT, Manikandan Muralidharan wrote:

Quoted 8 lines
Quoted 6 lines
Quoted 3 lines

Add support for Microchip AC69T88A 5 inch TFT LCD 800x480 Display module with LVDS interface.The panel uses the Sitronix ST7262 800x480 Display driver

AC69T88A seems to be a module name, rather than a panel name. What is the actual panel name present on this module?

Both names, "Microchip AC69T88A" and "MPU32-LVDS-DISPLAY-WVGA" are present on the display module

Which panel was used for the module? I don't think that Microchip produces LVDS panels.

Quoted 21 lines
Quoted 16 lines
Quoted 4 lines
Quoted 8 lines

---
changes in v2:
- replace microchip,ac69t88a-lvds-panel with
microchip,ac69t88a

---
  drivers/gpu/drm/panel/panel-simple.c | 28 ++++++++++++++++++++++++++++
  1 file changed, 28 insertions(+)

--
With best wishes
Dmitry

Signature · 2 lines
Thanks and Regards,
Manikandan M.
Signature · 2 lines
With best wishes
Dmitry
#5 lore raw

Re: [PATCH v2 2/2] drm/panel: simple: Add Microchip AC69T88A LVDS Display panel

Quoted 11 lines · Dmitry Baryshkov

EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe

Quoted 8 lines · On Mon, Sep 23, 2024 at 05:50:22AM GMT, [email protected] wrote:
Quoted 7 lines · Dmitry Baryshkov

EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe

Quoted 3 lines · Manikandan Muralidharan

Add support for Microchip AC69T88A 5 inch TFT LCD 800x480 Display module with LVDS interface.The panel uses the Sitronix ST7262 800x480 Display driver

Quoted 7 lines
Quoted 4 lines
Quoted 2 lines

AC69T88A seems to be a module name, rather than a panel name. What is the actual panel name present on this module?

Both names, "Microchip AC69T88A" and "MPU32-LVDS-DISPLAY-WVGA" are present on the display module

Which panel was used for the module? I don't think that Microchip produces LVDS panels.

Its a new LVDS display from Microchip that uses Sitronix ST7262 TFT LCD driver

https://www.crystalfontz.com/controllers/datasheet-viewer.php?id=486

Quoted 26 lines
Quoted 14 lines
Quoted 14 lines
Quoted 13 lines

---
changes in v2:
- replace microchip,ac69t88a-lvds-panel with
microchip,ac69t88a

---
   drivers/gpu/drm/panel/panel-simple.c | 28 ++++++++++++++++++++++++++++
   1 file changed, 28 insertions(+)
Quoted 8 lines
Quoted 3 lines

--
With best wishes
Dmitry

--
Thanks and Regards,
Manikandan M.

--
With best wishes
Dmitry

Signature · 2 lines
Thanks and Regards,
Manikandan M.
Reviewed-by
#6 lore raw

Re: [PATCH v2 2/2] drm/panel: simple: Add Microchip AC69T88A LVDS Display panel

Quoted 17 lines · On Thu, Sep 26, 2024 at 08:17:09AM GMT, [email protected] wrote:
Quoted 16 lines · Dmitry Baryshkov

EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe

Quoted 12 lines · On Mon, Sep 23, 2024 at 05:50:22AM GMT, [email protected] wrote:
Quoted 9 lines · Dmitry Baryshkov

EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe

Quoted 3 lines · Manikandan Muralidharan

Add support for Microchip AC69T88A 5 inch TFT LCD 800x480 Display module with LVDS interface.The panel uses the Sitronix ST7262 800x480 Display driver

AC69T88A seems to be a module name, rather than a panel name. What is the actual panel name present on this module?

Both names, "Microchip AC69T88A" and "MPU32-LVDS-DISPLAY-WVGA" are present on the display module

Quoted 6 lines
Quoted 2 lines

Which panel was used for the module? I don't think that Microchip produces LVDS panels.

Its a new LVDS display from Microchip that uses Sitronix ST7262 TFT LCD driver

https://www.crystalfontz.com/controllers/datasheet-viewer.php?id=486

Ok. Anyway if somebody ends up looking for the panel, they'll probably find the module and vice versa.

Signature · 2 lines
With best wishes
Dmitry
maintainer
#7 lore raw

Re: [PATCH v2 2/2] drm/panel: simple: Add Microchip AC69T88A LVDS Display panel

Quoted 23 lines · Dmitry Baryshkov
Quoted 22 lines · On Thu, Sep 26, 2024 at 08:17:09AM GMT, [email protected] wrote:
Quoted 11 lines · Dmitry Baryshkov

EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe

Quoted 8 lines · On Mon, Sep 23, 2024 at 05:50:22AM GMT, [email protected] wrote:
Quoted 7 lines · Dmitry Baryshkov

EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe

Quoted 3 lines · Manikandan Muralidharan

Add support for Microchip AC69T88A 5 inch TFT LCD 800x480 Display module with LVDS interface.The panel uses the Sitronix ST7262 800x480 Display driver

Quoted 7 lines
Quoted 4 lines
Quoted 2 lines

AC69T88A seems to be a module name, rather than a panel name. What is the actual panel name present on this module?

Both names, "Microchip AC69T88A" and "MPU32-LVDS-DISPLAY-WVGA" are present on the display module

Which panel was used for the module? I don't think that Microchip produces LVDS panels.

Its a new LVDS display from Microchip that uses Sitronix ST7262 TFT LCD driver

Quoted 6 lines
Quoted 1 line

https://www.crystalfontz.com/controllers/datasheet-viewer.php?id=486

Ok. Anyway if somebody ends up looking for the panel, they'll probably find the module and vice versa.

Given that aside from that mail, the module name isn't mentionned anywhere, I'm not sure they would.

The way we usually deal with controllers is to have a separate driver for panels based on that controller, even more so since that controller seems to be able to affect the display.

Maxime

#8 lore raw

Re: [PATCH v2 2/2] drm/panel: simple: Add Microchip AC69T88A LVDS Display panel

Quoted 29 lines · Maxime Ripard
Quoted 28 lines · Dmitry Baryshkov
Quoted 17 lines · On Thu, Sep 26, 2024 at 08:17:09AM GMT, [email protected] wrote:
Quoted 16 lines · Dmitry Baryshkov

EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe

Quoted 12 lines · On Mon, Sep 23, 2024 at 05:50:22AM GMT, [email protected] wrote:
Quoted 9 lines · Dmitry Baryshkov

EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe

Quoted 3 lines · Manikandan Muralidharan

Add support for Microchip AC69T88A 5 inch TFT LCD 800x480 Display module with LVDS interface.The panel uses the Sitronix ST7262 800x480 Display driver

AC69T88A seems to be a module name, rather than a panel name. What is the actual panel name present on this module?

Both names, "Microchip AC69T88A" and "MPU32-LVDS-DISPLAY-WVGA" are present on the display module

Quoted 6 lines
Quoted 2 lines

Which panel was used for the module? I don't think that Microchip produces LVDS panels.

Its a new LVDS display from Microchip that uses Sitronix ST7262 TFT LCD driver

https://www.crystalfontz.com/controllers/datasheet-viewer.php?id=486

Ok. Anyway if somebody ends up looking for the panel, they'll probably find the module and vice versa.

Quoted 8 lines
Quoted 1 line

Given that aside from that mail, the module name isn't mentionned anywhere, I'm not sure they would.

The way we usually deal with controllers is to have a separate driver for panels based on that controller, even more so since that controller seems to be able to affect the display.

But in this case it's panel-simple, no special driver for the controller. From my understanding the AC69T88A is the module name (at least the datasheet uses that name). The on-board EEPROM also carries that name and the name of the controller.

Signature · 2 lines
With best wishes
Dmitry
#9 lore raw

Re: [PATCH v2 2/2] drm/panel: simple: Add Microchip AC69T88A LVDS Display panel

Quoted 37 lines · Dmitry Baryshkov

EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe

Quoted 34 lines · Maxime Ripard
Quoted 23 lines · Dmitry Baryshkov
Quoted 22 lines · On Thu, Sep 26, 2024 at 08:17:09AM GMT, [email protected] wrote:
Quoted 11 lines · Dmitry Baryshkov

EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe

Quoted 8 lines · On Mon, Sep 23, 2024 at 05:50:22AM GMT, [email protected] wrote:
Quoted 7 lines · Dmitry Baryshkov

EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe

Quoted 3 lines · Manikandan Muralidharan

Add support for Microchip AC69T88A 5 inch TFT LCD 800x480 Display module with LVDS interface.The panel uses the Sitronix ST7262 800x480 Display driver

Quoted 7 lines
Quoted 4 lines
Quoted 2 lines

AC69T88A seems to be a module name, rather than a panel name. What is the actual panel name present on this module?

Both names, "Microchip AC69T88A" and "MPU32-LVDS-DISPLAY-WVGA" are present on the display module

Which panel was used for the module? I don't think that Microchip produces LVDS panels.

Its a new LVDS display from Microchip that uses Sitronix ST7262 TFT LCD driver

Quoted 6 lines
Quoted 1 line

https://www.crystalfontz.com/controllers/datasheet-viewer.php?id=486

Ok. Anyway if somebody ends up looking for the panel, they'll probably find the module and vice versa.

Given that aside from that mail, the module name isn't mentionned anywhere, I'm not sure they would.

Quoted 8 lines
Quoted 3 lines

The way we usually deal with controllers is to have a separate driver for panels based on that controller, even more so since that controller seems to be able to affect the display.

But in this case it's panel-simple, no special driver for the controller. From my understanding the AC69T88A is the module name (at least the datasheet uses that name). The on-board EEPROM also carries that name and the name of the controller.

Yes, as per the proposed on-board EEPROM spec, it holds the module name and the LCD driver used.

Quoted 4 lines

--
With best wishes
Dmitry

Signature · 2 lines
Thanks and Regards,
Manikandan M.
maintainer Acked-by on v2 1/2
#10 lore raw
In reply to Manikandan Muralidharan
Quoted 12 lines · Manikandan Muralidharan

Add Microchip AC69T88A 5" LVDS interface (800x480) TFT LCD panel compatible string

---
changes in v2:
- Replace microchip,ac69t88a-lvds-panel with
microchip,ac69t88a

---
 .../devicetree/bindings/display/panel/panel-simple.yaml         | 2 ++
 1 file changed, 2 insertions(+)
#11 lore raw
In reply to Manikandan Muralidharan
Quoted 4 lines · Manikandan Muralidharan

Add Microchip AC69T88A 5" LVDS interface (800x480) TFT LCD panel compatible string

Applied to drm-misc-next, thanks!

[1/2] dt-bindings: display: panel-simple: Document support for Microchip AC69T88A

      commit: c3f0b90f6ffc178bf158aeccae268276363d6945
[2/2] drm/panel: simple: Add Microchip AC69T88A LVDS Display panel
      commit: 40da1463cd6879f542238b36c1148f517927c595

Best regards,

Signature · 2 lines
With best wishes
Dmitry