mm/damon: fix sparse warning for zero initializer
Subsystems (2)
PATCH 1/1 mm/damon: fix sparse warning for zero initializer
sparse warns about zero initializing an array with {0,}, change it to the equivalent {0}.
Fixes the sparse warning:mm/damon/tests/vaddr-kunit.h:69:47: warning: missing braces around initializer
--- mm/damon/tests/vaddr-kunit.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
mm/damon/tests/vaddr-kunit.h +1 -1
@@ -66,7 +66,7 @@ static int __link_vmas(struct maple_tree *mt, struct vm_area_struct *vmas,static void damon_test_three_regions_in_vmas (struct kunit *test) {static struct mm_struct mm; -struct damon_addr_range regions[3 ] = {0 ,}; +struct damon_addr_range regions[3 ] = {0 };/* 10-20-25, 200-210-220, 300-305, 307-330 */ struct vm_area_struct vmas[] = { (struct vm_area_struct ) {.vm_start =10 , .vm_end =20 },
Signature · 1 line
2.43.0
Hi Leo,
Thank you for this patch!
Quoted 7 lines · On Sat, 21 Sep 2024 12:54:45 -0700 Leo Stone <[email protected]> wrote:
sparse warns about zero initializing an array with {0,}, change it to the equivalent {0}.
Fixes the sparse warning:
mm/damon/tests/vaddr-kunit.h:69:47: warning: missing braces around initializerSigned-off-by Leo Stone <[email protected]>
I also think below tag would be good to add?
17ccae8bb5c9 ("mm/damon: add kunit tests")
Thanks,
SJ
Quoted 19 lines
--- mm/damon/tests/vaddr-kunit.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)mm/damon/tests/vaddr-kunit.h +1
-1@@ -66,7 +66,7 @@ static int __link_vmas(struct maple_tree *mt, struct vm_area_struct *vmas,static void damon_test_three_regions_in_vmas (struct kunit *test) {static struct mm_struct mm; -struct damon_addr_range regions[3 ] = {0 ,}; +struct damon_addr_range regions[3 ] = {0 };/* 10-20-25, 200-210-220, 300-305, 307-330 */ struct vm_area_struct vmas[] = { (struct vm_area_struct ) {.vm_start =10 , .vm_end =20 },Signature · 1 line
2.43.0
PATCH v2 1/1 mm/damon: fix sparse warning for zero initializer
sparse warns about zero initializing an array with {0,}, change it to the equivalent {0}.
Fixes the sparse warning:mm/damon/tests/vaddr-kunit.h:69:47: warning: missing braces around initializer
---
v2: Added fixes tag. Thank you!
--- mm/damon/tests/vaddr-kunit.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
mm/damon/tests/vaddr-kunit.h +1 -1
@@ -66,7 +66,7 @@ static int __link_vmas(struct maple_tree *mt, struct vm_area_struct *vmas,static void damon_test_three_regions_in_vmas (struct kunit *test) {static struct mm_struct mm; -struct damon_addr_range regions[3 ] = {0 ,}; +struct damon_addr_range regions[3 ] = {0 };/* 10-20-25, 200-210-220, 300-305, 307-330 */ struct vm_area_struct vmas[] = { (struct vm_area_struct ) {.vm_start =10 , .vm_end =20 },
--
2.43.0