Skip to contentSkip to conversation

bpftool: Remove llvm-strip from Makefile

PATCH Applied Tao Chen 4 participants 5 messages Sep 24, 2024 – Sep 25, 2024

Subsystems (2)
lore
Share & tools
lore

Tao Chen

author
#0 lore raw

PATCH 1/1 bpftool: Remove llvm-strip from Makefile

As Quentin and Andrri said [0], bpftool gen object strips out DWARF already, so remove the repeat operation.

[0] https://github.com/libbpf/bpftool/issues/161

---
 tools/bpf/bpftool/Makefile | 1 -
 1 file changed, 1 deletion(-)
tools/bpf/bpftool/Makefile +0 -1
index ba927379eb20..43bd826b0879 100644
@@ -219,7 +219,6 @@ $(OUTPUT)%.bpf.o: skeleton/%.bpf.c $(OUTPUT)vmlinux.h $(LIBBPF_BOOTSTRAP)
 		-I$(LIBBPF_BOOTSTRAP_INCLUDE) \
 		-g -O2 -Wall -fno-stack-protector \
 		--target=bpf -c $< -o $@
-	$(Q)$(LLVM_STRIP) -g $@
 
 $(OUTPUT)%.skel.h: $(OUTPUT)%.bpf.o $(BPFTOOL_BOOTSTRAP)
 	$(QUIET_GEN)$(BPFTOOL_BOOTSTRAP) gen skeleton $< > $@
Signature · 1 line
2.25.1
maintainer Acked-by on v1 1/1
#1 lore raw

2024-09-25 00:52 UTC+0800 ~ Tao Chen <[email protected]>

Quoted 8 lines

As Quentin and Andrri said [0], bpftool gen object strips out DWARF already, so remove the repeat operation.

[0] https://github.com/libbpf/bpftool/issues/161

Thank you!

#2 lore raw
In reply to Tao Chen
This patch was applied to bpf/bpf-next.git (master) by Daniel Borkmann <[email protected]>:

Hello:

This patch was applied to bpf/bpf-next.git (master) by Daniel Borkmann <[email protected]>:

Quoted 10 lines · On Wed, 25 Sep 2024 00:52:02 +0800 you wrote:

As Quentin and Andrri said [0], bpftool gen object strips out DWARF already, so remove the repeat operation.

[0] https://github.com/libbpf/bpftool/issues/161

[...]

Here is the summary with links:
- [bpf-next] bpftool: Remove llvm-strip from Makefile

    https://git.kernel.org/bpf/bpf-next/c/25bfc6333e32

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
maintainer
#3 lore raw
Quoted 16 lines · On 9/25/24 11:50 AM, [email protected] wrote:

Hello:

This patch was applied to bpf/bpf-next.git (master) by Daniel Borkmann <[email protected]>:

Quoted 10 lines · On Wed, 25 Sep 2024 00:52:02 +0800 you wrote:

As Quentin and Andrri said [0], bpftool gen object strips out DWARF already, so remove the repeat operation.

[0] https://github.com/libbpf/bpftool/issues/161

[...]

I'll toss this shortly from the tree again, this missed that bpftool gen object call needs to strip out dwarf.

Quoted 5 lines
Quoted 5 lines

Here is the summary with links:
- [bpf-next] bpftool: Remove llvm-strip from Makefile

     https://git.kernel.org/bpf/bpf-next/c/25bfc6333e32

You are awesome, thank you!

author
#4 lore raw
Quoted 12 lines · Daniel Borkmann
Quoted 11 lines · On 9/25/24 11:50 AM, [email protected] wrote:

Hello:

This patch was applied to bpf/bpf-next.git (master) by Daniel Borkmann <[email protected]>:

Quoted 5 lines · On Wed, 25 Sep 2024 00:52:02 +0800 you wrote:

As Quentin and Andrri said [0], bpftool gen object strips out DWARF already, so remove the repeat operation.

[0] https://github.com/libbpf/bpftool/issues/161

Quoted 7 lines
Quoted 5 lines
Quoted 5 lines

[...]

I'll toss this shortly from the tree again, this missed that bpftool gen object call needs to strip out dwarf.

Hi Daniel, i saw linker_sanity_check_elf will ignore the dwarf sec, which means bpftool gen object will strip, is my understanding correct?

static int linker_sanity_check_elf(struct src_obj *obj)

{
	...
	if (is_dwarf_sec_name(sec->sec_name))
		continue;
	...
}
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines

Here is the summary with links:
   - [bpf-next] bpftool: Remove llvm-strip from Makefile
     https://git.kernel.org/bpf/bpf-next/c/25bfc6333e32

You are awesome, thank you!

Signature · 2 lines
Best Regards
Dylane Chen