Skip to contentSkip to conversation

dt-bindings: gpio: ep9301: Add missing "#interrupt-cells" to examples

PATCH In review Rob Herring (Arm) 3 participants 3 messages Sep 25, 2024 – Sep 26, 2024

Subsystems (2)
lore
Share & tools
lore

Rob Herring (Arm)

author maintainer
#0 lore raw

PATCH 1/1 dt-bindings: gpio: ep9301: Add missing "#interrupt-cells" to examples

From: Rob Herring <[email protected]>

Enabling dtc interrupt_provider check reveals the examples are missing the "#interrupt-cells" property as it is a dependency of "interrupt-controller".

Some of the indentation is off, so fix that too.

---
 Documentation/devicetree/bindings/gpio/gpio-ep9301.yaml | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)
Documentation/devicetree/bindings/gpio/gpio-ep9301.yaml +6 -3
index daadfb4926c3..3a1079d6ee20 100644
@@ -73,9 +73,10 @@ examples:
       reg-names = "data", "dir", "intr";
       gpio-controller;
       #gpio-cells = <2>;
-        interrupt-controller;
-        interrupt-parent = <&vic1>;
-        interrupts = <27>;
+      interrupt-controller;
+      #interrupt-cells = <2>;
+      interrupt-parent = <&vic1>;
+      interrupts = <27>;
     };
 
     gpio@80840004 {
@@ -87,6 +88,7 @@ examples:
       gpio-controller;
       #gpio-cells = <2>;
       interrupt-controller;
+      #interrupt-cells = <2>;
       interrupt-parent = <&vic1>;
       interrupts = <27>;
     };
@@ -127,6 +129,7 @@ examples:
       gpio-controller;
       #gpio-cells = <2>;
       interrupt-controller;
+      #interrupt-cells = <2>;
       interrupts-extended = <&vic0 19>, <&vic0 20>,
                             <&vic0 21>, <&vic0 22>,
                             <&vic1 15>, <&vic1 16>,
Signature · 1 line
2.45.2
Reviewed-by on v1 1/1
#1 lore raw

Hi Rob!

Thank you!

Quoted 50 lines · Rob Herring (Arm)

From: Rob Herring <[email protected]>

Enabling dtc interrupt_provider check reveals the examples are missing
the "#interrupt-cells" property as it is a dependency of "interrupt-controller".

Some of the indentation is off, so fix that too.

---
 Documentation/devicetree/bindings/gpio/gpio-ep9301.yaml | 9 ++++++-- -

 1 file changed, 6 insertions(+), 3 deletions(-)
Documentation/devicetree/bindings/gpio/gpio-ep9301.yaml +4 -3
index daadfb4926c3..3a1079d6ee20 100644
@@ -73,9 +73,10 @@ examples:
        reg-names = "data", "dir", "intr";
        gpio-controller;
        #gpio-cells = <2>;
-        interrupt-controller;
-        interrupt-parent = <&vic1>;
-        interrupts = <27>;
+      interrupt-controller;
+      #interrupt-cells = <2>;
+      interrupt-parent = <&vic1>;
+      interrupts = <27>;
      };


     gpio@80840004 {

Documentation/devicetree/bindings/gpio/gpio-ep9301.yaml +2 -0
@@ -87,6 +88,7 @@ examples:
        gpio-controller;
        #gpio-cells = <2>;
        interrupt-controller;
+      #interrupt-cells = <2>;
        interrupt-parent = <&vic1>;
        interrupts = <27>;
      };
@@ -127,6 +129,7 @@ examples:
        gpio-controller;
        #gpio-cells = <2>;
        interrupt-controller;
+      #interrupt-cells = <2>;
        interrupts-extended = <&vic0 19>, <&vic0 20>,
                              <&vic0 21>, <&vic0 22>,
                              <&vic1 15>, <&vic1 16>,
Acked-by on v1 1/1
#2 lore raw
In reply to Rob Herring (Arm)
Quoted 9 lines · Rob Herring (Arm)

From: Rob Herring <[email protected]>

Enabling dtc interrupt_provider check reveals the examples are missing the "#interrupt-cells" property as it is a dependency of "interrupt-controller".

Some of the indentation is off, so fix that too.

Quoted 41 lines
---
 Documentation/devicetree/bindings/gpio/gpio-ep9301.yaml | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)
Documentation/devicetree/bindings/gpio/gpio-ep9301.yaml +6 -3
index daadfb4926c3..3a1079d6ee20 100644
@@ -73,9 +73,10 @@ examples:
       reg-names = "data", "dir", "intr";
       gpio-controller;
       #gpio-cells = <2>;
-        interrupt-controller;
-        interrupt-parent = <&vic1>;
-        interrupts = <27>;
+      interrupt-controller;
+      #interrupt-cells = <2>;
+      interrupt-parent = <&vic1>;
+      interrupts = <27>;
     };
 
     gpio@80840004 {
@@ -87,6 +88,7 @@ examples:
       gpio-controller;
       #gpio-cells = <2>;
       interrupt-controller;
+      #interrupt-cells = <2>;
       interrupt-parent = <&vic1>;
       interrupts = <27>;
     };
@@ -127,6 +129,7 @@ examples:
       gpio-controller;
       #gpio-cells = <2>;
       interrupt-controller;
+      #interrupt-cells = <2>;
       interrupts-extended = <&vic0 19>, <&vic0 20>,
                             <&vic0 21>, <&vic0 22>,
                             <&vic1 15>, <&vic1 16>,
Signature · 1 line
2.45.2