Skip to contentSkip to conversation

vfio/pci: fix potential memory leak in vfio_intx_enable()

PATCH New Oleksandr Tymoshenko 1 participant 1 message Sep 27, 2024 Stable branch

lore
Share & tools
lore

Oleksandr Tymoshenko

author
#0 lore raw

PATCH 1/1 vfio/pci: fix potential memory leak in vfio_intx_enable()

From: Ye Bin <[email protected]>

[ Upstream commit 82b951e6fbd31d85ae7f4feb5f00ddd4c5d256e2 ]

If kzalloc() failed will lead to 'name' memory leak.

Fixes 18c198c96a81 ("vfio/pci: Create persistent INTx handler")
Signed-off-by Ye Bin <[email protected]>
Reviewed-by Kevin Tian <[email protected]>
Acked-by Reinette Chatre <[email protected]>
Link https://lore.kernel.org/r/[email protected] open here
Signed-off-by Alex Williamson <[email protected]>
Signed-off-by Sasha Levin <[email protected]>
Signed-off-by Oleksandr Tymoshenko <[email protected]>
---
 drivers/vfio/pci/vfio_pci_intrs.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/vfio/pci/vfio_pci_intrs.c +3 -1
index 03246a59b553..5cbcde32ff79 100644
@@ -215,8 +215,10 @@ static int vfio_intx_enable(struct vfio_pci_core_device *vdev,
 		return -ENOMEM;
 
 	vdev->ctx = kzalloc(sizeof(struct vfio_pci_irq_ctx), GFP_KERNEL_ACCOUNT);
-	if (!vdev->ctx)
+	if (!vdev->ctx) {
+		kfree(name);
 		return -ENOMEM;
+	}
 
 	vdev->num_ctx = 1;
Signature · 1 line
2.46.1.824.gd892dcdcdd-goog