gpio: sysfs: make the sysfs export behavior consistent
RFC PATCH v2 1/1 gpio: sysfs: make the sysfs export behavior consistent
From: Bartosz Golaszewski <[email protected]>
For drivers or board files that set gpio_chip->names, the links to the GPIO attribute group created on sysfs export will be named after the line's name set in that array. For lines that are named using device properties, the names pointer of the gpio_chip struct is never assigned so they are exported as if they're not named.
The ABI documentation does not mention the former behavior and given that the majority of modern systems use device-tree, ACPI or other way of passing GPIO names using device properties - bypassing gc->names - it's better to make the behavior consistent by always exporting lines as "gpioXYZ".
---
v1 -> v2:
- remove the no longer needed ioname variable
drivers/gpio/gpiolib-sysfs.c | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-)
drivers/gpio/gpiolib-sysfs.c +2 -8
@@ -573,11 +573,10 @@ static struct class gpio_class = {*/ int gpiod_export (struct gpio_desc *desc,bool direction_may_change) { -const char *ioname =NULL ;struct gpio_device *gdev;struct gpiod_data *data;struct device *dev; -int status, offset; +int status;/* can't export until sysfs is available ... */ if (!class_is_registered (&gpio_class)) {
@@ -626,14 +625,9 @@ int gpiod_export(struct gpio_desc *desc, bool direction_may_change)else data->direction_can_change = false; - offset =gpio_chip_hwgpio (desc); -if (guard.gc->names && guard.gc->names[offset]) - ioname = guard.gc->names[offset]; - dev =device_create_with_groups (&gpio_class, &gdev->dev,MKDEV (0 ,0 ), data, gpio_groups, - ioname ? ioname :"gpio%u" , -desc_to_gpio (desc)); +"gpio%u" ,desc_to_gpio (desc));if (IS_ERR (dev)) { status =PTR_ERR (dev); goto err_free_data;
Signature · 1 line
2.43.0
Bartosz Golaszewski
AppliedFrom: Bartosz Golaszewski <[email protected]>
Quoted 6 lines · Bartosz Golaszewski
For drivers or board files that set
gpio_chip->names, the links to the GPIO attribute group created on sysfs export will be named after the line's name set in that array. For lines that are named using device properties, the names pointer of thegpio_chipstruct is never assigned so they are exported as if they're not named.
Quoted 7 lines
The ABI documentation does not mention the former behavior and given that the majority of modern systems use device-tree, ACPI or other way of passing GPIO names using device properties - bypassing
gc->names- it's better to make the behavior consistent by always exporting lines as "gpioXYZ".[...]
Applied, thanks!
[1/1] gpio: sysfs: make the sysfs export behavior consistent
commit: 700cdf7ed00f0cf20fdcef33d56e862768eb1008
Best regards,
Signature · 1 line
Bartosz Golaszewski <[email protected]>