Skip to contentSkip to conversation

uvc: Add support for Quanta ACER HD User Facing Camera (0408:4033)

PATCH In review Takshak Mudgal 3 participants 3 messages Sep 30, 2024

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 uvc: Add support for Quanta ACER HD User Facing Camera (0408:4033)

This patch adds support for the Quanta ACER HD User Facing Camera with USB ID 0408:4033, which is found in some Acer Nitro 5 and Aspire 3 series laptops. The camera is UVC 1.1 compliant but requires explicit enumeration to function correctly.

---
 drivers/media/usb/uvc/uvc_driver.c | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)
drivers/media/usb/uvc/uvc_driver.c +18 -0
index f0febdc08..40db8a5f4 100644
@@ -2430,6 +2430,24 @@ static const struct uvc_device_info uvc_quirk_force_y8 = {
  * though they are compliant.
  */
 static const struct usb_device_id uvc_ids[] = {
+	/**
+	   * Fix for the problem with cameras on Acer Nitro 5 Series & Acer Aspire 3 Series.
+	   * 
+	   * Fix required for the camera here
+	   * Thanks for @Giuliano69 for providing the fix
+	  */
+	/* Quanta ACER HD User Facing 4033 - Experimental !! */
+	{ .match_flags 		= USB_DEVICE_ID_MATCH_DEVICE 
+		       		| USB_DEVICE_ID_MATCH_INT_INFO,
+	  .idVendor 		= 0x0408,
+	  .idProduct 		= 0x4033,
+	  .bInterfaceClass 	= USB_CLASS_VIDEO,
+	  .bInterfaceSubClass 	= 1,
+	  .bInterfaceProtocol 	= UVC_PC_PROTOCOL_15,
+	  .driver_info 		= (kernel_ulong_t)&(const struct uvc_device_info){
+		.uvc_version 	= 0x010a,
+	  } },
+	/* Fix end here */
 	/* Quanta ACER HD User Facing */
 	{ .match_flags		= USB_DEVICE_ID_MATCH_DEVICE
 				| USB_DEVICE_ID_MATCH_INT_INFO,
Signature · 1 line
2.46.2
#1 lore raw

Hi Takshak

There is already a patch for this under review:
https://lore.kernel.org/linux-media/[email protected]/

Will likely land in 6.13

Regards!

Quoted 44 lines · Takshak Mudgal

This patch adds support for the Quanta ACER HD User Facing Camera with USB ID 0408:4033, which is found in some Acer Nitro 5 and Aspire 3 series laptops. The camera is UVC 1.1 compliant but requires explicit enumeration to function correctly.

---
 drivers/media/usb/uvc/uvc_driver.c | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)
drivers/media/usb/uvc/uvc_driver.c +18 -1
index f0febdc08..40db8a5f4 100644
@@ -2430,6 +2430,24 @@ static const struct uvc_device_info uvc_quirk_force_y8 = {
  * though they are compliant.
  */
 static const struct usb_device_id uvc_ids[] = {
+       /**
+          * Fix for the problem with cameras on Acer Nitro 5 Series & Acer Aspire 3 Series.
+          *
+          * Fix required for the camera here
+          * Thanks for @Giuliano69 for providing the fix
+         */
+       /* Quanta ACER HD User Facing 4033 - Experimental !! */
+       { .match_flags          = USB_DEVICE_ID_MATCH_DEVICE
+                               | USB_DEVICE_ID_MATCH_INT_INFO,
+         .idVendor             = 0x0408,
+         .idProduct            = 0x4033,
+         .bInterfaceClass      = USB_CLASS_VIDEO,
+         .bInterfaceSubClass   = 1,
+         .bInterfaceProtocol   = UVC_PC_PROTOCOL_15,
+         .driver_info          = (kernel_ulong_t)&(const struct uvc_device_info){
+               .uvc_version    = 0x010a,
+         } },
+       /* Fix end here */
        /* Quanta ACER HD User Facing */
        { .match_flags          = USB_DEVICE_ID_MATCH_DEVICE
                                | USB_DEVICE_ID_MATCH_INT_INFO,
--

2.46.2

Signature · 1 line
Ricardo Ribalda
maintainer
#2 lore raw
Quoted 6 lines · Ricardo Ribalda

Hi Takshak

There is already a patch for this under review:
https://lore.kernel.org/linux-media/[email protected]/

Will likely land in 6.13

More than likely, I've sent a pull request already:
https://lore.kernel/org/r/[email protected]

Quoted 41 lines · Takshak Mudgal
Quoted 40 lines

This patch adds support for the Quanta ACER HD User Facing Camera with USB ID 0408:4033, which is found in some Acer Nitro 5 and Aspire 3 series laptops. The camera is UVC 1.1 compliant but requires explicit enumeration to function correctly.

---
 drivers/media/usb/uvc/uvc_driver.c | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)
drivers/media/usb/uvc/uvc_driver.c +18 -0
index f0febdc08..40db8a5f4 100644
@@ -2430,6 +2430,24 @@ static const struct uvc_device_info uvc_quirk_force_y8 = {
  * though they are compliant.
  */
 static const struct usb_device_id uvc_ids[] = {
+       /**
+          * Fix for the problem with cameras on Acer Nitro 5 Series & Acer Aspire 3 Series.
+          *
+          * Fix required for the camera here
+          * Thanks for @Giuliano69 for providing the fix
+         */
+       /* Quanta ACER HD User Facing 4033 - Experimental !! */
+       { .match_flags          = USB_DEVICE_ID_MATCH_DEVICE
+                               | USB_DEVICE_ID_MATCH_INT_INFO,
+         .idVendor             = 0x0408,
+         .idProduct            = 0x4033,
+         .bInterfaceClass      = USB_CLASS_VIDEO,
+         .bInterfaceSubClass   = 1,
+         .bInterfaceProtocol   = UVC_PC_PROTOCOL_15,
+         .driver_info          = (kernel_ulong_t)&(const struct uvc_device_info){
+               .uvc_version    = 0x010a,
+         } },
+       /* Fix end here */
        /* Quanta ACER HD User Facing */
        { .match_flags          = USB_DEVICE_ID_MATCH_DEVICE
                                | USB_DEVICE_ID_MATCH_INT_INFO,
Signature · 3 lines
Regards,

Laurent Pinchart