Skip to contentSkip to conversation

i2c: qcom-geni: Keep comment why interrupts start disabled

PATCH Applied Andi Shyti 1 participant 2 messages Oct 1, 2024 – Oct 2, 2024

Subsystems (3)
lore
Share & tools
lore

Andi Shyti

author maintainer
#0 lore raw

PATCH v2 1/1 i2c: qcom-geni: Keep comment why interrupts start disabled

From: Wolfram Sang <[email protected]>

The to-be-fixed commit rightfully reduced a race window, but also removed a comment which is still helpful after the fix. Bring the comment back.

---
Hi,

I'm resending this patch from Wolfram so that we don't lose it. All the changes in this v2 have been agreed during code review.

Here's the difference:
v1 -> v2:
- Reword the comment.
- Remove the Fixes tag.
- Add Bjorn's r-b.

 drivers/i2c/busses/i2c-qcom-geni.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/i2c/busses/i2c-qcom-geni.c +2 -0
index 212336f724a69..b48f25c58baa9 100644
@@ -818,6 +818,8 @@ static int geni_i2c_probe(struct platform_device *pdev)
 	init_completion(&gi2c->done);
 	spin_lock_init(&gi2c->lock);
 	platform_set_drvdata(pdev, gi2c);
+
+	/* Keep interrupts disabled initially to allow for low-power modes */
 	ret = devm_request_irq(dev, gi2c->irq, geni_i2c_irq, IRQF_NO_AUTOEN,
 			       dev_name(dev), gi2c);
 	if (ret) {
Signature · 1 line
2.45.2