Skip to contentSkip to conversation

hwmon: add missing REGMAP_I2C dependencies

PATCH Applied Javier Carrasco 2 participants 9 messages Oct 2, 2024 Hardware monitoring

lore
Share & tools
lore
#0 lore raw

cover hwmon: add missing REGMAP_I2C dependencies

The kernel test bot recently noticed a missing dependency on REGMAP_I2C for tmp513, and I have noticed that there are multiple Kconfig entries where that is missing too. First I checked mc34vr500 because I was working on it, and I sent a single patch to fix the missing dependency. But then I have found the same issue in some other entries, and this series attemps to fix them all.

It might be worth mentioning that multiple sensors are part of a larger MFD, and the dependency error is not reported by the compiler in those cases (REGMAP must be selected indirectly in those cases). I left them untouched.

---
Javier Carrasco (4):
hwmon: (adm9240) Add missing dependency on REGMAP_I2C
hwmon: (adt7470) Add missing dependency on REGMAP_I2C
hwmon: (ltc2991) Add missing dependency on REGMAP_I2C
hwmon: (max1668) Add missing dependency on REGMAP_I2C

 drivers/hwmon/Kconfig | 4 ++++
 1 file changed, 4 insertions(+)

---
base-commit: 77df9e4bb2224d8ffbddec04c333a9d7965dad6c
change-id: 20241002-hwmon-select-regmap-2048ef1d2463

Best regards,

Signature · 1 line
Javier Carrasco <[email protected]>
#1 lore raw

PATCH 1/4 hwmon: (adm9240) Add missing dependency on REGMAP_I2C

This driver requires REGMAP_I2C to be selected in order to get access to regmap_config and devm_regmap_init_i2c. Add the missing dependency.

Fixes df885d912f67 ("hwmon: (adm9240) Convert to regmap")
---
 drivers/hwmon/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/hwmon/Kconfig +1 -0
index ecf09cd2510c..f47f6a28d1c7 100644
@@ -162,6 +162,7 @@ config SENSORS_ADM9240
 	tristate "Analog Devices ADM9240 and compatibles"
 	depends on I2C
 	select HWMON_VID
+	select REGMAP_I2C
 	help
 	  If you say yes here you get support for Analog Devices ADM9240,
 	  Dallas DS1780, National Semiconductor LM81 sensor chips.
Signature · 1 line
2.43.0
maintainer Applied
#2 lore raw

Re: [PATCH 1/4] hwmon: (adm9240) Add missing dependency on REGMAP_I2C

Quoted 5 lines · Javier Carrasco

This driver requires REGMAP_I2C to be selected in order to get access to regmap_config and devm_regmap_init_i2c. Add the missing dependency.

Fixes df885d912f67 ("hwmon: (adm9240) Convert to regmap")

Applied.

Thanks,
Guenter

#3 lore raw

PATCH 2/4 hwmon: (adt7470) Add missing dependency on REGMAP_I2C

In reply to Javier Carrasco

This driver requires REGMAP_I2C to be selected in order to get access to regmap_config and devm_regmap_init_i2c. Add the missing dependency.

Fixes ef67959c4253 ("hwmon: (adt7470) Convert to use regmap")
---
 drivers/hwmon/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/hwmon/Kconfig +1 -0
index f47f6a28d1c7..d4a9440a5fca 100644
@@ -224,6 +224,7 @@ config SENSORS_ADT7462
 config SENSORS_ADT7470
 	tristate "Analog Devices ADT7470"
 	depends on I2C
+	select REGMAP_I2C
 	help
 	  If you say yes here you get support for the Analog Devices
 	  ADT7470 temperature monitoring chips.
Signature · 1 line
2.43.0
maintainer Applied
#4 lore raw

Re: [PATCH 2/4] hwmon: (adt7470) Add missing dependency on REGMAP_I2C

Quoted 5 lines · Javier Carrasco

This driver requires REGMAP_I2C to be selected in order to get access to regmap_config and devm_regmap_init_i2c. Add the missing dependency.

Fixes ef67959c4253 ("hwmon: (adt7470) Convert to use regmap")

Applied.

Thanks,
Guenter

#5 lore raw

PATCH 3/4 hwmon: (ltc2991) Add missing dependency on REGMAP_I2C

In reply to Javier Carrasco

This driver requires REGMAP_I2C to be selected in order to get access to regmap_config and devm_regmap_init_i2c. Add the missing dependency.

Fixes 2b9ea4262ae9 ("hwmon: Add driver for ltc2991")
---
 drivers/hwmon/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/hwmon/Kconfig +1 -0
index d4a9440a5fca..5152c71402ca 100644
@@ -1001,6 +1001,7 @@ config SENSORS_LTC2990
 config SENSORS_LTC2991
 	tristate "Analog Devices LTC2991"
 	depends on I2C
+	select REGMAP_I2C
 	help
 	  If you say yes here you get support for Analog Devices LTC2991
 	  Octal I2C Voltage, Current, and Temperature Monitor. The LTC2991
Signature · 1 line
2.43.0
maintainer Applied
#6 lore raw

Re: [PATCH 3/4] hwmon: (ltc2991) Add missing dependency on REGMAP_I2C

Quoted 5 lines · Javier Carrasco

This driver requires REGMAP_I2C to be selected in order to get access to regmap_config and devm_regmap_init_i2c. Add the missing dependency.

Fixes 2b9ea4262ae9 ("hwmon: Add driver for ltc2991")

Applied.

Thanks,
Guenter

#7 lore raw

PATCH 4/4 hwmon: (max1668) Add missing dependency on REGMAP_I2C

In reply to Javier Carrasco

This driver requires REGMAP_I2C to be selected in order to get access to regmap_config, regmap_bus, and devm_regmap_init_i2c.
Add the missing dependency.

Fixes 021730acbca6 ("hwmon: (max1668) Convert to use regmap")
---
 drivers/hwmon/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/hwmon/Kconfig +1 -0
index 5152c71402ca..92d051dba52f 100644
@@ -1149,6 +1149,7 @@ config SENSORS_MAX1619
 config SENSORS_MAX1668
 	tristate "Maxim MAX1668 and compatibles"
 	depends on I2C
+	select REGMAP_I2C
 	help
 	  If you say yes here you get support for MAX1668, MAX1989 and
 	  MAX1805 chips.
Signature · 1 line
2.43.0
maintainer Applied
#8 lore raw

Re: [PATCH 4/4] hwmon: (max1668) Add missing dependency on REGMAP_I2C

Quoted 6 lines · Javier Carrasco

This driver requires REGMAP_I2C to be selected in order to get access to regmap_config, regmap_bus, and devm_regmap_init_i2c.
Add the missing dependency.

Fixes 021730acbca6 ("hwmon: (max1668) Convert to use regmap")

Applied.

Thanks,
Guenter