Skip to contentSkip to conversation

PM: QoS: Export dev_pm_qos_read_value

PATCH In review Markus Schneider-Pargmann 4 participants 8 messages Oct 2, 2024 – Oct 25, 2024

Subsystems (4)
Driver core Suspend to RAM Hibernation Power management core
lore
Share & tools
lore

Markus Schneider-Pargmann

author
#0 lore raw

PATCH v2 1/1 PM: QoS: Export dev_pm_qos_read_value

Export the function dev_pm_qos_read_value(). Most other functions mentioned in Documentation/power/pm_qos_interface.rst are already exported, so export this one as well.

This function will be used to read the resume latency in a driver that can also be compiled as a module.

Signed-off-by Markus Schneider-Pargmann <[email protected]>
Reviewed-by Dhruva Gole <[email protected]>
Reviewed-by Kevin Hilman <[email protected]>
Tested-by Kevin Hilman <[email protected]>

---

Notes:
Changes in v2:
- Rephrase the commit message
- Move the patch out of the series
'firmware: ti_sci: Introduce system suspend support'

Previous versions:
ti_sci v12 https://lore.kernel.org/lkml/[email protected]/

 drivers/base/power/qos.c | 1 +
 1 file changed, 1 insertion(+)
drivers/base/power/qos.c +1 -0
index bd77f6734f14..ff393cba7649 100644
@@ -137,6 +137,7 @@ s32 dev_pm_qos_read_value(struct device *dev, enum dev_pm_qos_req_type type)
 
 	return ret;
 }
+EXPORT_SYMBOL_GPL(dev_pm_qos_read_value);
 
 /**
  * apply_constraint - Add/modify/remove device PM QoS request.
Signature · 1 line
2.45.2
maintainer
#1 lore raw
Quoted 6 lines · Markus Schneider-Pargmann

Export the function dev_pm_qos_read_value(). Most other functions mentioned in Documentation/power/pm_qos_interface.rst are already exported, so export this one as well.

This function will be used to read the resume latency in a driver that can also be compiled as a module.

We don't add exports for no in-kernel users, sorry. Send this as part of a series that requires it.

Quoted 11 lines
Signed-off-by Markus Schneider-Pargmann <[email protected]>
Reviewed-by Dhruva Gole <[email protected]>
Reviewed-by Kevin Hilman <[email protected]>
Tested-by Kevin Hilman <[email protected]>

---

Notes:
Changes in v2:
- Rephrase the commit message
- Move the patch out of the series
'firmware: ti_sci: Introduce system suspend support'

Odd, why did you do that?

thanks,

greg k-h

author
#2 lore raw
Quoted 10 lines · Greg Kroah-Hartman
Quoted 6 lines · Markus Schneider-Pargmann

Export the function dev_pm_qos_read_value(). Most other functions mentioned in Documentation/power/pm_qos_interface.rst are already exported, so export this one as well.

This function will be used to read the resume latency in a driver that can also be compiled as a module.

We don't add exports for no in-kernel users, sorry. Send this as part of a series that requires it.

Sorry if this was unclear, it is for an in-kernel driver (ti_sci.c) that can be built as a module. When built as a module it can't use this function if it is not exported.

Quoted 7 lines
Quoted 7 lines
Signed-off-by Markus Schneider-Pargmann <[email protected]>
Reviewed-by Dhruva Gole <[email protected]>
Reviewed-by Kevin Hilman <[email protected]>
Tested-by Kevin Hilman <[email protected]>

---

Quoted 7 lines
Quoted 5 lines

Notes:
Changes in v2:
- Rephrase the commit message
- Move the patch out of the series
'firmware: ti_sci: Introduce system suspend support'

Odd, why did you do that?

It was suggested to me off-list that it may be better or easier to send this separately.

Best
Markus

maintainer
#3 lore raw
Quoted 9 lines · Markus Schneider-Pargmann
Quoted 8 lines · Greg Kroah-Hartman
Quoted 6 lines · Markus Schneider-Pargmann

Export the function dev_pm_qos_read_value(). Most other functions mentioned in Documentation/power/pm_qos_interface.rst are already exported, so export this one as well.

This function will be used to read the resume latency in a driver that can also be compiled as a module.

Quoted 6 lines
Quoted 2 lines

We don't add exports for no in-kernel users, sorry. Send this as part of a series that requires it.

Sorry if this was unclear, it is for an in-kernel driver (ti_sci.c) that can be built as a module. When built as a module it can't use this function if it is not exported.

So the current kernel build is broken? If so, please add a "Fixes:" tag and say this in the changelog.

If not, again, just make it part of the series where it is needed.

thanks,

greg k-h

author
#4 lore raw
Quoted 13 lines · Greg Kroah-Hartman
Quoted 12 lines · Markus Schneider-Pargmann
Quoted 10 lines · Greg Kroah-Hartman
Quoted 6 lines · Markus Schneider-Pargmann

Export the function dev_pm_qos_read_value(). Most other functions mentioned in Documentation/power/pm_qos_interface.rst are already exported, so export this one as well.

This function will be used to read the resume latency in a driver that can also be compiled as a module.

We don't add exports for no in-kernel users, sorry. Send this as part of a series that requires it.

Quoted 8 lines
Quoted 3 lines

Sorry if this was unclear, it is for an in-kernel driver (ti_sci.c) that can be built as a module. When built as a module it can't use this function if it is not exported.

So the current kernel build is broken? If so, please add a "Fixes:" tag and say this in the changelog.

If not, again, just make it part of the series where it is needed.

It is not a fix, I will reintegrate it with the series that needs it.

Thanks!

Best
Markus

#5 lore raw
In reply to Greg Kroah-Hartman
Quoted 13 lines · Greg Kroah-Hartman
Quoted 12 lines · Markus Schneider-Pargmann
Quoted 10 lines · Greg Kroah-Hartman
Quoted 6 lines · Markus Schneider-Pargmann

Export the function dev_pm_qos_read_value(). Most other functions mentioned in Documentation/power/pm_qos_interface.rst are already exported, so export this one as well.

This function will be used to read the resume latency in a driver that can also be compiled as a module.

We don't add exports for no in-kernel users, sorry. Send this as part of a series that requires it.

Quoted 9 lines
Quoted 3 lines

Sorry if this was unclear, it is for an in-kernel driver (ti_sci.c) that can be built as a module. When built as a module it can't use this function if it is not exported.

So the current kernel build is broken? If so, please add a "Fixes:" tag and say this in the changelog.

If not, again, just make it part of the series where it is needed.

Greg, Rafael, How do you wish to route this patch in?

This patch is a dependency of [1] which goes through my tree. If you can provide an ack, I can pick up the patch through my tree, else we will end up with dependency issue here.

[1] https://lore.kernel.org/all/[email protected]/

Signature · 3 lines
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D
maintainer Acked-by
#6 lore raw
Quoted 25 lines · Nishanth Menon
Quoted 13 lines · Greg Kroah-Hartman
Quoted 12 lines · Markus Schneider-Pargmann
Quoted 10 lines · Greg Kroah-Hartman
Quoted 6 lines · Markus Schneider-Pargmann

Export the function dev_pm_qos_read_value(). Most other functions mentioned in Documentation/power/pm_qos_interface.rst are already exported, so export this one as well.

This function will be used to read the resume latency in a driver that can also be compiled as a module.

We don't add exports for no in-kernel users, sorry. Send this as part of a series that requires it.

Quoted 9 lines
Quoted 3 lines

Sorry if this was unclear, it is for an in-kernel driver (ti_sci.c) that can be built as a module. When built as a module it can't use this function if it is not exported.

So the current kernel build is broken? If so, please add a "Fixes:" tag and say this in the changelog.

If not, again, just make it part of the series where it is needed.

Quoted 7 lines

Greg, Rafael, How do you wish to route this patch in?

This patch is a dependency of [1] which goes through my tree. If you can provide an ack, I can pick up the patch through my tree, else we will end up with dependency issue here.

[1] https://lore.kernel.org/all/[email protected]/

Sure, please feel free to add

Acked-by Rafael J. Wysocki <[email protected]>

to it.

Thanks!

#7 lore raw

On 16:50-20241025, Rafael J. Wysocki wrote:
[...]

Quoted 8 lines
Quoted 7 lines

Greg, Rafael, How do you wish to route this patch in?

This patch is a dependency of [1] which goes through my tree. If you can provide an ack, I can pick up the patch through my tree, else we will end up with dependency issue here.

[1] https://lore.kernel.org/all/[email protected]/

Quoted 7 lines

Sure, please feel free to add

Acked-by Rafael J. Wysocki <[email protected]>

to it.

Thanks!

Thanks for the ack, will queue things up.

Signature · 3 lines
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D