mkfs.jffs2: fix segfault when parsing dev table
PATCH v2 1/1 mkfs.jffs2: fix segfault when parsing dev table
Make sure that the first item is parsed correctly. One issue otherwise is a null pointer dereference when the first item is not found.
--- jffsX-utils/mkfs.jffs2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
jffsX-utils/mkfs.jffs2.c +1 -1
@@ -428,7 +428,7 @@ static int interpret_table_entry(struct filesystem_entry *root, char *line)if (sscanf (line,"%" SCANF_PREFIX "s %c %lo %lu %lu %lu %lu %lu %lu %lu" ,SCANF_STRING (name), &type, &mode, &uid, &gid, &major, &minor, - &start, &increment, &count) <0 ) + &start, &increment, &count) <2 ) {return 1 ; }
Signature · 6 lines
2.46.2 ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/
Quoted 8 lines · Rosen Penev
Make sure that the first item is parsed correctly. One issue otherwise is a null pointer dereference when the first item is not found.
Signed-off-by Rosen Penev <[email protected]>--- jffsX-utils/mkfs.jffs2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 6 lines
jffsX-utils/mkfs.jffs2.c +0
-0
jffsX-utils/mkfs.jffs2.c static int interpret_table_entry(struct filesystem_entry *root, char *line) · line 434
Quoted 8 lines
jffsX-utils/mkfs.jffs2.c +1
-1@@ -428,7 +428,7 @@ static int interpret_table_entry(struct filesystem_entry *root, char *line)if (sscanf (line,"%" SCANF_PREFIX "s %c %lo %lu %lu %lu %lu %lu %lu %lu" ,SCANF_STRING (name), &type, &mode, &uid, &gid, &major, &minor, - &start, &increment, &count) <0 ) + &start, &increment, &count) <2 ) {return 1 ; }
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
David Oberhollenzer
AppliedApplied to mtd-utils.git master.
Thanks,
David
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/