bcachefs: Fix NULL pointer dereference in bch2_opt_to_text
PATCH v3 1/1 bcachefs: Fix NULL pointer dereference in bch2_opt_to_text
This patch adds a bounds check to the bch2_opt_to_text function to prevent NULL pointer dereferences when accessing the opt->choices array. This ensures that the index used is within valid bounds before dereferencing. The new version enhances the readability.
Reported-and-tested-by [email protected]
Signed-off-by Mohammed Anees <[email protected]>
---
v3:
- Moved bounds check above as default case.
- Removed the nested if clauses.
fs/bcachefs/opts.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletions(-)
fs/bcachefs/opts.c +3 -1
@@ -418,7 +418,9 @@ void bch2_opt_to_text(struct printbuf *out,prt_printf (out,"%lli" , v);break ;case BCH_OPT_STR : -if (flags &OPT_SHOW_FULL_LIST ) +if (v < opt->min || v >= opt->max -1 ) +prt_printf (out,"(invalid option %lli)" , v); +else if (flags &OPT_SHOW_FULL_LIST )prt_string_option (out, opt->choices, v);else prt_str (out, opt->choices[v]);
2.46.0
Hi hope you are well. I am following up on this patch, I would appreciate any feedback or comments on the patch when you have the time.
Thanks!