Skip to contentSkip to conversation

brcmfmac: Remove unused brcmf_cfg80211_get_iftype

PATCH In review [email protected] 2 participants 2 messages Oct 4, 2024 – Oct 17, 2024 Broadcom BRCM80211 IEEE802.11 wireless drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 brcmfmac: Remove unused brcmf_cfg80211_get_iftype

From: "Dr. David Alan Gilbert" <[email protected]>

brcmf_cfg80211_get_iftype() has been unused since 2013's commit 5cd51c2bad56 ("brcmfmac: Find correct MAC descriptor in case of TDLS.")

Remove it.

---
 .../net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c    | 7 -------
 .../net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.h    | 1 -
 2 files changed, 8 deletions(-)
drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c +0 -7
index 349aa3439502..297a7c738c01 100644
@@ -7820,13 +7820,6 @@ s32 brcmf_cfg80211_down(struct net_device *ndev)
 	return err;
 }
 
-enum nl80211_iftype brcmf_cfg80211_get_iftype(struct brcmf_if *ifp)
-{
-	struct wireless_dev *wdev = &ifp->vif->wdev;
-
-	return wdev->iftype;
-}
-
 bool brcmf_get_vif_state_any(struct brcmf_cfg80211_info *cfg,
 			     unsigned long state)
 {
drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.h +0 -1
index dc3a6a537507..2abae8894614 100644
@@ -443,7 +443,6 @@ void brcmf_cfg80211_detach(struct brcmf_cfg80211_info *cfg);
 s32 brcmf_cfg80211_up(struct net_device *ndev);
 s32 brcmf_cfg80211_down(struct net_device *ndev);
 struct cfg80211_ops *brcmf_cfg80211_get_ops(struct brcmf_mp_device *settings);
-enum nl80211_iftype brcmf_cfg80211_get_iftype(struct brcmf_if *ifp);
 
 struct brcmf_cfg80211_vif *brcmf_alloc_vif(struct brcmf_cfg80211_info *cfg,
 					   enum nl80211_iftype type);
Signature · 1 line
2.46.2
#1 lore raw

Re: wifi: brcmfmac: Remove unused brcmf_cfg80211_get_iftype()

Quoted 8 lines · [email protected] wrote:

From: "Dr. David Alan Gilbert" <[email protected]>

brcmf_cfg80211_get_iftype() has been unused since 2013's commit 5cd51c2bad56 ("brcmfmac: Find correct MAC descriptor in case of TDLS.")

Remove it.

Patch applied to wireless-next.git, thanks.

e2e25113473b wifi: brcmfmac: Remove unused brcmf_cfg80211_get_iftype()

Signature · 3 lines
https://patchwork.kernel.org/project/linux-wireless/patch/[email protected]/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches