Skip to contentSkip to conversation

New: drivers/iio/imu/adis16400.o: warning: objtool: adis16400_write_raw() falls through to next function adis16400_show_flash_count()

Bug 219192 [email protected] 2 participants 24 messages Aug 25, 2024 – Mar 17 IIO

lore
Share & tools
lore
#0 lore raw

https://bugzilla.kernel.org/show_bug.cgi?id=219192

            Bug ID: 219192
           Summary: drivers/iio/imu/adis16400.o: warning: objtool:
                    adis16400_write_raw() falls through to next function
                    adis16400_show_flash_count()
           Product: Drivers
           Version: 2.5
          Hardware: All
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: P3
         Component: IIO
          Assignee: [email protected]
          Reporter: [email protected]
        Regression: No

drivers/iio/imu/adis16400.o: warning: objtool: adis16400_write_raw() falls through to next function adis16400_show_flash_count()

Kernel: 6.11.0-rc5 vanilla
GCC compiler: gcc (Debian 14.1.0-5) 14.1.0

Signature · 4 lines
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.
#1 lore raw

[Bug 219192] drivers/iio/imu/adis16400.o: warning: objtool: adis16400_write_raw() falls through to next function adis16400_show_flash_count()

https://bugzilla.kernel.org/show_bug.cgi?id=219192

sander44 ([email protected]) changed:

What |Removed |Added
----------------------------------------------------------------------------
Kernel Version| |6.11.0-rc5

Signature · 4 lines
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.
maintainer
#2 lore raw
In reply to [email protected]
Quoted 18 lines · On Sun, 25 Aug 2024 09:35:37 +0000 [email protected] wrote:

https://bugzilla.kernel.org/show_bug.cgi?id=219192

            Bug ID: 219192
           Summary: drivers/iio/imu/adis16400.o: warning: objtool:
                    adis16400_write_raw() falls through to next function
                    adis16400_show_flash_count()
           Product: Drivers
           Version: 2.5
          Hardware: All
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: P3
         Component: IIO
          Assignee: [email protected]
          Reporter: [email protected]
        Regression: No
Quoted 5 lines

drivers/iio/imu/adis16400.o: warning: objtool: adis16400_write_raw() falls through to next function adis16400_show_flash_count()

Kernel: 6.11.0-rc5 vanilla
GCC compiler: gcc (Debian 14.1.0-5) 14.1.0

I think this is a false positive. None of the cases of the switch statement fail to return and there are unreachable() markings that this check seems to not be able to see which were added to try and point out to the compiler that it was failing to identify they were not possible to get to.

We could add some returns the unreachable paths to work around this warning I suppose.

Maybe we are doing something wrong otherwise? I'd like more eyes on this incase I'm just missing something obvious.

Jonathan

Quoted 1 line
#3 lore raw

[Bug 219192] drivers/iio/imu/adis16400.o: warning: objtool: adis16400_write_raw() falls through to next function adis16400_show_flash_count()

In reply to [email protected]

https://bugzilla.kernel.org/show_bug.cgi?id=219192

--- Comment #1 from Jonathan Cameron ([email protected]) ---

Quoted 18 lines · On Sun, 25 Aug 2024 09:35:37 +0000 [email protected] wrote:

https://bugzilla.kernel.org/show_bug.cgi?id=219192

            Bug ID: 219192
           Summary: drivers/iio/imu/adis16400.o: warning: objtool:
                    adis16400_write_raw() falls through to next function
                    adis16400_show_flash_count()
           Product: Drivers
           Version: 2.5
          Hardware: All
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: P3
         Component: IIO
          Assignee: [email protected]
          Reporter: [email protected]
        Regression: No
Quoted 5 lines

drivers/iio/imu/adis16400.o: warning: objtool: adis16400_write_raw() falls through to next function adis16400_show_flash_count()

Kernel: 6.11.0-rc5 vanilla
GCC compiler: gcc (Debian 14.1.0-5) 14.1.0

I think this is a false positive. None of the cases of the switch statement fail to return and there are unreachable() markings that this check seems to not be able to see which were added to try and point out to the compiler that it was failing to identify they were not possible to get to.

We could add some returns the unreachable paths to work around this warning I suppose.

Maybe we are doing something wrong otherwise? I'd like more eyes on this incase I'm just missing something obvious.

Jonathan

Quoted 1 line
Signature · 4 lines
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.
#4 lore raw

[Bug 219192] drivers/iio/imu/adis16400.o: warning: objtool: adis16400_write_raw() falls through to next function adis16400_show_flash_count()

In reply to [email protected]

https://bugzilla.kernel.org/show_bug.cgi?id=219192

Andy Shevchenko ([email protected]) changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |[email protected]

--- Comment #2 from Andy Shevchenko ([email protected]) --- Might be related (read discussion in full):
https://lore.kernel.org/platform-driver-x86/[email protected]/.

Signature · 4 lines
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.
maintainer
#5 lore raw

Re: [Bug 219192] drivers/iio/imu/adis16400.o: warning: objtool: adis16400_write_raw() falls through to next function adis16400_show_flash_count()

Quoted 4 lines · On Mon, 09 Sep 2024 14:31:02 +0000 [email protected] wrote:

https://bugzilla.kernel.org/show_bug.cgi?id=219192

Andy Shevchenko ([email protected]) changed:

Quoted 8 lines

What |Removed |Added
----------------------------------------------------------------------------
CC| |[email protected]

--- Comment #2 from Andy Shevchenko ([email protected]) --- Might be related (read discussion in full):
https://lore.kernel.org/platform-driver-x86/[email protected]/.

Thanks.
https://lore.kernel.org/platform-driver-x86/20240906031601.4yodvhurcyi26qb2@treble/
Looks like the relevant info. So current view from Josh seems to be that it's a clang bug. Interesting to see if that holds up if reported to clang folk (or if there is undefined behaviour none of us are seeing!)

Jonathan

#6 lore raw

[Bug 219192] drivers/iio/imu/adis16400.o: warning: objtool: adis16400_write_raw() falls through to next function adis16400_show_flash_count()

In reply to [email protected]

https://bugzilla.kernel.org/show_bug.cgi?id=219192

--- Comment #3 from Jonathan Cameron ([email protected]) ---

Quoted 4 lines · On Mon, 09 Sep 2024 14:31:02 +0000 [email protected] wrote:

https://bugzilla.kernel.org/show_bug.cgi?id=219192

Andy Shevchenko ([email protected]) changed:

Quoted 9 lines

What |Removed |Added
----------------------------------------------------------------------------
CC| |[email protected]

--- Comment #2 from Andy Shevchenko ([email protected]) --- Might be related (read discussion in full):

https://lore.kernel.org/platform-driver-x86/[email protected]/.

Thanks.
https://lore.kernel.org/platform-driver-x86/20240906031601.4yodvhurcyi26qb2@treble/
Looks like the relevant info. So current view from Josh seems to be that it's a clang bug. Interesting to see if that holds up if reported to clang folk (or if there is undefined behaviour none of us are seeing!)

Jonathan

Signature · 4 lines
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.
#7 lore raw

[Bug 219192] drivers/iio/imu/adis16400.o: warning: objtool: adis16400_write_raw() falls through to next function adis16400_show_flash_count()

In reply to [email protected]

https://bugzilla.kernel.org/show_bug.cgi?id=219192

--- Comment #4 from Andy Shevchenko ([email protected]) --- ...with the difference that here it's GCC...

Signature · 4 lines
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.
maintainer
#8 lore raw

Re: [Bug 219192] drivers/iio/imu/adis16400.o: warning: objtool: adis16400_write_raw() falls through to next function adis16400_show_flash_count()

Quoted 4 lines · On Tue, 10 Sep 2024 05:42:56 +0000 [email protected] wrote:

https://bugzilla.kernel.org/show_bug.cgi?id=219192

--- Comment #4 from Andy Shevchenko ([email protected]) --- ...with the difference that here it's GCC...

Good point!

So might be something completely different :(

Jonathan

Quoted 1 line
#9 lore raw

[Bug 219192] drivers/iio/imu/adis16400.o: warning: objtool: adis16400_write_raw() falls through to next function adis16400_show_flash_count()

In reply to [email protected]

https://bugzilla.kernel.org/show_bug.cgi?id=219192

--- Comment #5 from Jonathan Cameron ([email protected]) ---

Quoted 4 lines · On Tue, 10 Sep 2024 05:42:56 +0000 [email protected] wrote:

https://bugzilla.kernel.org/show_bug.cgi?id=219192

--- Comment #4 from Andy Shevchenko ([email protected]) --- ...with the difference that here it's GCC...

Good point!

So might be something completely different :(

Jonathan

Quoted 1 line
Signature · 4 lines
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.
#10 lore raw

[Bug 219192] drivers/iio/imu/adis16400.o: warning: objtool: adis16400_write_raw() falls through to next function adis16400_show_flash_count()

In reply to [email protected]

https://bugzilla.kernel.org/show_bug.cgi?id=219192

--- Comment #6 from Tudor Gheorghiu ([email protected]) --- I saw this bugreport and I must say I encountered a somewhat similar but not quite the same warning message from objtool when compiling with clang.

This is my environment:
Linux version 6.12.0-rc1+ (Ubuntu clang version 18.1.3 (1ubuntu1), Ubuntu LLD 18.1.3)

This is the objtool warning:

Quoted 2 lines

drivers/iio/imu/adis16400.o: warning: objtool: adis16400_write_raw+0x89:
can't find jump dest instruction at .text+0x8be

I dissasembled the binary and this is what I found at that offset:

Quoted 7 lines
   0x0000000000000781 <+113>: jmp    0x8a4 <adis16400_write_raw+404>
   0x0000000000000786 <+118>: mov    %rdi,%r12
   0x0000000000000789 <+121>: lea    0x30(%r14),%rdi
   0x000000000000078d <+125>: call   0x792 <adis16400_write_raw+130>
   0x0000000000000792 <+130>: mov    %r14,%rbx
   0x0000000000000795 <+133>: add    $0x30,%rbx
   0x0000000000000799 <+137>: je     0x8be

Looking at .text+0x8be:

Quoted 5 lines

(gdb) x/4i 0x00000000000008be+0x8be

   0x117c <adis16300_channels+1180>:  add    %al,(%rax)
   0x117e <adis16300_channels+1182>:  add    %al,(%rax)
   0x1180 <adis16300_channels+1184>:  add    $0x0,%al
   0x1182 <adis16300_channels+1186>:  add    %al,(%rax)

I cannot tell if this is an actual issue, or just a false positive, but I decided to post my findings here nevertheless.

Signature · 4 lines
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.
maintainer
#11 lore raw

Re: [Bug 219192] drivers/iio/imu/adis16400.o: warning: objtool: adis16400_write_raw() falls through to next function adis16400_show_flash_count()

Quoted 25 lines · On Wed, 02 Oct 2024 21:24:56 +0000 [email protected] wrote:

https://bugzilla.kernel.org/show_bug.cgi?id=219192

--- Comment #6 from Tudor Gheorghiu ([email protected]) --- I saw this bugreport and I must say I encountered a somewhat similar but not quite the same warning message from objtool when compiling with clang.

This is my environment:
Linux version 6.12.0-rc1+ (Ubuntu clang version 18.1.3 (1ubuntu1), Ubuntu LLD 18.1.3)

This is the objtool warning:

Quoted 2 lines

drivers/iio/imu/adis16400.o: warning: objtool: adis16400_write_raw+0x89:
can't find jump dest instruction at .text+0x8be

I dissasembled the binary and this is what I found at that offset:

Quoted 7 lines
   0x0000000000000781 <+113>: jmp    0x8a4 <adis16400_write_raw+404>
   0x0000000000000786 <+118>: mov    %rdi,%r12
   0x0000000000000789 <+121>: lea    0x30(%r14),%rdi
   0x000000000000078d <+125>: call   0x792 <adis16400_write_raw+130>
   0x0000000000000792 <+130>: mov    %r14,%rbx
   0x0000000000000795 <+133>: add    $0x30,%rbx
   0x0000000000000799 <+137>: je     0x8be  

Looking at .text+0x8be:

Quoted 9 lines
Quoted 5 lines

(gdb) x/4i 0x00000000000008be+0x8be

   0x117c <adis16300_channels+1180>:  add    %al,(%rax)
   0x117e <adis16300_channels+1182>:  add    %al,(%rax)
   0x1180 <adis16300_channels+1184>:  add    $0x0,%al
   0x1182 <adis16300_channels+1186>:  add    %al,(%rax)  

I cannot tell if this is an actual issue, or just a false positive, but I decided to post my findings here nevertheless.

So far no one has been able to identify an actual problem, so I'm treating this a false positive that will eventually get fixed from the compiler side. Or someone will explain what the issue in the code is.

Jonathan

#12 lore raw

[Bug 219192] drivers/iio/imu/adis16400.o: warning: objtool: adis16400_write_raw() falls through to next function adis16400_show_flash_count()

In reply to [email protected]

https://bugzilla.kernel.org/show_bug.cgi?id=219192

--- Comment #7 from Jonathan Cameron ([email protected]) ---

Quoted 25 lines · On Wed, 02 Oct 2024 21:24:56 +0000 [email protected] wrote:

https://bugzilla.kernel.org/show_bug.cgi?id=219192

--- Comment #6 from Tudor Gheorghiu ([email protected]) --- I saw this bugreport and I must say I encountered a somewhat similar but not quite the same warning message from objtool when compiling with clang.

This is my environment:
Linux version 6.12.0-rc1+ (Ubuntu clang version 18.1.3 (1ubuntu1), Ubuntu LLD 18.1.3)

This is the objtool warning:

Quoted 2 lines

drivers/iio/imu/adis16400.o: warning: objtool: adis16400_write_raw+0x89:
can't find jump dest instruction at .text+0x8be

I dissasembled the binary and this is what I found at that offset:

Quoted 7 lines
   0x0000000000000781 <+113>: jmp    0x8a4 <adis16400_write_raw+404>
   0x0000000000000786 <+118>: mov    %rdi,%r12
   0x0000000000000789 <+121>: lea    0x30(%r14),%rdi
   0x000000000000078d <+125>: call   0x792 <adis16400_write_raw+130>
   0x0000000000000792 <+130>: mov    %r14,%rbx
   0x0000000000000795 <+133>: add    $0x30,%rbx
   0x0000000000000799 <+137>: je     0x8be  

Looking at .text+0x8be:

Quoted 9 lines
Quoted 5 lines

(gdb) x/4i 0x00000000000008be+0x8be

   0x117c <adis16300_channels+1180>:  add    %al,(%rax)
   0x117e <adis16300_channels+1182>:  add    %al,(%rax)
   0x1180 <adis16300_channels+1184>:  add    $0x0,%al
   0x1182 <adis16300_channels+1186>:  add    %al,(%rax)  

I cannot tell if this is an actual issue, or just a false positive, but I decided to post my findings here nevertheless.

So far no one has been able to identify an actual problem, so I'm treating this a false positive that will eventually get fixed from the compiler side. Or someone will explain what the issue in the code is.

Jonathan

Signature · 4 lines
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.
#13 lore raw

[Bug 219192] drivers/iio/imu/adis16400.o: warning: objtool: adis16400_write_raw() falls through to next function adis16400_show_flash_count()

In reply to [email protected]

https://bugzilla.kernel.org/show_bug.cgi?id=219192

--- Comment #8 from Andy Shevchenko ([email protected]) --- (In reply to Tudor Gheorghiu from comment #6)

Quoted 21 lines

I saw this bugreport and I must say I encountered a somewhat similar but not quite the same warning message from objtool when compiling with clang.

This is my environment:
Linux version 6.12.0-rc1+ (Ubuntu clang version 18.1.3 (1ubuntu1), Ubuntu LLD 18.1.3)

This is the objtool warning:

Quoted 2 lines

drivers/iio/imu/adis16400.o: warning: objtool: adis16400_write_raw+0x89:
can't find jump dest instruction at .text+0x8be

I dissasembled the binary and this is what I found at that offset:

Quoted 7 lines
   0x0000000000000781 <+113>: jmp    0x8a4 <adis16400_write_raw+404>
   0x0000000000000786 <+118>: mov    %rdi,%r12
   0x0000000000000789 <+121>: lea    0x30(%r14),%rdi
   0x000000000000078d <+125>: call   0x792 <adis16400_write_raw+130>
   0x0000000000000792 <+130>: mov    %r14,%rbx
   0x0000000000000795 <+133>: add    $0x30,%rbx
   0x0000000000000799 <+137>: je     0x8be
Quoted 3 lines

Looking at .text+0x8be:

Quoted 2 lines

(gdb) x/4i 0x00000000000008be+0x8be
0x117c <adis16300_channels+1180>: add %al,(%rax)

How did you get 0x117c? It can't be correct offset AFAIU all this.

Quoted 3 lines
Quoted 3 lines
   0x117e <adis16300_channels+1182>:  add    %al,(%rax)
   0x1180 <adis16300_channels+1184>:  add    $0x0,%al
   0x1182 <adis16300_channels+1186>:  add    %al,(%rax)

The above looks to me like a data or so. But I don't remember by heart the actual binary codes for these assembly to be sure.

Quoted 2 lines

I cannot tell if this is an actual issue, or just a false positive, but I decided to post my findings here nevertheless.

Signature · 4 lines
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.
#14 lore raw

[Bug 219192] drivers/iio/imu/adis16400.o: warning: objtool: adis16400_write_raw() falls through to next function adis16400_show_flash_count()

In reply to [email protected]

https://bugzilla.kernel.org/show_bug.cgi?id=219192

--- Comment #9 from Andy Shevchenko ([email protected]) --- This
https://git.kernel.org/pub/scm/linux/kernel/git/hid/hid.git/commit/?h=for-6.13/core&id=b2b8a75e1d88c551a0b30d44d0be552210219eea
one is related and may be used as an example how to fix that.

Signature · 4 lines
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.
maintainer
#15 lore raw

Re: [Bug 219192] drivers/iio/imu/adis16400.o: warning: objtool: adis16400_write_raw() falls through to next function adis16400_show_flash_count()

Quoted 7 lines · On Fri, 18 Oct 2024 11:02:41 +0000 [email protected] wrote:

https://bugzilla.kernel.org/show_bug.cgi?id=219192

--- Comment #9 from Andy Shevchenko ([email protected]) --- This
https://git.kernel.org/pub/scm/linux/kernel/git/hid/hid.git/commit/?h=for-6.13/core&id=b2b8a75e1d88c551a0b30d44d0be552210219eea
one is related and may be used as an example how to fix that.

Maybe. Though not quite the same as in this case the code really is unreachable. The compiler is simply failing to discover it. We could but BUG() in all these places but that is nasty.

The series:
https://lore.kernel.org/all/20241001-cleanup-if_not_cond_guard-v1-0-7753810b0f7a@baylibre.com/

gives code the compiler should never fail to figure out, so using that instead is a better approach in my opinion and Peter Z just applied the infrastructure to his tree today.

Jonathan

#16 lore raw

[Bug 219192] drivers/iio/imu/adis16400.o: warning: objtool: adis16400_write_raw() falls through to next function adis16400_show_flash_count()

In reply to [email protected]

https://bugzilla.kernel.org/show_bug.cgi?id=219192

--- Comment #10 from Jonathan Cameron ([email protected]) ---

Quoted 8 lines · On Fri, 18 Oct 2024 11:02:41 +0000 [email protected] wrote:

https://bugzilla.kernel.org/show_bug.cgi?id=219192

--- Comment #9 from Andy Shevchenko ([email protected]) --- This

https://git.kernel.org/pub/scm/linux/kernel/git/hid/hid.git/commit/?h=for-6.13/core&id=b2b8a75e1d88c551a0b30d44d0be552210219eea
one is related and may be used as an example how to fix that.

Maybe. Though not quite the same as in this case the code really is unreachable. The compiler is simply failing to discover it. We could but BUG() in all these places but that is nasty.

The series:
https://lore.kernel.org/all/20241001-cleanup-if_not_cond_guard-v1-0-7753810b0f7a@baylibre.com/

gives code the compiler should never fail to figure out, so using that instead is a better approach in my opinion and Peter Z just applied the infrastructure to his tree today.

Jonathan

Signature · 4 lines
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.
#17 lore raw

[Bug 219192] drivers/iio/imu/adis16400.o: warning: objtool: adis16400_write_raw() falls through to next function adis16400_show_flash_count()

In reply to [email protected]

https://bugzilla.kernel.org/show_bug.cgi?id=219192

--- Comment #11 from Andy Shevchenko ([email protected]) --- Do we still have this issue in the latest vanilla (v6.13)? Looking again at the code I'm wondering why we can't simply use guard()() instead of scoped_guard(). It might actually fix this.

Signature · 4 lines
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.
maintainer
#18 lore raw

Re: [Bug 219192] drivers/iio/imu/adis16400.o: warning: objtool: adis16400_write_raw() falls through to next function adis16400_show_flash_count()

Quoted 7 lines · On Thu, 23 Jan 2025 17:45:29 +0000 [email protected] wrote:

https://bugzilla.kernel.org/show_bug.cgi?id=219192

--- Comment #11 from Andy Shevchenko ([email protected]) --- Do we still have this issue in the latest vanilla (v6.13)? Looking again at the code I'm wondering why we can't simply use guard()() instead of scoped_guard(). It might actually fix this.

Is this actually a bug rather than a false warning?
My impression was that this is a compiler problem and I'm not that keen to modify drivers to work around that unless the resulting module is actually broken.

If we have to, just add pointless returns instead of unreachable() markings with a comment to say they are unreachable but we suppressing a toolchain issue.

Jonathan

#19 lore raw

[Bug 219192] drivers/iio/imu/adis16400.o: warning: objtool: adis16400_write_raw() falls through to next function adis16400_show_flash_count()

In reply to [email protected]

https://bugzilla.kernel.org/show_bug.cgi?id=219192

--- Comment #12 from Jonathan Cameron ([email protected]) ---

Quoted 9 lines · On Thu, 23 Jan 2025 17:45:29 +0000 [email protected] wrote:

https://bugzilla.kernel.org/show_bug.cgi?id=219192

--- Comment #11 from Andy Shevchenko ([email protected]) --- Do we still have this issue in the latest vanilla (v6.13)? Looking again at the
code I'm wondering why we can't simply use guard()() instead of scoped_guard().
It might actually fix this.

Is this actually a bug rather than a false warning?
My impression was that this is a compiler problem and I'm not that keen to modify
drivers to work around that unless the resulting module is actually broken.

If we have to, just add pointless returns instead of unreachable() markings with a comment to say they are unreachable but we suppressing a toolchain issue.

Jonathan

Signature · 4 lines
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.
#20 lore raw

[Bug 219192] drivers/iio/imu/adis16400.o: warning: objtool: adis16400_write_raw() falls through to next function adis16400_show_flash_count()

In reply to [email protected]

https://bugzilla.kernel.org/show_bug.cgi?id=219192

--- Comment #13 from Andy Shevchenko ([email protected]) --- Another thread pointed out to the BUG() instead of unreacheable() which should solve the issue. Can we go that direction?

Signature · 4 lines
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.
maintainer
#21 lore raw

Re: [Bug 219192] drivers/iio/imu/adis16400.o: warning: objtool: adis16400_write_raw() falls through to next function adis16400_show_flash_count()

Quoted 6 lines · On Wed, 30 Apr 2025 06:33:42 +0000 [email protected] wrote:

https://bugzilla.kernel.org/show_bug.cgi?id=219192

--- Comment #13 from Andy Shevchenko ([email protected]) --- Another thread pointed out to the BUG() instead of unreacheable() which should solve the issue. Can we go that direction?

Ok. Maybe replace them with something that doesn't loose readability such as BUG(); /* Unreachable */

#22 lore raw

[Bug 219192] drivers/iio/imu/adis16400.o: warning: objtool: adis16400_write_raw() falls through to next function adis16400_show_flash_count()

In reply to [email protected]

https://bugzilla.kernel.org/show_bug.cgi?id=219192

--- Comment #14 from Jonathan Cameron ([email protected]) ---

Quoted 6 lines · On Wed, 30 Apr 2025 06:33:42 +0000 [email protected] wrote:

https://bugzilla.kernel.org/show_bug.cgi?id=219192

--- Comment #13 from Andy Shevchenko ([email protected]) --- Another thread pointed out to the BUG() instead of unreacheable() which should solve the issue. Can we go that direction?

Ok. Maybe replace them with something that doesn't loose readability such as BUG(); /* Unreachable */

Signature · 4 lines
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.
#23 lore raw

[Bug 219192] drivers/iio/imu/adis16400.o: warning: objtool: adis16400_write_raw() falls through to next function adis16400_show_flash_count()

In reply to [email protected]

https://bugzilla.kernel.org/show_bug.cgi?id=219192

Josh Poimboeuf ([email protected]) changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |[email protected]

--- Comment #15 from Josh Poimboeuf ([email protected]) ---
In this case the scoped lock is unconditional, so the unreachable() can just be replaced with an " /* unreachable */ " comment.

We're trying to remove all uses of unreachable() from the kernel as they tend to encourage the compiler to insert undefined behavior.

Signature · 4 lines
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.