Skip to contentSkip to conversation

misc: microchip: pci1xxxx: add support for NVMEM_DEVID_AUTO for EEPROM device

PATCH In review Heiko Thiery 2 participants 4 messages Oct 7, 2024

Subsystems (4)
Stable branch GPIO Char and misc drivers Microchip PCI1XXXX gp driver
lore
Share & tools
lore

Heiko Thiery

author
#0 lore raw

PATCH v2 1/2 misc: microchip: pci1xxxx: add support for NVMEM_DEVID_AUTO for EEPROM device

By using NVMEM_DEVID_AUTO we support more than 1 device and automatically enumerate.

Fixes 9ab5465349c0 ("misc: microchip: pci1xxxx: Add support to read and write into PCI1XXXX EEPROM via NVMEM sysfs")
Cc <[email protected]>
Signed-off-by Heiko Thiery <[email protected]>

---
v2: add CC to <[email protected]> after receiving friendly mail
from patch-bot.

 drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_otpe2p.c | 1 +
 1 file changed, 1 insertion(+)
drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_otpe2p.c +1 -0
index 7c3d8bedf90b..d1cd4544c83c 100644
@@ -364,6 +364,7 @@ static int pci1xxxx_otp_eeprom_probe(struct auxiliary_device *aux_dev,
 	if (is_eeprom_responsive(priv)) {
 		priv->nvmem_config_eeprom.type = NVMEM_TYPE_EEPROM;
 		priv->nvmem_config_eeprom.name = EEPROM_NAME;
+		priv->nvmem_config_eeprom.id = NVMEM_DEVID_AUTO;
 		priv->nvmem_config_eeprom.dev = &aux_dev->dev;
 		priv->nvmem_config_eeprom.owner = THIS_MODULE;
 		priv->nvmem_config_eeprom.reg_read = pci1xxxx_eeprom_read;
Signature · 1 line
2.39.2
author
#1 lore raw

PATCH v2 2/2 misc: microchip: pci1xxxx: add support for NVMEM_DEVID_AUTO for OTP device

By using NVMEM_DEVID_AUTO we support more than 1 device and automatically enumerate.

Fixes 0969001569e4 ("misc: microchip: pci1xxxx: Add support to read and write into PCI1XXXX OTP via NVMEM sysfs")
Cc <[email protected]>
Signed-off-by Heiko Thiery <[email protected]>

---
v2: add CC to <[email protected]> after receiving friendly mail
from patch-bot.

 drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_otpe2p.c | 1 +
 1 file changed, 1 insertion(+)
drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_otpe2p.c +1 -0
index d1cd4544c83c..a2ed477e0370 100644
@@ -384,6 +384,7 @@ static int pci1xxxx_otp_eeprom_probe(struct auxiliary_device *aux_dev,
 
 	priv->nvmem_config_otp.type = NVMEM_TYPE_OTP;
 	priv->nvmem_config_otp.name = OTP_NAME;
+	priv->nvmem_config_otp.id = NVMEM_DEVID_AUTO;
 	priv->nvmem_config_otp.dev = &aux_dev->dev;
 	priv->nvmem_config_otp.owner = THIS_MODULE;
 	priv->nvmem_config_otp.reg_read = pci1xxxx_otp_read;
Signature · 1 line
2.39.2
Reviewed-by on v2 2/2
#2 lore raw

Re: [PATCH v2 2/2] misc: microchip: pci1xxxx: add support for NVMEM_DEVID_AUTO for OTP device

Quoted 6 lines · Heiko Thiery

By using NVMEM_DEVID_AUTO we support more than 1 device and automatically enumerate.

Fixes 0969001569e4 ("misc: microchip: pci1xxxx: Add support to read and write into PCI1XXXX OTP via NVMEM sysfs")
Cc <[email protected]>
Signed-off-by Heiko Thiery <[email protected]>
Reviewed-by Michael Walle <[email protected]>

-michael