wifi: mt76: mt7996: fix invalid interface combinations
Subsystems (2)
Shayne Chen
reviewerPATCH 1/1 wifi: mt76: mt7996: fix invalid interface combinations
Setting beacon_int_min_gcd and NL80211_IFTYPE_ADHOC in the same interface combination is invalid, which will trigger the following warning trace and get error returned from wiphy_register().
[ 10.080325] Call trace: [ 10.082761] wiphy_register+0xc4/0x76c [cfg80211] [ 10.087465] ieee80211_register_hw+0x800/0xac4 [mac80211] [ 10.092868] mt76_register_device+0x16c/0x2c0 [mt76] [ 10.097829] mt7996_register_device+0x740/0x844 [mt7996e]
Fix this by removing unused adhoc iftype.
--- drivers/net/wireless/mediatek/mt76/mt7996/init.c | 3 --- 1 file changed, 3 deletions(-)
drivers/net/wireless/mediatek/mt76/mt7996/init.c +0 -3
@@ -16,9 +16,6 @@static const struct ieee80211_iface_limit if_limits[] = { { - .max =1 , - .types =BIT (NL80211_IFTYPE_ADHOC ) - }, { .max =16 , .types =BIT (NL80211_IFTYPE_AP ) #ifdef CONFIG_MAC80211_MESH
Signature · 1 line
2.39.2
Hi Shayne
Quoted 14 lines
Gesendet: Montag, 07. Oktober 2024 um 15:51 Uhr
Von: "Shayne Chen" <[email protected]>
Betreff: [PATCH wireless] wifi: mt76: mt7996: fix invalid interface combinationsSetting
beacon_int_min_gcdandNL80211_IFTYPE_ADHOCin the same interface combination is invalid, which will trigger the following warning trace and get error returned fromwiphy_register().[ 10.080325] Call trace: [ 10.082761] wiphy_register+0xc4/0x76c [cfg80211] [ 10.087465] ieee80211_register_hw+0x800/0xac4 [mac80211] [ 10.092868] mt76_register_device+0x16c/0x2c0 [mt76] [ 10.097829] mt7996_register_device+0x740/0x844 [mt7996e]
Quoted 5 lines
Fix this by removing unused adhoc iftype.
Fixes 948f65249868 ("wifi: mt76: mt7996: advertize beacon_int_min_gcd")Reported-by Frank Wunderlich <[email protected]>Signed-off-by Shayne Chen <[email protected]>
thx for the patch. I can confirm it fixes the issue/trace.
regards
Frank Wunderlich
Tested-byHi
this seems still not merged to next.
can wireless/mtk Maintainer please pick this up?
Quoted 19 lines
Gesendet: Mittwoch, 9. Oktober 2024 um 19:23
Betreff: Aw: [PATCH wireless] wifi: mt76: mt7996: fix invalid interface combinationsHi Shayne
Quoted 14 lines
Gesendet: Montag, 07. Oktober 2024 um 15:51 Uhr
Von: "Shayne Chen" <[email protected]>
Betreff: [PATCH wireless] wifi: mt76: mt7996: fix invalid interface combinationsSetting
beacon_int_min_gcdandNL80211_IFTYPE_ADHOCin the same interface combination is invalid, which will trigger the following warning trace and get error returned fromwiphy_register().[ 10.080325] Call trace: [ 10.082761] wiphy_register+0xc4/0x76c [cfg80211] [ 10.087465] ieee80211_register_hw+0x800/0xac4 [mac80211] [ 10.092868] mt76_register_device+0x16c/0x2c0 [mt76] [ 10.097829] mt7996_register_device+0x740/0x844 [mt7996e]
Quoted 7 lines
Quoted 5 lines
Fix this by removing unused adhoc iftype.
Fixes 948f65249868 ("wifi: mt76: mt7996: advertize beacon_int_min_gcd")Reported-by Frank Wunderlich <[email protected]>Signed-off-by Shayne Chen <[email protected]>thx for the patch. I can confirm it fixes the issue/trace.
if tested-by is necessary:
Quoted 1 line
regards
Quoted 31 lines · Frank Wunderlich
Hi
this seems still not merged to next.
can wireless/mtk Maintainer please pick this up?
Quoted 25 lines
Gesendet: Mittwoch, 9. Oktober 2024 um 19:23
Betreff: Aw: [PATCH wireless] wifi: mt76: mt7996: fix invalid interface combinationsHi Shayne
Quoted 19 lines
Gesendet: Montag, 07. Oktober 2024 um 15:51 Uhr
Von: "Shayne Chen" <[email protected]>
Betreff: [PATCH wireless] wifi: mt76: mt7996: fix invalid interface combinationsSetting
beacon_int_min_gcdandNL80211_IFTYPE_ADHOCin the same interface combination is invalid, which will trigger the following warning trace and get error returned fromwiphy_register().[ 10.080325] Call trace: [ 10.082761] wiphy_register+0xc4/0x76c [cfg80211] [ 10.087465] ieee80211_register_hw+0x800/0xac4 [mac80211] [ 10.092868] mt76_register_device+0x16c/0x2c0 [mt76] [ 10.097829] mt7996_register_device+0x740/0x844 [mt7996e]Fix this by removing unused adhoc iftype.
Fixes 948f65249868 ("wifi: mt76: mt7996: advertize beacon_int_min_gcd")Reported-by Frank Wunderlich <[email protected]>Signed-off-by Shayne Chen <[email protected]>
Quoted 5 lines
Quoted 1 line
thx for the patch. I can confirm it fixes the issue/trace.
if tested-by is necessary:
Tested-by Frank Wunderlich <[email protected]>
Felix, should I take this directly to wireless-next? Ack?
Signature · 3 lines
https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
Quoted 10 lines · Shayne Chen
Setting
beacon_int_min_gcdandNL80211_IFTYPE_ADHOCin the same interface combination is invalid, which will trigger the following warning trace and get error returned fromwiphy_register().[ 10.080325] Call trace: [ 10.082761] wiphy_register+0xc4/0x76c [cfg80211] [ 10.087465] ieee80211_register_hw+0x800/0xac4 [mac80211] [ 10.092868] mt76_register_device+0x16c/0x2c0 [mt76] [ 10.097829] mt7996_register_device+0x740/0x844 [mt7996e]
Quoted 6 lines
Fix this by removing unused adhoc iftype.
Fixes 948f65249868 ("wifi: mt76: mt7996: advertize beacon_int_min_gcd")Reported-by Frank Wunderlich <[email protected]>Signed-off-by Shayne Chen <[email protected]>Tested-by Frank Wunderlich <[email protected]>
Patch applied to wireless-next.git, thanks.
89aca45f2687 wifi: mt76: mt7996: fix invalid interface combinations
Signature · 3 lines
https://patchwork.kernel.org/project/linux-wireless/patch/[email protected]/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches