Skip to contentSkip to conversation

IB/hfi1: make clear_all_interrupts static

PATCH Applied [email protected] 2 participants 2 messages Oct 7, 2024 – Oct 8, 2024

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 IB/hfi1: make clear_all_interrupts static

From: "Dr. David Alan Gilbert" <[email protected]>

clear_all_interrupts() in hw/hfi1/chip.c is currently global but only used in the same file, so make it static.

There are also 'clear_all_interrupts' functions in i2c-nomadik and emif.c but fortunately they're already static.

(Build and boot tested only, I don't have this hardware)

---
 drivers/infiniband/hw/hfi1/chip.c | 2 +-
 drivers/infiniband/hw/hfi1/chip.h | 1 -
 2 files changed, 1 insertion(+), 2 deletions(-)
drivers/infiniband/hw/hfi1/chip.c +1 -1
index c52e6b2c9914..a442eca498b8 100644
@@ -13235,7 +13235,7 @@ int set_intr_bits(struct hfi1_devdata *dd, u16 first, u16 last, bool set)
 /*
  * Clear all interrupt sources on the chip.
  */
-void clear_all_interrupts(struct hfi1_devdata *dd)
+static void clear_all_interrupts(struct hfi1_devdata *dd)
 {
 	int i;
 
drivers/infiniband/hw/hfi1/chip.h +0 -1
index d861aa8fc640..8841db16bde7 100644
@@ -1404,7 +1404,6 @@ irqreturn_t receive_context_interrupt_napi(int irq, void *data);
 
 int set_intr_bits(struct hfi1_devdata *dd, u16 first, u16 last, bool set);
 void init_qsfp_int(struct hfi1_devdata *dd);
-void clear_all_interrupts(struct hfi1_devdata *dd);
 void remap_intr(struct hfi1_devdata *dd, int isrc, int msix_intr);
 void remap_sdma_interrupts(struct hfi1_devdata *dd, int engine, int msix_intr);
 void reset_interrupts(struct hfi1_devdata *dd);
Signature · 1 line
2.46.2
#1 lore raw
Quoted 9 lines · On Tue, 08 Oct 2024 00:53:26 +0100, [email protected] wrote:

clear_all_interrupts() in hw/hfi1/chip.c is currently global but only used in the same file, so make it static.

There are also 'clear_all_interrupts' functions in i2c-nomadik and emif.c but fortunately they're already static.

(Build and boot tested only, I don't have this hardware)

[...]

Applied, thanks!

[1/1] IB/hfi1: make clear_all_interrupts static

      https://git.kernel.org/rdma/rdma/c/89e9ae55dc56f3

Best regards,

Signature · 1 line
Leon Romanovsky <[email protected]>