mpi3mr: Validating SAS port assignments
Subsystems (3)
PATCH v2 1/1 mpi3mr: Validating SAS port assignments
Sanity on phy_mask was added by Tomas through [1].
It causes warning messages when >64 phys are
detected (expander can have >64 phys) and devices
connected to phys greater than 64 are dropped.phy_mask bitmap is only needed for controller
phys(not required for expander phys).Controller phys
can go maximum up to 64 and u64 is good enough to contain phy_mask bitmap.
To suppress those warnings and allow devices to be discovered as before the [1], restrict the phy_mask setting and lowest phy setting only to the controller phys.
[1]:https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git/commit/ drivers/scsi/mpi3mr?h=6.12/ scsi-queue&id=3668651def2c1622904e58b0280ee93121f2b10b
--- drivers/scsi/mpi3mr/mpi3mr.h | 4 +-- drivers/scsi/mpi3mr/mpi3mr_transport.c | 42 +++++++++++++++++--------- 2 files changed, 29 insertions(+), 17 deletions(-)
drivers/scsi/mpi3mr/mpi3mr.h +2 -2
@@ -541,8 +541,8 @@ struct mpi3mr_hba_port {* @port_list: List of ports belonging to a SAS node * @num_phys: Number of phys associated with port * @marked_responding: used while refresing the sas ports -* @lowest_phy: lowest phy ID of current sas port -* @phy_mask: phy_mask of current sas port +* @lowest_phy: lowest phy ID of current sas port, valid for controller port +* @phy_mask: phy_mask of current sas port, valid for controller port * @hba_port: HBA port entry * @remote_identify: Attached device identification * @rphy: SAS transport layer rphy object
drivers/scsi/mpi3mr/mpi3mr_transport.c +27 -15
118 lines not on this page · raw message
Signature · 1 line
2.31.1
Martin K. Petersen
AppliedQuoted 9 lines · Ranjan Kumar
Sanity on
phy_maskwas added by Tomas through [1].
It causes warning messages when >64 phys are
detected (expander can have >64 phys) and devices
connected to phys greater than 64 are dropped.phy_maskbitmap is only needed for controller
phys(not required for expander phys).Controller phys
can go maximum up to 64 and u64 is good enough to containphy_maskbitmap.[...]
Applied to 6.12/scsi-fixes, thanks!
[1/1] mpi3mr: Validating SAS port assignments
https://git.kernel.org/mkp/scsi/c/b9e63d6c7c0e
Signature · 1 line
Martin K. Petersen Oracle Linux Engineering