i2c: qup: use generic device property accessors
Subsystems (2)
PATCH 1/1 i2c: qup: use generic device property accessors
From: Bartosz Golaszewski <[email protected]>
There's no reason for this driver to use OF-specific property helpers. Drop the last one in favor of the generic variant and no longer include of.h.
--- drivers/i2c/busses/i2c-qup.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/i2c/busses/i2c-qup.c +2 -2
@@ -17,9 +17,9 @@#include <linux/interrupt.h> #include <linux/io.h> #include <linux/module.h> -#include <linux/of.h> #include <linux/platform_device.h> #include <linux/pm_runtime.h> +#include <linux/property.h> #include <linux/scatterlist.h> /* QUP Registers */
@@ -1683,7 +1683,7 @@ static int qup_i2c_probe(struct platform_device *pdev) } } -if (of_device_is_compatible (pdev->dev.of_node,"qcom,i2c-qup-v1.1.1" )) { +if (device_is_compatible (&pdev->dev,"qcom,i2c-qup-v1.1.1" )) { qup->adap.algo = &qup_i2c_algo; qup->adap.quirks = &qup_i2c_quirks; is_qup_v1 = true;
Signature · 1 line
2.43.0
Quoted 9 lines · Bartosz Golaszewski
From: Bartosz Golaszewski <[email protected]>
There's no reason for this driver to use OF-specific property helpers. Drop the last one in favor of the generic variant and no longer include
of.h.Signed-off-by Bartosz Golaszewski <[email protected]>---
It's been two weeks. Ping?
Bart
Quoted 27 lines · Bartosz Golaszewski
From: Bartosz Golaszewski <[email protected]>
There's no reason for this driver to use OF-specific property helpers. Drop the last one in favor of the generic variant and no longer include
of.h.Signed-off-by Bartosz Golaszewski <[email protected]>--- drivers/i2c/busses/i2c-qup.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/i2c/busses/i2c-qup.c +1
-1@@ -17,9 +17,9 @@#include <linux/interrupt.h> #include <linux/io.h> #include <linux/module.h> -#include <linux/of.h> #include <linux/platform_device.h> #include <linux/pm_runtime.h> +#include <linux/property.h> #include <linux/scatterlist.h> /* QUP Registers */
drivers/i2c/busses/i2c-qup.c static int qup_i2c_probe(struct platform_device *pdev) · line 1689
Quoted 8 lines
drivers/i2c/busses/i2c-qup.c +1
-1@@ -1683,7 +1683,7 @@ static int qup_i2c_probe(struct platform_device *pdev) } } -if (of_device_is_compatible (pdev->dev.of_node,"qcom,i2c-qup-v1.1.1" )) { +if (device_is_compatible (&pdev->dev,"qcom,i2c-qup-v1.1.1" )) { qup->adap.algo = &qup_i2c_algo; qup->adap.quirks = &qup_i2c_quirks; is_qup_v1 = true;
LGTM
Quoted 8 lines · On Tue, Oct 22, 2024 at 2:05 PM <[email protected]> wrote:
Quoted 6 lines · Bartosz Golaszewski
From: Bartosz Golaszewski <[email protected]>
There's no reason for this driver to use OF-specific property helpers. Drop the last one in favor of the generic variant and no longer include
of.h.
Quoted 5 lines
Quoted 1 line
Signed-off-by Bartosz Golaszewski <[email protected]>LGTM
Reviewed-by Neil Armstrong <[email protected]>
Andi, can you pick this up, please?
Bart
Quoted 12 lines · Bartosz Golaszewski
Quoted 10 lines · On Tue, Oct 22, 2024 at 2:05 PM <[email protected]> wrote:
Quoted 7 lines · Bartosz Golaszewski
From: Bartosz Golaszewski <[email protected]>
There's no reason for this driver to use OF-specific property helpers. Drop the last one in favor of the generic variant and no longer include
of.h.Signed-off-by Bartosz Golaszewski <[email protected]>
Quoted 7 lines
Quoted 3 lines
LGTM
Reviewed-by Neil Armstrong <[email protected]>Andi, can you pick this up, please?
Bart
Any reason why this simple change cannot be picked up?
Bartosz
Quoted 18 lines · Bartosz Golaszewski
Quoted 16 lines · Bartosz Golaszewski
Quoted 13 lines · On Tue, Oct 22, 2024 at 2:05 PM <[email protected]> wrote:
Quoted 7 lines · Bartosz Golaszewski
From: Bartosz Golaszewski <[email protected]>
There's no reason for this driver to use OF-specific property helpers. Drop the last one in favor of the generic variant and no longer include
of.h.Signed-off-by Bartosz Golaszewski <[email protected]>LGTM
Reviewed-by Neil Armstrong <[email protected]>
Quoted 7 lines
Quoted 3 lines
Andi, can you pick this up, please?
Bart
Any reason why this simple change cannot be picked up?
Bartosz
I'll take it through my tree for v6.13 if there's no response in the following days.
Bart
Bartosz Golaszewski
AppliedFrom: Bartosz Golaszewski <[email protected]>
Quoted 5 lines · Bartosz Golaszewski
There's no reason for this driver to use OF-specific property helpers. Drop the last one in favor of the generic variant and no longer include
of.h.
Applied, to the GPIO tree as the maintainer has been unresposive for two months and the change is trivial.
[1/1] i2c: qup: use generic device property accessors
commit: 400913bd4edd76ef1775bfd95543846bd6f5ed71
Best regards,
Signature · 1 line
Bartosz Golaszewski <[email protected]>
Quoted 10 lines · Bartosz Golaszewski
From: Bartosz Golaszewski <[email protected]>
Quoted 5 lines · Bartosz Golaszewski
There's no reason for this driver to use OF-specific property helpers. Drop the last one in favor of the generic variant and no longer include
of.h.
Quoted 5 lines
Applied, to the GPIO tree as the maintainer has been unresposive for two months and the change is trivial.
[1/1] i2c: qup: use generic device property accessors
commit: 400913bd4edd76ef1775bfd95543846bd6f5ed71
I think it's a bad idea to pull unrelated patches just because you have a GPIO tree.
Signature · 2 lines
With best wishes Dmitry
Quoted 12 lines · Dmitry Baryshkov
Quoted 10 lines · Bartosz Golaszewski
From: Bartosz Golaszewski <[email protected]>
Quoted 5 lines · Bartosz Golaszewski
There's no reason for this driver to use OF-specific property helpers. Drop the last one in favor of the generic variant and no longer include
of.h.
Quoted 9 lines
Quoted 5 lines
Applied, to the GPIO tree as the maintainer has been unresposive for two months and the change is trivial.
[1/1] i2c: qup: use generic device property accessors
commit: 400913bd4edd76ef1775bfd95543846bd6f5ed71I think it's a bad idea to pull unrelated patches just because you have a GPIO tree.
I know. I dropped it. But I have no idea what the recourse is if you have reviewed trivial refactorings that get stuck on the list forever because the maintainer whose address otherwise doesn't bounce and who is active on the list just chooses not to respond for weeks. There don't seem to be written rules on this.
Greg: Can you take it instead?
Bart
Quoted 2 lines
Greg: Can you take it instead?
I pinged Andi also. If not, I will take it. Don't take it personally. Simply patches overload.
Hi Bartosz,
Quoted 7 lines · Bartosz Golaszewski
From: Bartosz Golaszewski <[email protected]>
There's no reason for this driver to use OF-specific property helpers. Drop the last one in favor of the generic variant and no longer include
of.h.Signed-off-by Bartosz Golaszewski <[email protected]>
this whole thread has gone off my radar, I'm sorry to have missed this. Thanks Wolfram for bringing this to my attention.
Merged to i2c/i2c-host.
Andi
Quoted 10 lines · Andi Shyti
Hi Bartosz,
Quoted 6 lines · Bartosz Golaszewski
From: Bartosz Golaszewski <[email protected]>
There's no reason for this driver to use OF-specific property helpers. Drop the last one in favor of the generic variant and no longer include
of.h.
Quoted 8 lines
Quoted 1 line
Signed-off-by Bartosz Golaszewski <[email protected]>this whole thread has gone off my radar, I'm sorry to have missed this. Thanks Wolfram for bringing this to my attention.
Merged to i2c/i2c-host.
Andi
Hi Andi,
This now shows up in mainline as commit 50b9d43e6ceaa ("i2c: qup: use generic device property accessors") and in next there's a duplicate commit 6f5f581b577b4 ("i2c: qup: use generic device property accessors"). I think you should drop the latter from your branch.
Bart