Skip to contentSkip to conversation

Add mmc support for mt7988

PATCH Superseded Frank Wunderlich 2 participants 4 messages Oct 9, 2024

Subsystems (4)

v3 of 7 Superseded Latest is v7 →

lore
Share & tools
lore
#0 lore raw

v3 cover Add mmc support for mt7988

From: Frank Wunderlich <[email protected]>

Add MMC-Support for MT798 SoC

changes in v3:
- use mt7986 platform-data with the mt7988 compatible

changes in v2:
- corrected minItems to require all 4 clocks

Frank Wunderlich (2):
dt-bindings: mmc: mtk-sd: Add mt7988 SoC
mmc: mtk-sd: add support for mt7988

 .../devicetree/bindings/mmc/mtk-sd.yaml       | 24 +++++++++++++++++++
 drivers/mmc/host/mtk-sd.c                     |  1 +
 2 files changed, 25 insertions(+)
Signature · 1 line
2.43.0
#1 lore raw

PATCH v3 1/2 dt-bindings: mmc: mtk-sd: Add mt7988 SoC

From: Frank Wunderlich <[email protected]>

Add binding definitions for mmc on MT7988 SoC.

---
v3:
- fixed minItems on clock-names too
v2:
- fixed minItems to 4

---
 .../devicetree/bindings/mmc/mtk-sd.yaml       | 24 +++++++++++++++++++
 1 file changed, 24 insertions(+)
Documentation/devicetree/bindings/mmc/mtk-sd.yaml +24 -0
index c532ec92d2d9..bec0577b7508 100644
@@ -21,6 +21,7 @@ properties:
           - mediatek,mt7620-mmc
           - mediatek,mt7622-mmc
           - mediatek,mt7986-mmc
+          - mediatek,mt7988-mmc
           - mediatek,mt8135-mmc
           - mediatek,mt8173-mmc
           - mediatek,mt8183-mmc
@@ -263,6 +264,29 @@ allOf:
             - const: bus_clk
             - const: sys_cg
 
+  - if:
+      properties:
+        compatible:
+          contains:
+            enum:
+              - mediatek,mt7988-mmc
+    then:
+      properties:
+        clocks:
+          minItems: 4
+          items:
+            - description: source clock
+            - description: HCLK which used for host
+            - description: Advanced eXtensible Interface
+            - description: Advanced High-performance Bus clock
+        clock-names:
+          minItems: 4
+          items:
+            - const: source
+            - const: hclk
+            - const: axi_cg
+            - const: ahb_cg
+
   - if:
       properties:
         compatible:
Signature · 1 line
2.43.0
#2 lore raw

Re: [PATCH v3 1/2] dt-bindings: mmc: mtk-sd: Add mt7988 SoC

Quoted 5 lines · Frank Wunderlich

From: Frank Wunderlich <[email protected]>

Add binding definitions for mmc on MT7988 SoC.

Quoted 9 lines

---
v3:
- fixed minItems on clock-names too
v2:
- fixed minItems to 4

---
 .../devicetree/bindings/mmc/mtk-sd.yaml       | 24 +++++++++++++++++++
 1 file changed, 24 insertions(+)

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/mmc/mtk-sd.yaml: allOf:5:then:properties:clocks: 'oneOf' conditional failed, one must be fixed:
[{'description': 'source clock'}, {'description': 'HCLK which used for host'}, {'description': 'Advanced eXtensible Interface'}, {'description': 'Advanced High-performance Bus clock'}] is too long [{'description': 'source clock'}, {'description': 'HCLK which used for host'}, {'description': 'Advanced eXtensible Interface'}, {'description': 'Advanced High-performance Bus clock'}] is too short False schema does not allow 4
1 was expected
4 is greater than the maximum of 2
4 is greater than the maximum of 3
hint: "minItems" is only needed if less than the "items" list length
from schema $id: http://devicetree.org/meta-schemas/items.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/mmc/mtk-sd.yaml: allOf:5:then:properties:clock-names: 'oneOf' conditional failed, one must be fixed:
[{'const': 'source'}, {'const': 'hclk'}, {'const': 'axi_cg'}, {'const': 'ahb_cg'}] is too long
[{'const': 'source'}, {'const': 'hclk'}, {'const': 'axi_cg'}, {'const': 'ahb_cg'}] is too short
False schema does not allow 4
1 was expected
4 is greater than the maximum of 2
4 is greater than the maximum of 3
hint: "minItems" is only needed if less than the "items" list length
from schema $id: http://devicetree.org/meta-schemas/items.yaml#

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/[email protected]

The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.

#3 lore raw

PATCH v3 2/2 mmc: mtk-sd: add support for mt7988

In reply to Frank Wunderlich

From: Frank Wunderlich <[email protected]>

Add support for mmc on MT7988 SoC.

---
changes:

v3:
- reuse mt7986 platform data instead of copy

---
 drivers/mmc/host/mtk-sd.c | 1 +
 1 file changed, 1 insertion(+)
drivers/mmc/host/mtk-sd.c +1 -0
index 89018b6c97b9..aaf27fd211c1 100644
@@ -629,6 +629,7 @@ static const struct of_device_id msdc_of_ids[] = {
 	{ .compatible = "mediatek,mt7620-mmc", .data = &mt7620_compat},
 	{ .compatible = "mediatek,mt7622-mmc", .data = &mt7622_compat},
 	{ .compatible = "mediatek,mt7986-mmc", .data = &mt7986_compat},
+	{ .compatible = "mediatek,mt7988-mmc", .data = &mt7986_compat},
 	{ .compatible = "mediatek,mt8135-mmc", .data = &mt8135_compat},
 	{ .compatible = "mediatek,mt8173-mmc", .data = &mt8173_compat},
 	{ .compatible = "mediatek,mt8183-mmc", .data = &mt8183_compat},
Signature · 1 line
2.43.0