Skip to contentSkip to conversation

btrfs/318: add _require_loop

PATCH In review Mark Harmstone 3 participants 3 messages Oct 10, 2024 – Oct 11, 2024 Btrfs file system

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 btrfs/318: add _require_loop

btrfs/318 uses loopback devices, but was missing a call to _require_loop to print the correct message if CONFIG_LOOP is not set.

---
 tests/btrfs/318 | 1 +
 1 file changed, 1 insertion(+)
tests/btrfs/318 +1 -0
index 79977276..df5a4a07 100755
@@ -18,6 +18,7 @@ _fixed_by_kernel_commit 9f7eb8405dcb \
 _require_test
 _require_command "$PARTED_PROG" parted
 _require_batched_discard "$TEST_DIR"
+_require_loop
 
 _cleanup() {
 	cd /
Signature · 1 line
2.44.2
Reviewed-by on v1 1/1
#1 lore raw
Quoted 5 lines · Mark Harmstone

btrfs/318 uses loopback devices, but was missing a call to _require_loop to print the correct message if CONFIG_LOOP is not set.

Looks good, thanks.

Quoted 20 lines
---
 tests/btrfs/318 | 1 +
 1 file changed, 1 insertion(+)
tests/btrfs/318 +1 -1
index 79977276..df5a4a07 100755
@@ -18,6 +18,7 @@ _fixed_by_kernel_commit 9f7eb8405dcb \
 _require_test
 _require_command "$PARTED_PROG" parted
 _require_batched_discard "$TEST_DIR"
+_require_loop
 
 _cleanup() {
        cd /
--

2.44.2

Reviewed-by on v1 1/1
#2 lore raw
In reply to Mark Harmstone
Quoted 13 lines · Mark Harmstone

btrfs/318 uses loopback devices, but was missing a call to _require_loop to print the correct message if CONFIG_LOOP is not set.

---
 tests/btrfs/318 | 1 +
 1 file changed, 1 insertion(+)
tests/btrfs/318 +0 -0
index 79977276..df5a4a07 100755

tests/btrfs/318 _fixed_by_kernel_commit 9f7eb8405dcb \ · line 21

Quoted 4 lines
tests/btrfs/318 +1 -0
@@ -18,6 +18,7 @@ _fixed_by_kernel_commit 9f7eb8405dcb \
 _require_test
 _require_command "$PARTED_PROG" parted
 _require_batched_discard "$TEST_DIR"
+_require_loop

Sure, this case need loop device.

Quoted 7 lines
tests/btrfs/318 +0 -0
 _cleanup() {
 	cd /
Signature · 1 line
2.44.2