Skip to contentSkip to conversation

staging: vt6655: Remove unused driver

PATCH New Philipp Hortmann 1 participant 1 message Oct 10, 2024 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: vt6655: Remove unused driver

Forest Bond contributed this driver in 2009.

The following reasons lead to the removal:
- This driver generates maintenance workload
- This driver has a maximum 54MBit/s as it supports only 802.11 b/g. Peak throughput is 3MBytes/s but this lasts only for a second. Typically throughput is 1.7MBytes/s.
- Depending on the number of devices on the channel the device looses connection and cannot reconnect for 5-60 seconds. Watching a youtube video is OK because of the buffer. But surfing can then be really a pain.
- Its form factor is mini PCI (not miniPCIe) that is old and large.
- Hardly not to buy.

---
Checked for artifacts of vt6655 in MAINTAINERS. Entry for "VIA VT665X DRIVERS" is still in use for vt6656. Removed artifacts in Makefile and Kconfig.

---
 drivers/staging/Kconfig              |    2 -
 drivers/staging/Makefile             |    1 -
 drivers/staging/vt6655/Kconfig       |    6 -
 drivers/staging/vt6655/Makefile      |   15 -
 drivers/staging/vt6655/TODO          |   20 -
 drivers/staging/vt6655/baseband.c    | 2257 --------------------------
 drivers/staging/vt6655/baseband.h    |   72 -
 drivers/staging/vt6655/card.c        |  836 ----------
 drivers/staging/vt6655/card.h        |   62 -
 drivers/staging/vt6655/channel.c     |  135 --
 drivers/staging/vt6655/channel.h     |   17 -
 drivers/staging/vt6655/desc.h        |  249 ---
 drivers/staging/vt6655/device.h      |  292 ----
 drivers/staging/vt6655/device_cfg.h  |   44 -
 drivers/staging/vt6655/device_main.c | 1868 ---------------------
 drivers/staging/vt6655/dpc.c         |  145 --
 drivers/staging/vt6655/dpc.h         |   21 -
 drivers/staging/vt6655/key.c         |  143 --
 drivers/staging/vt6655/key.h         |   51 -
 drivers/staging/vt6655/mac.c         |  851 ----------
 drivers/staging/vt6655/mac.h         |  580 -------
 drivers/staging/vt6655/power.c       |  144 --
 drivers/staging/vt6655/power.h       |   29 -
 drivers/staging/vt6655/rf.c          |  535 ------
 drivers/staging/vt6655/rf.h          |   71 -
 drivers/staging/vt6655/rxtx.c        | 1467 -----------------
 drivers/staging/vt6655/rxtx.h        |  184 ---
 drivers/staging/vt6655/srom.c        |  139 --
 drivers/staging/vt6655/srom.h        |   85 -
 drivers/staging/vt6655/test          |    9 -
 30 files changed, 10330 deletions(-)
 delete mode 100644 drivers/staging/vt6655/Kconfig
 delete mode 100644 drivers/staging/vt6655/Makefile
 delete mode 100644 drivers/staging/vt6655/TODO
 delete mode 100644 drivers/staging/vt6655/baseband.c
 delete mode 100644 drivers/staging/vt6655/baseband.h
 delete mode 100644 drivers/staging/vt6655/card.c
 delete mode 100644 drivers/staging/vt6655/card.h
 delete mode 100644 drivers/staging/vt6655/channel.c
 delete mode 100644 drivers/staging/vt6655/channel.h
 delete mode 100644 drivers/staging/vt6655/desc.h
 delete mode 100644 drivers/staging/vt6655/device.h
 delete mode 100644 drivers/staging/vt6655/device_cfg.h
 delete mode 100644 drivers/staging/vt6655/device_main.c
 delete mode 100644 drivers/staging/vt6655/dpc.c
 delete mode 100644 drivers/staging/vt6655/dpc.h
 delete mode 100644 drivers/staging/vt6655/key.c
 delete mode 100644 drivers/staging/vt6655/key.h
 delete mode 100644 drivers/staging/vt6655/mac.c
 delete mode 100644 drivers/staging/vt6655/mac.h
 delete mode 100644 drivers/staging/vt6655/power.c
 delete mode 100644 drivers/staging/vt6655/power.h
 delete mode 100644 drivers/staging/vt6655/rf.c
 delete mode 100644 drivers/staging/vt6655/rf.h
 delete mode 100644 drivers/staging/vt6655/rxtx.c
 delete mode 100644 drivers/staging/vt6655/rxtx.h
 delete mode 100644 drivers/staging/vt6655/srom.c
 delete mode 100644 drivers/staging/vt6655/srom.h
 delete mode 100644 drivers/staging/vt6655/test
drivers/staging/Kconfig +0 -2
index f5ea22c1ee6a..5fbb0bc53308 100644
@@ -32,8 +32,6 @@ source "drivers/staging/rtl8712/Kconfig"
 
 source "drivers/staging/octeon/Kconfig"
 
-source "drivers/staging/vt6655/Kconfig"
-
 source "drivers/staging/vt6656/Kconfig"
 
 source "drivers/staging/iio/Kconfig"
drivers/staging/Makefile +0 -1
index 67965fc7dbbb..797dcd192a33 100644
@@ -6,7 +6,6 @@ obj-$(CONFIG_FB_OLPC_DCON)	+= olpc_dcon/
 obj-$(CONFIG_RTL8723BS)		+= rtl8723bs/
 obj-$(CONFIG_R8712U)		+= rtl8712/
 obj-$(CONFIG_OCTEON_ETHERNET)	+= octeon/
-obj-$(CONFIG_VT6655)		+= vt6655/
 obj-$(CONFIG_VT6656)		+= vt6656/
 obj-$(CONFIG_VME_BUS)		+= vme_user/
 obj-$(CONFIG_IIO)		+= iio/
drivers/staging/vt6655/Kconfig deleted +0 -6
deleted file mode 100644
index 077f62ebe80c..000000000000
@@ -1,6 +0,0 @@
-# SPDX-License-Identifier: GPL-2.0
-config VT6655
-   tristate "VIA Technologies VT6655 support"
-   depends on PCI && HAS_IOPORT && MAC80211 && m
-   help
-     This is a vendor-written driver for VIA VT6655.
drivers/staging/vt6655/Makefile deleted +0 -15
deleted file mode 100644
index e70357ec0af8..000000000000
@@ -1,15 +0,0 @@
-# SPDX-License-Identifier: GPL-2.0
-
-vt6655_stage-y +=	device_main.o \
-	card.o \
-	channel.o \
-	mac.o \
-	baseband.o \
-	rxtx.o \
-	dpc.o \
-	power.o \
-	srom.o \
-	key.o \
-	rf.o
-
-obj-$(CONFIG_VT6655) +=	vt6655_stage.o
drivers/staging/vt6655/TODO deleted +0 -20
deleted file mode 100644
index 27654bd0ff5d..000000000000
@@ -1,20 +0,0 @@
-TODO:
-- remove __cplusplus ifdefs -- done
-- prepare for merge with vt6656 driver:
-  - rename DEVICE_PRT() to DBG_PRT() -- done
-  - share 80211*.h includes
-  - split rf.c
-  - remove dead code
-  - abstract VT3253 chipset specific code
-- add common vt665x infrastructure
-- kill ttype.h
-- switch to use MAC80211
-- verify unsigned long usage for x86-64 arch
-- reduce .data footprint
-- use kernel coding style
-- checkpatch.pl fixes
-- sparse fixes
-- integrate with drivers/net/wireless
-
-Please send any patches to Greg Kroah-Hartman <[email protected]>
-and Philipp Hortmann <[email protected]>.
drivers/staging/vt6655/baseband.c deleted +0 -2257

2,257 lines not on this page · raw message

drivers/staging/vt6655/baseband.h deleted +0 -72

72 lines not on this page · raw message

drivers/staging/vt6655/card.c deleted +0 -836

615 lines not on this page · raw message

drivers/staging/vt6655/card.h deleted +0 -62

62 lines not on this page · raw message

drivers/staging/vt6655/channel.c deleted +0 -135

135 lines not on this page · raw message

drivers/staging/vt6655/channel.h deleted +0 -17
deleted file mode 100644
index 78b2d82317e5..000000000000

Lines of this file are not shown. View the raw message.

drivers/staging/vt6655/desc.h deleted +0 -249

249 lines not on this page · raw message

drivers/staging/vt6655/device.h deleted +0 -292

292 lines not on this page · raw message

drivers/staging/vt6655/device_cfg.h deleted +0 -44

44 lines not on this page · raw message

drivers/staging/vt6655/device_main.c deleted +0 -1868

1,868 lines not on this page · raw message

drivers/staging/vt6655/dpc.c deleted +0 -145

145 lines not on this page · raw message

drivers/staging/vt6655/dpc.h deleted +0 -21
deleted file mode 100644
index 40364c0ab7f6..000000000000

Lines of this file are not shown. View the raw message.

drivers/staging/vt6655/key.c deleted +0 -143

143 lines not on this page · raw message

drivers/staging/vt6655/key.h deleted +0 -51

51 lines not on this page · raw message

drivers/staging/vt6655/mac.c deleted +0 -851

851 lines not on this page · raw message

drivers/staging/vt6655/mac.h deleted +0 -580

580 lines not on this page · raw message

drivers/staging/vt6655/power.c deleted +0 -144

144 lines not on this page · raw message

drivers/staging/vt6655/power.h deleted +0 -29
deleted file mode 100644
index 060516f81f5b..000000000000

Lines of this file are not shown. View the raw message.

drivers/staging/vt6655/rf.c deleted +0 -535

535 lines not on this page · raw message

drivers/staging/vt6655/rf.h deleted +0 -71

71 lines not on this page · raw message

drivers/staging/vt6655/rxtx.c deleted +0 -1467

1,467 lines not on this page · raw message

drivers/staging/vt6655/rxtx.h deleted +0 -184

184 lines not on this page · raw message

drivers/staging/vt6655/srom.c deleted +0 -139

139 lines not on this page · raw message

drivers/staging/vt6655/srom.h deleted +0 -85

85 lines not on this page · raw message

drivers/staging/vt6655/test deleted +0 -9
deleted file mode 100644
index ba6dec774478..000000000000

Lines of this file are not shown. View the raw message.

The rest of this diff is not shown. View the raw message.

Signature · 1 line
2.43.0

Part of the diff is not shown here. View the raw message.