Skip to contentSkip to conversation

staging: gdm724x: Remove unused driver

PATCH New Philipp Hortmann 1 participant 1 message Oct 10, 2024 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: gdm724x: Remove unused driver

Won Kang from gct contributed the driver in 2013.

The following reasons lead to the removal:
- This driver generates maintenance workload
- The manufacturer is not interested and does not care as Emails or inquiries, to support or involved persons of gct, got unanswered.
- Did not find a possibility to buy the chips.
- Did not find minimal documentation on the web.
- Did not find a device where it is build in and the user is able to install any Linux. Therefore it is not possible to do any testing of the driver from the community.
- No blog entries about anyone using the gdmtty and gdmulte.
- No response about usage of this drivers to the Email from April 2024

---
Checked for artifacts of gdm724x in MAINTAINERS.
Removed artifacts in Makefile and Kconfig.

---
 drivers/staging/Kconfig              |    2 -
 drivers/staging/Makefile             |    1 -
 drivers/staging/gdm724x/Kconfig      |   16 -
 drivers/staging/gdm724x/Makefile     |    8 -
 drivers/staging/gdm724x/TODO         |   15 -
 drivers/staging/gdm724x/gdm_endian.c |   37 -
 drivers/staging/gdm724x/gdm_endian.h |   30 -
 drivers/staging/gdm724x/gdm_lte.c    |  937 ------------------------
 drivers/staging/gdm724x/gdm_lte.h    |   71 --
 drivers/staging/gdm724x/gdm_mux.c    |  668 -----------------
 drivers/staging/gdm724x/gdm_mux.h    |   85 ---
 drivers/staging/gdm724x/gdm_tty.c    |  316 --------
 drivers/staging/gdm724x/gdm_tty.h    |   60 --
 drivers/staging/gdm724x/gdm_usb.c    | 1014 --------------------------
 drivers/staging/gdm724x/gdm_usb.h    |   99 ---
 drivers/staging/gdm724x/hci.h        |   45 --
 drivers/staging/gdm724x/hci_packet.h |   82 ---
 drivers/staging/gdm724x/netlink_k.c  |  128 ----
 drivers/staging/gdm724x/netlink_k.h  |   16 -
 19 files changed, 3630 deletions(-)
 delete mode 100644 drivers/staging/gdm724x/Kconfig
 delete mode 100644 drivers/staging/gdm724x/Makefile
 delete mode 100644 drivers/staging/gdm724x/TODO
 delete mode 100644 drivers/staging/gdm724x/gdm_endian.c
 delete mode 100644 drivers/staging/gdm724x/gdm_endian.h
 delete mode 100644 drivers/staging/gdm724x/gdm_lte.c
 delete mode 100644 drivers/staging/gdm724x/gdm_lte.h
 delete mode 100644 drivers/staging/gdm724x/gdm_mux.c
 delete mode 100644 drivers/staging/gdm724x/gdm_mux.h
 delete mode 100644 drivers/staging/gdm724x/gdm_tty.c
 delete mode 100644 drivers/staging/gdm724x/gdm_tty.h
 delete mode 100644 drivers/staging/gdm724x/gdm_usb.c
 delete mode 100644 drivers/staging/gdm724x/gdm_usb.h
 delete mode 100644 drivers/staging/gdm724x/hci.h
 delete mode 100644 drivers/staging/gdm724x/hci_packet.h
 delete mode 100644 drivers/staging/gdm724x/netlink_k.c
 delete mode 100644 drivers/staging/gdm724x/netlink_k.h
drivers/staging/Kconfig +0 -2
index 5fbb0bc53308..2493e150fbbd 100644
@@ -42,8 +42,6 @@ source "drivers/staging/nvec/Kconfig"
 
 source "drivers/staging/media/Kconfig"
 
-source "drivers/staging/gdm724x/Kconfig"
-
 source "drivers/staging/fbtft/Kconfig"
 
 source "drivers/staging/most/Kconfig"
drivers/staging/Makefile +0 -1
index 797dcd192a33..add5e887e451 100644
@@ -11,7 +11,6 @@ obj-$(CONFIG_VME_BUS)		+= vme_user/
 obj-$(CONFIG_IIO)		+= iio/
 obj-$(CONFIG_FB_SM750)		+= sm750fb/
 obj-$(CONFIG_MFD_NVEC)		+= nvec/
-obj-$(CONFIG_LTE_GDM724X)	+= gdm724x/
 obj-$(CONFIG_FB_TFT)		+= fbtft/
 obj-$(CONFIG_MOST)		+= most/
 obj-$(CONFIG_GREYBUS)		+= greybus/
drivers/staging/gdm724x/Kconfig deleted +0 -16
deleted file mode 100644
index 1f403ecd9608..000000000000
@@ -1,16 +0,0 @@
-# SPDX-License-Identifier: GPL-2.0
-#
-# GCT GDM724x LTE driver configuration
-#
-
-config LTE_GDM724X
-	tristate "GCT GDM724x LTE support"
-	depends on NET && USB && TTY && m
-	help
-	  This driver supports GCT GDM724x LTE chip based USB modem devices.
-	  It exposes 4 network devices to be used per PDN and 2 tty devices to be
-	  used for AT commands and DM monitoring applications.
-	  The modules will be called gdmulte.ko and gdmtty.ko
-
-	  GCT-ATCx can be used for AT Commands
-	  GCT-DMx can be used for LTE protocol monitoring
drivers/staging/gdm724x/Makefile deleted +0 -8
deleted file mode 100644
index e61b95788c9f..000000000000
@@ -1,8 +0,0 @@
-# SPDX-License-Identifier: GPL-2.0
-obj-$(CONFIG_LTE_GDM724X) := gdmulte.o
-gdmulte-y += gdm_lte.o netlink_k.o
-gdmulte-y += gdm_usb.o gdm_endian.o
-
-obj-$(CONFIG_LTE_GDM724X) += gdmtty.o
-gdmtty-y := gdm_tty.o gdm_mux.o
-
drivers/staging/gdm724x/TODO deleted +0 -15
deleted file mode 100644
index 56a415b9dcbe..000000000000
@@ -1,15 +0,0 @@
-TODO:
-- Clean up coding style to meet kernel standard. (80 line limit, netdev_err)
-- Remove test for host endian
-- Remove confusing macros (endian, hci_send, sdu_send, rcv_with_cb)
-- Check for skb->len in gdm_lte_emulate_arp()
-- Use ALIGN() macro for dummy_cnt in up_to_host()
-- Error handling in init_usb()
-- Explain reason for multiples of 512 bytes in alloc_tx_struct()
-- Review use of atomic allocation for tx structs
-- No error checking for alloc_tx_struct in do_tx()
-- fix up static tty port allocation to be dynamic
-
-Patches to:
-	Jonathan Kim <[email protected]>
-	Dean ahn <[email protected]>
drivers/staging/gdm724x/gdm_endian.c deleted +0 -37
deleted file mode 100644
index ae39e59daf70..000000000000
@@ -1,37 +0,0 @@
-// SPDX-License-Identifier: GPL-2.0
-/* Copyright (c) 2012 GCT Semiconductor, Inc. All rights reserved. */
-
-#include <linux/kernel.h>
-#include "gdm_endian.h"
-
-__dev16 gdm_cpu_to_dev16(u8 dev_ed, u16 x)
-{
-	if (dev_ed == ENDIANNESS_LITTLE)
-		return (__force __dev16)cpu_to_le16(x);
-	else
-		return (__force __dev16)cpu_to_be16(x);
-}
-
-u16 gdm_dev16_to_cpu(u8 dev_ed, __dev16 x)
-{
-	if (dev_ed == ENDIANNESS_LITTLE)
-		return le16_to_cpu((__force __le16)x);
-	else
-		return be16_to_cpu((__force __be16)x);
-}
-
-__dev32 gdm_cpu_to_dev32(u8 dev_ed, u32 x)
-{
-	if (dev_ed == ENDIANNESS_LITTLE)
-		return (__force __dev32)cpu_to_le32(x);
-	else
-		return (__force __dev32)cpu_to_be32(x);
-}
-
-u32 gdm_dev32_to_cpu(u8 dev_ed, __dev32 x)
-{
-	if (dev_ed == ENDIANNESS_LITTLE)
-		return le32_to_cpu((__force __le32)x);
-	else
-		return be32_to_cpu((__force __be32)x);
-}
drivers/staging/gdm724x/gdm_endian.h deleted +0 -30
deleted file mode 100644
index f373dc3a19bf..000000000000
@@ -1,30 +0,0 @@
-/* SPDX-License-Identifier: GPL-2.0 */
-/* Copyright (c) 2012 GCT Semiconductor, Inc. All rights reserved. */
-
-#ifndef __GDM_ENDIAN_H__
-#define __GDM_ENDIAN_H__
-
-#include <linux/types.h>
-
-/*
- * For data in "device-endian" byte order (device endianness is model
- * dependent).  Analogous to __leXX or __beXX.
- */
-typedef __u32 __bitwise __dev32;
-typedef __u16 __bitwise __dev16;
-
-enum {
-	ENDIANNESS_MIN = 0,
-	ENDIANNESS_UNKNOWN,
-	ENDIANNESS_LITTLE,
-	ENDIANNESS_BIG,
-	ENDIANNESS_MIDDLE,
-	ENDIANNESS_MAX
-};
-
-__dev16 gdm_cpu_to_dev16(u8 dev_ed, u16 x);
-u16 gdm_dev16_to_cpu(u8 dev_ed, __dev16 x);
-__dev32 gdm_cpu_to_dev32(u8 dev_ed, u32 x);
-u32 gdm_dev32_to_cpu(u8 dev_ed, __dev32 x);
-
-#endif /*__GDM_ENDIAN_H__*/
drivers/staging/gdm724x/gdm_lte.c deleted +0 -937

937 lines not on this page · raw message

drivers/staging/gdm724x/gdm_lte.h deleted +0 -71

71 lines not on this page · raw message

drivers/staging/gdm724x/gdm_mux.c deleted +0 -668

668 lines not on this page · raw message

drivers/staging/gdm724x/gdm_mux.h deleted +0 -85

85 lines not on this page · raw message

drivers/staging/gdm724x/gdm_tty.c deleted +0 -316

316 lines not on this page · raw message

drivers/staging/gdm724x/gdm_tty.h deleted +0 -60

60 lines not on this page · raw message

drivers/staging/gdm724x/gdm_usb.c deleted +0 -1014

742 lines not on this page · raw message

drivers/staging/gdm724x/gdm_usb.h deleted +0 -99

99 lines not on this page · raw message

drivers/staging/gdm724x/hci.h deleted +0 -45

45 lines not on this page · raw message

drivers/staging/gdm724x/hci_packet.h deleted +0 -82

82 lines not on this page · raw message

drivers/staging/gdm724x/netlink_k.c deleted +0 -128

128 lines not on this page · raw message

drivers/staging/gdm724x/netlink_k.h deleted +0 -16
deleted file mode 100644
index d42eea9bea3e..000000000000

Lines of this file are not shown. View the raw message.

The rest of this diff is not shown. View the raw message.

Signature · 1 line
2.43.0

Part of the diff is not shown here. View the raw message.