Skip to contentSkip to conversation

wic/rootfs.py: allow --exclude-path option to exclude symlinks

PATCH New Yi Zhao 1 participant 1 message Oct 11, 2024

lore
Share & tools
lore

Yi Zhao

author
#0 lore raw

PATCH 1/1 wic/rootfs.py: allow --exclude-path option to exclude symlinks

Currently, if we specify a symbolic link in --exclude-path option, we will get the following error in do_image_wic:

ERROR: --exclude-path: Must point inside the rootfs: usr/bin/hello.link

This is because it uses os.path.realpath to eliminate symbolic links. To exclude symbolic links, use os.path.abspath instead of os.path.realpath.

---
 scripts/lib/wic/plugins/source/rootfs.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
scripts/lib/wic/plugins/source/rootfs.py +1 -1
index ecf749740d..592bcf5175 100644
@@ -41,7 +41,7 @@ class RootfsPlugin(SourcePlugin):
         # Disallow climbing outside of parent directory using '..',
         # because doing so could be quite disastrous (we will delete the
         # directory, or modify a directory outside OpenEmbedded).
-        full_path = os.path.realpath(os.path.join(rootfs_dir, path))
+        full_path = os.path.abspath(os.path.join(rootfs_dir, path))
         if not full_path.startswith(os.path.realpath(rootfs_dir)):
             logger.error("%s: Must point inside the rootfs:" % (cmd, path))
             sys.exit(1)
Signature · 1 line
2.25.1