Skip to contentSkip to conversation

Add mmc support for mt7988

PATCH Superseded Frank Wunderlich 4 participants 7 messages Oct 12, 2024 – Oct 25, 2024

Subsystems (4)

v4 of 7 Superseded Latest is v7 →

lore
Share & tools
lore
#0 lore raw

v4 cover Add mmc support for mt7988

From: Frank Wunderlich <[email protected]>

Add MMC-Support for MT798 SoC

changes in v4:
- drop minitems because of dt_binding_check error
- explain mt7988 compatible with mt7986 platform data in commit description changes in v3:
- use mt7986 platform-data with the mt7988 compatible

changes in v2:
- corrected minItems to require all 4 clocks

Frank Wunderlich (2):
dt-bindings: mmc: mtk-sd: Add mt7988 SoC
mmc: mtk-sd: add support for mt7988

 .../devicetree/bindings/mmc/mtk-sd.yaml       | 22 +++++++++++++++++++
 drivers/mmc/host/mtk-sd.c                     |  1 +
 2 files changed, 23 insertions(+)
Signature · 1 line
2.43.0
#1 lore raw

PATCH v4 1/2 dt-bindings: mmc: mtk-sd: Add mt7988 SoC

From: Frank Wunderlich <[email protected]>

Add binding definitions for mmc on MT7988 SoC.

---
v4:
- drop minitems because of errors
v3:
- fixed minItems on clock-names too
v2:
- fixed minItems to 4

---
 .../devicetree/bindings/mmc/mtk-sd.yaml       | 22 +++++++++++++++++++
 1 file changed, 22 insertions(+)
Documentation/devicetree/bindings/mmc/mtk-sd.yaml +22 -0
index c532ec92d2d9..a51d3bd08d94 100644
@@ -21,6 +21,7 @@ properties:
           - mediatek,mt7620-mmc
           - mediatek,mt7622-mmc
           - mediatek,mt7986-mmc
+          - mediatek,mt7988-mmc
           - mediatek,mt8135-mmc
           - mediatek,mt8173-mmc
           - mediatek,mt8183-mmc
@@ -263,6 +264,27 @@ allOf:
             - const: bus_clk
             - const: sys_cg
 
+  - if:
+      properties:
+        compatible:
+          contains:
+            enum:
+              - mediatek,mt7988-mmc
+    then:
+      properties:
+        clocks:
+          items:
+            - description: source clock
+            - description: HCLK which used for host
+            - description: Advanced eXtensible Interface
+            - description: Advanced High-performance Bus clock
+        clock-names:
+          items:
+            - const: source
+            - const: hclk
+            - const: axi_cg
+            - const: ahb_cg
+
   - if:
       properties:
         compatible:
Signature · 1 line
2.43.0
Reviewed-by on v4 1/2
#2 lore raw

Re: [PATCH v4 1/2] dt-bindings: mmc: mtk-sd: Add mt7988 SoC

Quoted 12 lines · Frank Wunderlich

From: Frank Wunderlich <[email protected]>

Add binding definitions for mmc on MT7988 SoC.

---
v4:
- drop minitems because of errors
v3:
- fixed minItems on clock-names too
v2:
- fixed minItems to 4

Quoted 3 lines
---
 .../devicetree/bindings/mmc/mtk-sd.yaml       | 22 +++++++++++++++++++
 1 file changed, 22 insertions(+)

Best regards,
Krzysztof

#4 lore raw

PATCH v4 2/2 mmc: mtk-sd: add support for mt7988

In reply to Frank Wunderlich

From: Frank Wunderlich <[email protected]>

Add support for mmc on MT7988 SoC.

We can use mt7986 platform data in driver, but mt7988 needs different clocks so for binding we need own compatible.

---
changes:
v4:
- explain mt7988 compatible with mt7986 platform data in commit description v3:
- reuse mt7986 platform data instead of copy

---
 drivers/mmc/host/mtk-sd.c | 1 +
 1 file changed, 1 insertion(+)
drivers/mmc/host/mtk-sd.c +1 -0
index 89018b6c97b9..aaf27fd211c1 100644
@@ -629,6 +629,7 @@ static const struct of_device_id msdc_of_ids[] = {
 	{ .compatible = "mediatek,mt7620-mmc", .data = &mt7620_compat},
 	{ .compatible = "mediatek,mt7622-mmc", .data = &mt7622_compat},
 	{ .compatible = "mediatek,mt7986-mmc", .data = &mt7986_compat},
+	{ .compatible = "mediatek,mt7988-mmc", .data = &mt7986_compat},
 	{ .compatible = "mediatek,mt8135-mmc", .data = &mt8135_compat},
 	{ .compatible = "mediatek,mt8173-mmc", .data = &mt8173_compat},
 	{ .compatible = "mediatek,mt8183-mmc", .data = &mt8183_compat},
Signature · 1 line
2.43.0
maintainer Reviewed-by on v4 2/2
#5 lore raw

Re: [PATCH v4 2/2] mmc: mtk-sd: add support for mt7988

Il 12/10/24 16:38, Frank Wunderlich ha scritto:

Quoted 8 lines

From: Frank Wunderlich <[email protected]>

Add support for mmc on MT7988 SoC.

We can use mt7986 platform data in driver, but mt7988 needs different clocks so for binding we need own compatible.

#6 lore raw
In reply to Frank Wunderlich
Quoted 10 lines · Frank Wunderlich

From: Frank Wunderlich <[email protected]>

Add MMC-Support for MT798 SoC

changes in v4:
- drop minitems because of dt_binding_check error
- explain mt7988 compatible with mt7986 platform data in commit description changes in v3:
- use mt7986 platform-data with the mt7988 compatible

Applied for next, thanks!

Kind regards
Uffe

Quoted 16 lines

changes in v2:
- corrected minItems to require all 4 clocks

Frank Wunderlich (2):
dt-bindings: mmc: mtk-sd: Add mt7988 SoC
mmc: mtk-sd: add support for mt7988

 .../devicetree/bindings/mmc/mtk-sd.yaml       | 22 +++++++++++++++++++
 drivers/mmc/host/mtk-sd.c                     |  1 +
 2 files changed, 23 insertions(+)

--
2.43.0