Skip to contentSkip to conversation

ffmpeg: Disable asm optimizations on x86

PATCH In review Khem Raj 3 participants 5 messages Oct 13, 2024 – Oct 14, 2024

lore
Share & tools
lore

Khem Raj

author
#0 lore raw

PATCH 1/1 ffmpeg: Disable asm optimizations on x86

disable asm code if PIC is required, as the provided asm decidedly is not PIC for x86.

---
 meta/recipes-multimedia/ffmpeg/ffmpeg_7.0.2.bb | 2 ++
 1 file changed, 2 insertions(+)
meta/recipes-multimedia/ffmpeg/ffmpeg_7.0.2.bb +2 -0
index af66104ebf3..3c66851b8d2 100644
@@ -129,6 +129,8 @@ EXTRA_OECONF = " \
 "
 
 EXTRA_OECONF:append:linux-gnux32 = " --disable-asm"
+# --enable-pic is used and x86 assembly is not PIC on x86
+EXTRA_OECONF:append:x86 = " --disable-asm"
 
 EXTRA_OECONF += "${@bb.utils.contains('TUNE_FEATURES', 'mipsisa64r6', '--disable-mips64r2 --disable-mips32r2', '', d)}"
 EXTRA_OECONF += "${@bb.utils.contains('TUNE_FEATURES', 'mipsisa64r2', '--disable-mips64r6 --disable-mips32r6', '', d)}"
#1 lore raw

Wouldn’t this be a build time error? Why is it not seen on the ab?

Alex

Quoted 37 lines · Khem Raj via lists.openembedded.org

disable asm code if PIC is required, as the provided asm decidedly is not PIC for x86.

---
 meta/recipes-multimedia/ffmpeg/ffmpeg_7.0.2.bb | 2 ++
 1 file changed, 2 insertions(+)
meta/recipes-multimedia/ffmpeg/ffmpeg_7.0.2.bb +2 -0
index af66104ebf3..3c66851b8d2 100644
@@ -129,6 +129,8 @@ EXTRA_OECONF = " \
 "
 
 EXTRA_OECONF:append:linux-gnux32 = " --disable-asm"
+# --enable-pic is used and x86 assembly is not PIC on x86
+EXTRA_OECONF:append:x86 = " --disable-asm"
 
 EXTRA_OECONF += "${@bb.utils.contains('TUNE_FEATURES', 'mipsisa64r6',

'--disable-mips64r2 --disable-mips32r2', '', d)}"
EXTRA_OECONF += "${@bb.utils.contains('TUNE_FEATURES', 'mipsisa64r2',
'--disable-mips64r6 --disable-mips32r6', '', d)}"

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group. View/Reply Online (#205724):
https://lists.openembedded.org/g/openembedded-core/message/205724
Mute This Topic: https://lists.openembedded.org/mt/108988536/1686489
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [ [email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

author
#2 lore raw
Quoted 2 lines · Alexander Kanavin

Wouldn’t this be a build time error? Why is it not seen on the ab?

It is a build time error with lld linker for sure I am not sure why we don't see it with GNU ld.

| i686-yoe-linux-ld.lld: error: relocation R_386_32 cannot be used against local symbol; recompile with -fPIC

| >>> defined in libavutil/x86/tx_float.o
| >>> referenced by tx_float.asm:228 (src/libavutil/x86/tx_float.asm:228)
| >>>               libavutil/x86/tx_float.o:(.text+0x668)

The files in question are compiled using nasm assembler for x86 and x86_64 here is full log
https://gist.github.com/kraj/12d633834d032d19005cdbac281390b7

Quoted 36 lines

Alex

Quoted 32 lines · Khem Raj via lists.openembedded.org

disable asm code if PIC is required, as the provided asm decidedly is not PIC for x86.

---
 meta/recipes-multimedia/ffmpeg/ffmpeg_7.0.2.bb | 2 ++
 1 file changed, 2 insertions(+)
meta/recipes-multimedia/ffmpeg/ffmpeg_7.0.2.bb +2 -1
index af66104ebf3..3c66851b8d2 100644
@@ -129,6 +129,8 @@ EXTRA_OECONF = " \
 "
 
 EXTRA_OECONF:append:linux-gnux32 = " --disable-asm"
+# --enable-pic is used and x86 assembly is not PIC on x86
+EXTRA_OECONF:append:x86 = " --disable-asm"
 
 EXTRA_OECONF += "${@bb.utils.contains('TUNE_FEATURES', 'mipsisa64r6', '--disable-mips64r2 --disable-mips32r2', '', d)}"
 EXTRA_OECONF += "${@bb.utils.contains('TUNE_FEATURES', 'mipsisa64r2', '--disable-mips64r6 --disable-mips32r6', '', d)}"
 
-=-=-=-=-=-=-=-=-=-=-=-

Links: You receive all messages sent to this group.
View/Reply Online (#205724): https://lists.openembedded.org/g/openembedded-core/message/205724
Mute This Topic: https://lists.openembedded.org/mt/108988536/1686489
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

#3 lore raw
In reply to Khem Raj
Quoted 3 lines · Khem Raj

disable asm code if PIC is required, as the provided asm decidedly is not PIC for x86.

I think I’d prefer to see a revert of the textrel change I sent, with a comment explaining how to trigger it. I tried, but didn’t considering trying ldd.

Ross

author
#4 lore raw
Quoted 7 lines · Ross Burton
Quoted 3 lines · Khem Raj

disable asm code if PIC is required, as the provided asm decidedly is not PIC for x86.

I think I’d prefer to see a revert of the textrel change I sent, with a comment explaining how to trigger it. I tried, but didn’t considering trying ldd.

well, revert is not required we should just apply this patch since the problem is only on x86/32bit + nasm assembler. For reproducer here is one

https://termbin.com/zbzg

I hope that should make it clear ?

Quoted 2 lines

Ross