ALSA: hda: Fix all stream interrupts definition
PATCH 1/1 ALSA: hda: Fix all stream interrupts definition
It is defined in header to 0xFF, which only allows to set values for 8 streams. In specification it is defined as bits from 0 to 29. In practice there is no HW with 29 streams, but as the only place where the value is used is chip initialization, it is best to make sure that all bits are reset properly.
Reviewed-by Cezary Rojewski <[email protected]>
Signed-off-by Amadeusz Sławiński <[email protected]>
--- include/sound/hda_register.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
include/sound/hda_register.h +1 -1
@@ -180,7 +180,7 @@ enum { SDI0, SDI1, SDI2, SDI3, SDO0, SDO1, SDO2, SDO3 };#define SD_STS_FIFO_READY 0x20/* FIFO ready */ /* INTCTL and INTSTS */ -#define AZX_INT_ALL_STREAM 0xff/* all stream interrupts */ +#define AZX_INT_ALL_STREAM 0x3fffffff/* all stream interrupts */ #define AZX_INT_CTRL_EN 0x40000000/* controller interrupt enable bit */ #define AZX_INT_GLOBAL_EN 0x80000000/* global interrupt enable bit */
Signature · 1 line
2.34.1
Takashi Iwai
AppliedQuoted 9 lines · Amadeusz Sławiński
It is defined in header to
0xFF, which only allows to set values for 8 streams. In specification it is defined as bits from 0 to 29. In practice there is no HW with 29 streams, but as the only place where the value is used is chip initialization, it is best to make sure that all bits are reset properly.Reviewed-by Cezary Rojewski <[email protected]>Signed-off-by Amadeusz Sławiński <[email protected]>
Applied to for-next branch. Thanks.
Takashi