ACPI: pfr_telemetry: remove redundant error check on ret
Subsystems (2)
PATCH 1/1 ACPI: pfr_telemetry: remove redundant error check on ret
The variable ret is initialized to zero and a littler later in the PFRT_LOG_IOC_GET_INFO case of a switch statement is being checked for negative error value. Since ret has not been re-assigned since the initialization ret can never be less than zero so the check is redundant and can be removed. Remove it.
--- drivers/acpi/pfr_telemetry.c | 3 --- 1 file changed, 3 deletions(-)
drivers/acpi/pfr_telemetry.c +0 -3
@@ -272,9 +272,6 @@ static long pfrt_log_ioctl(struct file *file, unsigned int cmd, unsigned long arcase PFRT_LOG_IOC_GET_INFO : info.log_level =get_pfrt_log_level (pfrt_log_dev); -if (ret <0 ) -return ret; - info.log_type = pfrt_log_dev->info.log_type; info.log_revid = pfrt_log_dev->info.log_revid;if (copy_to_user (p, &info,sizeof (info)))
Signature · 1 line
2.39.5
Quoted 17 lines · Colin Ian King
The variable ret is initialized to zero and a littler later in the
PFRT_LOG_IOC_GET_INFOcase of a switch statement is being checked for negative error value. Since ret has not been re-assigned since the initialization ret can never be less than zero so the check is redundant and can be removed. Remove it.Signed-off-by Colin Ian King <[email protected]>--- drivers/acpi/pfr_telemetry.c | 3 --- 1 file changed, 3 deletions(-)drivers/acpi/pfr_telemetry.c +0
-0
drivers/acpi/pfr_telemetry.c static long pfrt_log_ioctl(struct file *file, unsigned int cmd, unsigned long ar
Quoted 10 lines
drivers/acpi/pfr_telemetry.c +0
-4@@ -272,9 +272,6 @@ static long pfrt_log_ioctl(struct file *file, unsigned int cmd, unsigned long arcase PFRT_LOG_IOC_GET_INFO : info.log_level =get_pfrt_log_level (pfrt_log_dev); -if (ret <0 ) -return ret; - info.log_type = pfrt_log_dev->info.log_type; info.log_revid = pfrt_log_dev->info.log_revid;if (copy_to_user (p, &info,sizeof (info))) --
Applied as 6.13 material, thanks!