Skip to contentSkip to conversation

arm64: dts: qcom: Drop undocumented domain "idle-state-name"

PATCH Applied Rob Herring (Arm) 2 participants 2 messages Oct 14, 2024 – Oct 16, 2024

Subsystems (4)
Device tree bindings Arm Qualcomm mailing list Arm Qualcomm support Arm/Qualcomm chromebook support
lore
Share & tools
lore

Rob Herring (Arm)

author maintainer
#0 lore raw

PATCH 1/1 arm64: dts: qcom: Drop undocumented domain "idle-state-name"

"idle-state-name" is not a valid property for "domain-idle-state" binding, so drop it.

Signed-off-by Rob Herring (Arm) <[email protected]>

---
Alternatively, the property could be added to the binding. In that case, the 2 idle state bindings should be refactored with the common properties factored out. Since no one seems to have cared despite reported warnings on every new board of these platforms, I don't either and went with the simple change.

 arch/arm64/boot/dts/qcom/sc7180.dtsi   | 3 ---
 arch/arm64/boot/dts/qcom/x1e80100.dtsi | 2 --
 2 files changed, 5 deletions(-)
arch/arm64/boot/dts/qcom/sc7180.dtsi +0 -3
index b5ebf8980325..dec25a0d9057 100644
@@ -357,7 +357,6 @@ BIG_CPU_SLEEP_1: cpu-sleep-1-1 {
 		domain_idle_states: domain-idle-states {
 			CLUSTER_SLEEP_PC: cluster-sleep-0 {
 				compatible = "domain-idle-state";
-				idle-state-name = "cluster-l3-power-collapse";
 				arm,psci-suspend-param = <0x41000044>;
 				entry-latency-us = <2752>;
 				exit-latency-us = <3048>;

@@ -366,7 +365,6 @@ CLUSTER_SLEEP_PC: cluster-sleep-0 {
 
 			CLUSTER_SLEEP_CX_RET: cluster-sleep-1 {
 				compatible = "domain-idle-state";
-				idle-state-name = "cluster-cx-retention";
 				arm,psci-suspend-param = <0x41001244>;
 				entry-latency-us = <3638>;
 				exit-latency-us = <4562>;

@@ -375,7 +373,6 @@ CLUSTER_SLEEP_CX_RET: cluster-sleep-1 {
 
 			CLUSTER_AOSS_SLEEP: cluster-sleep-2 {
 				compatible = "domain-idle-state";
-				idle-state-name = "cluster-power-down";
 				arm,psci-suspend-param = <0x4100b244>;
 				entry-latency-us = <3263>;
 				exit-latency-us = <6562>;
arch/arm64/boot/dts/qcom/x1e80100.dtsi +0 -2
index a36076e3c56b..847d6bc39edd 100644
@@ -287,7 +287,6 @@ CLUSTER_C4: cpu-sleep-0 {
 		domain-idle-states {
 			CLUSTER_CL4: cluster-sleep-0 {
 				compatible = "domain-idle-state";
-				idle-state-name = "l2-ret";
 				arm,psci-suspend-param = <0x01000044>;
 				entry-latency-us = <350>;
 				exit-latency-us = <500>;

@@ -296,7 +295,6 @@ CLUSTER_CL4: cluster-sleep-0 {
 
 			CLUSTER_CL5: cluster-sleep-1 {
 				compatible = "domain-idle-state";
-				idle-state-name = "ret-pll-off";
 				arm,psci-suspend-param = <0x01000054>;
 				entry-latency-us = <2200>;
 				exit-latency-us = <2500>;
Signature · 1 line
2.45.2
maintainer Applied
#1 lore raw
Quoted 4 lines · Rob Herring (Arm)

"idle-state-name" is not a valid property for "domain-idle-state" binding, so drop it.

Applied, thanks!

[1/1] arm64: dts: qcom: Drop undocumented domain "idle-state-name"

      commit: 422f2d418186e3779957a8e4aee7f243ae4cd45e

Best regards,

Signature · 1 line
Bjorn Andersson <[email protected]>