media: nuvoton: Fix an error check in npcm_video_ece_init()
Subsystems (2)
PATCH 1/1 media: nuvoton: Fix an error check in npcm_video_ece_init()
When function of_find_device_by_node() fails, it returns NULL instead of an error code. So the corresponding error check logic should be modified to check whether the return value is NULL and set the error code to be returned as -ENODEV.
Fixes 46c15a4ff1f4 ("media: nuvoton: Add driver for NPCM video capture and encoding engine")
Signed-off-by Zhen Lei <[email protected]>
--- drivers/media/platform/nuvoton/npcm-video.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/media/platform/nuvoton/npcm-video.c +2 -2
@@ -1667,9 +1667,9 @@ static int npcm_video_ece_init(struct npcm_video *video)dev_info (dev,"Support HEXTILE pixel format\n" ); ece_pdev =of_find_device_by_node (ece_node); -if (IS_ERR (ece_pdev)) { +if (!ece_pdev) {dev_err (dev,"Failed to find ECE device\n" ); -return PTR_ERR (ece_pdev); +return -ENODEV ; }of_node_put (ece_node);
Signature · 1 line
2.34.1