nvme-tcp: forward context to teardown admin queue function
PATCH 1/1 nvme-tcp: forward context to teardown admin queue function
nvme_tcp_setup_ctrl is called from different contexts. If the function is called as part of the initial controller creation, the argument 'new' is set to true. This tells the function to free all resources when an error occurs.
Thus nvme_tcp_teardown_admin_queue should also be called with 'new' and not always with 'false'.
--- drivers/nvme/host/tcp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/nvme/host/tcp.c +1 -1
@@ -2278,7 +2278,7 @@ static int nvme_tcp_setup_ctrl(struct nvme_ctrl *ctrl, bool new) } destroy_admin:nvme_stop_keep_alive (ctrl); -nvme_tcp_teardown_admin_queue (ctrl, false); +nvme_tcp_teardown_admin_queue (ctrl, new);return ret; }
Signature · 1 line
2.47.0
Quoted 7 lines · Daniel Wagner
nvme_tcp_setup_ctrlis called from different contexts. If the function is called as part of the initial controller creation, the argument 'new' is set to true. This tells the function to free all resources when an error occurs.Thus
nvme_tcp_teardown_admin_queueshould also be called with 'new' and not always with 'false'.
Looks good:
Quoted 19 lines · Daniel Wagner
nvme_tcp_setup_ctrlis called from different contexts. If the function is called as part of the initial controller creation, the argument 'new' is set to true. This tells the function to free all resources when an error occurs.Thus
nvme_tcp_teardown_admin_queueshould also be called with 'new' and not always with 'false'.Fixes fd1418de10b9 ("nvme-tcp: avoid open-coding nvme_tcp_teardown_admin_queue()")Signed-off-by Daniel Wagner <[email protected]>--- drivers/nvme/host/tcp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/nvme/host/tcp.c +0
-0
drivers/nvme/host/tcp.c static int nvme_tcp_setup_ctrl(struct nvme_ctrl *ctrl, bool new) · line 2284
Quoted 8 lines
drivers/nvme/host/tcp.c +1
-1@@ -2278,7 +2278,7 @@ static int nvme_tcp_setup_ctrl(struct nvme_ctrl *ctrl, bool new) } destroy_admin:nvme_stop_keep_alive (ctrl); -nvme_tcp_teardown_admin_queue (ctrl, false); +nvme_tcp_teardown_admin_queue (ctrl, new);return ret; }
Cheers,
Hannes
Signature · 4 lines
Dr. Hannes Reinecke Kernel Storage Architect [email protected] +49 911 74053 688 SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich