Skip to contentSkip to conversation

drm/imx: parallel-display: add legacy bridge Kconfig dependency

PATCH Applied Arnd Bergmann 3 participants 5 messages Oct 15, 2024 – Oct 22, 2024

Subsystems (6)
DRM drivers DRM misc Arm i.MX and Layerscape DRM drivers for bridge chips +2 more subsystems
lore
Share & tools
lore

Arnd Bergmann

author
#0 lore raw

PATCH 1/2 drm/imx: parallel-display: add legacy bridge Kconfig dependency

From: Arnd Bergmann <[email protected]>

The driver now uses the legacy bridge helper code but can be configured to get built without it:

ERROR: modpost: "devm_imx_drm_legacy_bridge" [drivers/gpu/drm/imx/ipuv3/parallel-display.ko] undefined!

Add the required dependency, same as in the ldb driver.

Fixes f94b9707a1c9 ("drm/imx: parallel-display: switch to imx_legacy_bridge / drm_bridge_connector")
Signed-off-by Arnd Bergmann <[email protected]>
---
 drivers/gpu/drm/imx/ipuv3/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/gpu/drm/imx/ipuv3/Kconfig +1 -0
index 0ea1feb84672..acaf25089001 100644
@@ -15,6 +15,7 @@ config DRM_IMX_PARALLEL_DISPLAY
 	depends on DRM_IMX
 	select DRM_BRIDGE
 	select DRM_BRIDGE_CONNECTOR
+	select DRM_IMX_LEGACY_BRIDGE
 	select DRM_PANEL_BRIDGE
 	select VIDEOMODE_HELPERS
Signature · 1 line
2.39.5
author
#1 lore raw

PATCH 2/2 drm/imx: legacy-bridge: add MODULE_DESCRIPTION

From: Arnd Bergmann <[email protected]>

Every module should have a description, without this we get a build time warning.

Fixes cc3e8a216d6b ("drm/imx: add internal bridge handling display-timings DT node")
Signed-off-by Arnd Bergmann <[email protected]>
---
 drivers/gpu/drm/bridge/imx/imx-legacy-bridge.c | 1 +
 1 file changed, 1 insertion(+)
drivers/gpu/drm/bridge/imx/imx-legacy-bridge.c +1 -0
index 07a78a02a884..3ebf0b9866de 100644
@@ -85,3 +85,4 @@ struct drm_bridge *devm_imx_drm_legacy_bridge(struct device *dev,
 EXPORT_SYMBOL_GPL(devm_imx_drm_legacy_bridge);
 
 MODULE_LICENSE("GPL");
+MODULE_DESCRIPTION("Freescale i.MX DRM bridge driver for legacy DT bindings");
Signature · 1 line
2.39.5
Reviewed-by on v1 2/2
#2 lore raw

Re: [PATCH 2/2] drm/imx: legacy-bridge: add MODULE_DESCRIPTION

Quoted 11 lines · Arnd Bergmann

From: Arnd Bergmann <[email protected]>

Every module should have a description, without this we get a build time warning.

Fixes cc3e8a216d6b ("drm/imx: add internal bridge handling display-timings DT node")
Signed-off-by Arnd Bergmann <[email protected]>
---
 drivers/gpu/drm/bridge/imx/imx-legacy-bridge.c | 1 +
 1 file changed, 1 insertion(+)
Reviewed-by Dmitry Baryshkov <[email protected]>
Signature · 2 lines
With best wishes
Dmitry
Reviewed-by on v1 1/2
#3 lore raw
In reply to Arnd Bergmann
Quoted 7 lines · Arnd Bergmann

From: Arnd Bergmann <[email protected]>

The driver now uses the legacy bridge helper code but can be configured to get built without it:

ERROR: modpost: "devm_imx_drm_legacy_bridge" [drivers/gpu/drm/imx/ipuv3/parallel-display.ko] undefined!

Quoted 8 lines

Add the required dependency, same as in the ldb driver.

Fixes f94b9707a1c9 ("drm/imx: parallel-display: switch to imx_legacy_bridge / drm_bridge_connector")
Signed-off-by Arnd Bergmann <[email protected]>
---
 drivers/gpu/drm/imx/ipuv3/Kconfig | 1 +
 1 file changed, 1 insertion(+)
Reviewed-by Dmitry Baryshkov <[email protected]>
Signature · 2 lines
With best wishes
Dmitry
maintainer Applied
#4 lore raw
In reply to Arnd Bergmann
Quoted 8 lines · Arnd Bergmann

The driver now uses the legacy bridge helper code but can be configured to get built without it:

ERROR: modpost: "devm_imx_drm_legacy_bridge" [drivers/gpu/drm/imx/ipuv3/parallel-display.ko] undefined!

Add the required dependency, same as in the ldb driver.

[...]

Applied, thanks!

[1/2] drm/imx: parallel-display: add legacy bridge Kconfig dependency

      https://gitlab.freedesktop.org/drm/misc/kernel/-/commit/ef214002e6b3
[2/2] drm/imx: legacy-bridge: add MODULE_DESCRIPTION
      https://gitlab.freedesktop.org/drm/misc/kernel/-/commit/df606be44c16

Rob