Skip to contentSkip to conversation

perf test: Fix perf test case 84 on s390

PATCH In review Thomas Richter 2 participants 2 messages Oct 15, 2024 – Oct 17, 2024 perf events

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 perf test: Fix perf test case 84 on s390

Perf test case 84 'perf pipe recording and injection test' sometime fails on s390, especially on z/VM virtual machines.

This is caused by a very short run time of workload

  # perf test -w noploop

which runs for 1 second. Occasionally this is not long enough and the perf report has no samples for symbol noploop.

Fix this and enlarge the runtime for the perf work load to 3 seconds. This ensures the symbol noploop is always present.

Output before:
Inject -b build-ids test
[ perf record: Woken up 1 times to write data ] [ perf record: Captured and wrote 0.195 MB - ]
[ perf record: Woken up 1 times to write data ] [ perf record: Captured and wrote 0.277 MB - ]
[ perf record: Woken up 1 times to write data ] [ perf record: Captured and wrote 0.195 MB - ]
[ perf record: Woken up 1 times to write data ] [ perf record: Captured and wrote 0.160 MB

			 /tmp/perf.data.ELzRdq (4031 samples) ]

[ perf record: Woken up 1 times to write data ] [ perf record: Captured and wrote 0.195 MB - ]
[ perf record: Woken up 1 times to write data ] [ perf record: Captured and wrote 0.195 MB - ] Inject -b build-ids test [Success]

Inject --buildid-all build-ids test
[ perf record: Woken up 1 times to write data ]
[ perf record: Captured and wrote 0.195 MB - ]
[ perf record: Woken up 1 times to write data ]
[ perf record: Captured and wrote 0.014 MB - ] Inject --buildid-all build-ids test [Failed - cannot find
noploop function in pipe #2]

Output after:
Successful execution for over 10 times in a loop.

---
 tools/perf/tests/shell/pipe_test.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/perf/tests/shell/pipe_test.sh +1 -1
index d4c8005ce9b9..02d9ef27c8e7 100755
@@ -12,7 +12,7 @@ skip_test_missing_symbol ${sym}
 
 data=$(mktemp /tmp/perf.data.XXXXXX)
 data2=$(mktemp /tmp/perf.data2.XXXXXX)
-prog="perf test -w noploop"
+prog="perf test -w noploop 3"
 err=0
 
 set -e
Signature · 1 line
2.47.0
maintainer
#1 lore raw

Hello,

Quoted 5 lines · Thomas Richter

Perf test case 84 'perf pipe recording and injection test' sometime fails on s390, especially on z/VM virtual machines.

This is caused by a very short run time of workload

Quoted 8 lines
  # perf test -w noploop

which runs for 1 second. Occasionally this is not long enough and the perf report has no samples for symbol noploop.

Fix this and enlarge the runtime for the perf work load to 3 seconds. This ensures the symbol noploop is always present.

Hmm.. but it would slow down the test quite a lot. Can you please make it conditional on s390 or something?

Maybe you could add a fallback logic to increase the period if it fails.

Thanks,
Namhyung

Quoted 51 lines

Output before:
Inject -b build-ids test
[ perf record: Woken up 1 times to write data ] [ perf record: Captured and wrote 0.195 MB - ]
[ perf record: Woken up 1 times to write data ] [ perf record: Captured and wrote 0.277 MB - ]
[ perf record: Woken up 1 times to write data ] [ perf record: Captured and wrote 0.195 MB - ]
[ perf record: Woken up 1 times to write data ] [ perf record: Captured and wrote 0.160 MB

			 /tmp/perf.data.ELzRdq (4031 samples) ]

[ perf record: Woken up 1 times to write data ] [ perf record: Captured and wrote 0.195 MB - ]
[ perf record: Woken up 1 times to write data ] [ perf record: Captured and wrote 0.195 MB - ] Inject -b build-ids test [Success]

Inject --buildid-all build-ids test
[ perf record: Woken up 1 times to write data ]
[ perf record: Captured and wrote 0.195 MB - ]
[ perf record: Woken up 1 times to write data ]
[ perf record: Captured and wrote 0.014 MB - ] Inject --buildid-all build-ids test [Failed - cannot find
noploop function in pipe #2]

Output after:
Successful execution for over 10 times in a loop.

---
 tools/perf/tests/shell/pipe_test.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/perf/tests/shell/pipe_test.sh +1 -1
index d4c8005ce9b9..02d9ef27c8e7 100755
@@ -12,7 +12,7 @@ skip_test_missing_symbol ${sym}
 
 data=$(mktemp /tmp/perf.data.XXXXXX)
 data2=$(mktemp /tmp/perf.data2.XXXXXX)
-prog="perf test -w noploop"
+prog="perf test -w noploop 3"
 err=0
 
 set -e
Signature · 1 line
2.47.0