resource: Remove dependency on SPARSEMEM from GET_FREE_REGION
Subsystems (2)
PATCH 1/1 resource: Remove dependency on SPARSEMEM from GET_FREE_REGION
We want to use the functions (get_free_mem_region()) configured via GET_FREE_REGION in resource kunit tests. However, GET_FREE_REGION depends on SPARSEMEM now. This makes resource kunit tests cannot be built on some architectures lacking SPARSEMEM, or causes config warning as follows,
WARNING: unmet direct dependencies detected for GET_FREE_REGION Depends on [n]: SPARSEMEM [=n]
Selected by [y]:
- RESOURCE_KUNIT_TEST [=y] && RUNTIME_TESTING_MENU [=y] && KUNIT [=y]
When get_free_mem_region() was introduced the only consumers were those looking to pass the address range to memremap_pages(). That address range needed to be mindful of the maximum addressable platform physical address which at the time only SPARSMEM defined via MAX_PHYSMEM_BITS.
Given that memremap_pages() also depended on SPARSEMEM via ZONE_DEVICE, it was easier to just depend on that definition than invent a general MAX_PHYSMEM_BITS concept outside of SPARSEMEM.
Turns out that decision was buggy and did not account for KASAN consumption of physical address space. That problem was resolved recently with commit ea72ce5da228 ("x86/kaslr: Expose and use the end of the physical memory address space"), and GET_FREE_REGION dropped its MAX_PHYSMEM_BITS dependency.
Then commit 99185c10d5d9 ("resource, kunit: add test case for region_intersects()"), went ahead and fixed up the only remaining dependency on SPARSEMEM which was usage of the PA_SECTION_SHIFT macro for setting the default alignment. A PAGE_SIZE fallback is fine in the SPARSEMEM=n case.
With those build dependencies gone GET_FREE_REGION no longer depends on SPARSEMEM. So, the patch removes dependency on SPARSEMEM from GET_FREE_REGION to fix the build issues.
--- mm/Kconfig | 1 - 1 file changed, 1 deletion(-)
mm/Kconfig +0 -1
@@ -1085,7 +1085,6 @@ config HMM_MIRROR depends on MMU config GET_FREE_REGION - depends on SPARSEMEM bool config DEVICE_PRIVATE
Signature · 1 line
2.39.2
Quoted 56 lines · Huang Ying
We want to use the functions (
get_free_mem_region()) configured viaGET_FREE_REGIONin resource kunit tests. However,GET_FREE_REGIONdepends on SPARSEMEM now. This makes resource kunit tests cannot be built on some architectures lacking SPARSEMEM, or causes config warning as follows,WARNING: unmet direct dependencies detected for
GET_FREE_REGIONDepends on [n]: SPARSEMEM [=n]
Selected by [y]:
-RESOURCE_KUNIT_TEST[=y] &&RUNTIME_TESTING_MENU[=y] && KUNIT [=y]When
get_free_mem_region()was introduced the only consumers were those looking to pass the address range tomemremap_pages(). That address range needed to be mindful of the maximum addressable platform physical address which at the time only SPARSMEM defined viaMAX_PHYSMEM_BITS.Given that
memremap_pages()also depended on SPARSEMEM viaZONE_DEVICE, it was easier to just depend on that definition than invent a generalMAX_PHYSMEM_BITSconcept outside of SPARSEMEM.Turns out that decision was buggy and did not account for KASAN consumption of physical address space. That problem was resolved recently with commit
ea72ce5da228("x86/kaslr: Expose and use the end of the physical memory address space"), andGET_FREE_REGIONdropped itsMAX_PHYSMEM_BITSdependency.Then commit
99185c10d5d9("resource, kunit: add test case forregion_intersects()"), went ahead and fixed up the only remaining dependency on SPARSEMEM which was usage of thePA_SECTION_SHIFTmacro for setting the default alignment. APAGE_SIZEfallback is fine in the SPARSEMEM=n case.With those build dependencies gone
GET_FREE_REGIONno longer depends on SPARSEMEM. So, the patch removes dependency on SPARSEMEM fromGET_FREE_REGIONto fix the build issues.Fixes 99185c10d5d9 ("resource, kunit: add test case for region_intersects()")Signed-off-by "Huang, Ying" <[email protected]>Co-developed-by Dan Williams <[email protected]>Signed-off-by Dan Williams <[email protected]>Tested-by Guenter Roeck <[email protected]>Cc Nathan Chancellor <[email protected]>Cc Arnd Bergmann <[email protected]>Cc David Hildenbrand <[email protected]>Cc Jonathan Cameron <[email protected]>--- mm/Kconfig | 1 - 1 file changed, 1 deletion(-)mm/Kconfig +0
-0
mm/Kconfig config HMM_MIRROR · line 1090
Quoted 7 lines
mm/Kconfig +0
-1@@ -1085,7 +1085,6 @@ config HMM_MIRROR depends on MMU config GET_FREE_REGION - depends on SPARSEMEM bool config DEVICE_PRIVATE
Signature · 3 lines
Cheers, David / dhildenb
Quoted 37 lines · Huang Ying
We want to use the functions (
get_free_mem_region()) configured viaGET_FREE_REGIONin resource kunit tests. However,GET_FREE_REGIONdepends on SPARSEMEM now. This makes resource kunit tests cannot be built on some architectures lacking SPARSEMEM, or causes config warning as follows,WARNING: unmet direct dependencies detected for
GET_FREE_REGIONDepends on [n]: SPARSEMEM [=n]
Selected by [y]:
-RESOURCE_KUNIT_TEST[=y] &&RUNTIME_TESTING_MENU[=y] && KUNIT [=y]When
get_free_mem_region()was introduced the only consumers were those looking to pass the address range tomemremap_pages(). That address range needed to be mindful of the maximum addressable platform physical address which at the time only SPARSMEM defined viaMAX_PHYSMEM_BITS.Given that
memremap_pages()also depended on SPARSEMEM viaZONE_DEVICE, it was easier to just depend on that definition than invent a generalMAX_PHYSMEM_BITSconcept outside of SPARSEMEM.Turns out that decision was buggy and did not account for KASAN consumption of physical address space. That problem was resolved recently with commit
ea72ce5da228("x86/kaslr: Expose and use the end of the physical memory address space"), andGET_FREE_REGIONdropped itsMAX_PHYSMEM_BITSdependency.Then commit
99185c10d5d9("resource, kunit: add test case forregion_intersects()"), went ahead and fixed up the only remaining dependency on SPARSEMEM which was usage of thePA_SECTION_SHIFTmacro for setting the default alignment. APAGE_SIZEfallback is fine in the SPARSEMEM=n case.With those build dependencies gone
GET_FREE_REGIONno longer depends on SPARSEMEM. So, the patch removes dependency on SPARSEMEM fromGET_FREE_REGIONto fix the build issues.
Quoted 6 lines
Fixes 99185c10d5d9 ("resource, kunit: add test case for region_intersects()")Signed-off-by "Huang, Ying" <[email protected]>Co-developed-by Dan Williams <[email protected]>Signed-off-by Dan Williams <[email protected]>Tested-by Guenter Roeck <[email protected]>
Thanks for adding the Fixes tag, as this should go via -hotfixes.
Quoted 22 lines
Cc Arnd Bergmann <[email protected]>Cc David Hildenbrand <[email protected]>Cc Jonathan Cameron <[email protected]>--- mm/Kconfig | 1 - 1 file changed, 1 deletion(-)mm/Kconfig +0
-1@@ -1085,7 +1085,6 @@ config HMM_MIRROR depends on MMU config GET_FREE_REGION - depends on SPARSEMEM bool config DEVICE_PRIVATESignature · 1 line
2.39.2