Skip to contentSkip to conversation

bcachefs: Correct the description of the '--bucket=size' options

PATCH In review Youling Tang 2 participants 3 messages Oct 16, 2024 – Nov 7, 2024

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 bcachefs: Correct the description of the '--bucket=size' options

From: Youling Tang <[email protected]>

---
 fs/bcachefs/opts.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
fs/bcachefs/opts.h +1 -1
index cb2e244a2429..92eae5636f2b 100644
@@ -487,7 +487,7 @@ enum fsck_err_opts {
 	  OPT_DEVICE,							\
 	  OPT_UINT(0, S64_MAX),						\
 	  BCH2_NO_SB_OPT,		0,				\
-	  "size",	"Size of filesystem on device")			\
+	  "size",	"Specifies the bucket size; must be greater than the btree node size")\
 	x(durability,			u8,				\
 	  OPT_DEVICE|OPT_SB_FIELD_ONE_BIAS,				\
 	  OPT_UINT(0, BCH_REPLICAS_MAX),				\
Signature · 1 line
2.34.1
#1 lore raw

Hi, Kent

Give you a friendly ping. 🙂

BTW, is the following patch needed?
[1] https://lore.kernel.org/linux-bcachefs/[email protected]/
[2] https://lore.kernel.org/linux-bcachefs/[email protected]/
[3] https://lore.kernel.org/linux-bcachefs/[email protected]/
[4] https://lore.kernel.org/linux-bcachefs/[email protected]/

Thanks,
Youling.

Quoted 20 lines · Youling Tang

From: Youling Tang <[email protected]>

---
  fs/bcachefs/opts.h | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
fs/bcachefs/opts.h +1 -1
index cb2e244a2429..92eae5636f2b 100644
@@ -487,7 +487,7 @@ enum fsck_err_opts {
  	  OPT_DEVICE,							\
  	  OPT_UINT(0, S64_MAX),						\
  	  BCH2_NO_SB_OPT,		0,				\
-	  "size",	"Size of filesystem on device")			\
+	  "size",	"Specifies the bucket size; must be greater than the btree node size")\
  	x(durability,			u8,				\
  	  OPT_DEVICE|OPT_SB_FIELD_ONE_BIAS,				\
  	  OPT_UINT(0, BCH_REPLICAS_MAX),				\